From nobody Sun Sep 24 10:54:03 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RtjYS10PQz4tnS8; Sun, 24 Sep 2023 10:54:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RtjYS0F8Dz4L5Q; Sun, 24 Sep 2023 10:54:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695552844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/3E9LTD+xrJCp894TUYIJn5HdAtXNuX0iKn7r/2fQ+I=; b=D1WHmRVFOuka7L7r7i1gks5pE9KhdiUOunRcu6NbORpe3wPLHWIW3WiicOt2tcq0dzRHHy E0RDb0LylMwWM/FVaRVkr7K9YLfuLAILQkdCvQHccmVrNmAnEazL/8krx1cBbKtoU+2Ow2 yayCfaPV9FiaVNL7VvHT6kmCkJFDE2SFhNInYJHDGTsa9AKoLpLKsXHACH27fvWIO9tkD9 S5ebU5A6xPJo2WUjUT5iCLX88Ajz8Go40nkfbbvdDWKVVSOHj923DCyWOl7JgBATSe94Hf P+CQOZt8ykoqrTkxWOXTfKCltpLWRYyPH6xVRH8804rDey7Vm9jjxg3UaRXM2A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695552844; a=rsa-sha256; cv=none; b=XoV4SqtFboFcnI+P3q4W2U/MyY6d6fTAVQEPZfq7aTsJn+MRsFXBkE1hcDPI72mUbHBYXP IqfjS/nqrDuhQowZgemZ+f0CumHevPWx08pfOFPdi2O3uR6C6hsFo/1LgJhr1lUIt4Yh6r z4sZH/cnYWYP4arDVEZLaSidAVfRWluZsNTiRB+28kusMnE26ewAg1aaVC024/ON3cxjS2 3LshW8zatC6ypzhgRKVslzUnLGUq9qnkQ932RbGS+Y3/v/wLP5e1NKDqE3kPAgzTgomPVr 1kj2caNCOqqVrXxtc6NKrA9wX0On8RbmB5k5dNIj6QVAy+mYzCFS16+FZTPbNg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695552844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/3E9LTD+xrJCp894TUYIJn5HdAtXNuX0iKn7r/2fQ+I=; b=AKvIZKMQxf+NxXq2VHr1EAxPET8jpFWVuToTP882Ff0S6aisD4byBHtdPDzdJPD3QGlAAD hRTsUWzLznsT37H+skBNTF+cwmBzhCHeOR3za4D+znouGsAPS1sbl01FPlTiTh/rBPxMN1 FW5cR5YmqeCXP2qwV05XlhP7tYU2Gqf16WESloEPXzMXpjgWzxZOjSJ1d77ZlEU0idsOYW jkUheDu7XeQ+off9Cj7mRIkCOmhiSK4qK0hvegdLIdjZzgqVd6s8irFTZsyxoh7B1eV8kw x/YT7N+Qf3L+geezFHE/utERebdZo5Eb/pGGrj/L+oBxEjIwb+F4uCLfqcW85w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RtjYR6Q0szk0x; Sun, 24 Sep 2023 10:54:03 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38OAs3sw046097; Sun, 24 Sep 2023 10:54:03 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38OAs37N046094; Sun, 24 Sep 2023 10:54:03 GMT (envelope-from git) Date: Sun, 24 Sep 2023 10:54:03 GMT Message-Id: <202309241054.38OAs37N046094@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dmitry Chagin Subject: git: e68a2f18b64a - stable/14 - linux(4): Validate exec_setregs on arm64 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dchagin X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e68a2f18b64a0b3b6e17f4a8ada68c6332e14423 Auto-Submitted: auto-generated The branch stable/14 has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=e68a2f18b64a0b3b6e17f4a8ada68c6332e14423 commit e68a2f18b64a0b3b6e17f4a8ada68c6332e14423 Author: Dmitry Chagin AuthorDate: 2023-09-05 18:19:08 +0000 Commit: Dmitry Chagin CommitDate: 2023-09-24 10:51:36 +0000 linux(4): Validate exec_setregs on arm64 The lr register is cleared at the beginning of the _dl_start and _start, so there is no need to initialize it. Gnu libc _start takes an rtld_fini pointer in x0 which is set by ld.so for __libc_start_main, the kernel does not register any atexit pointers. While here fix whitespaces. MFC after: 1 week (cherry picked from commit 20845a6994c548977874d1f413044d43c8474f0a) --- sys/arm64/linux/linux_sysvec.c | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/sys/arm64/linux/linux_sysvec.c b/sys/arm64/linux/linux_sysvec.c index 885ac4657380..3072732de768 100644 --- a/sys/arm64/linux/linux_sysvec.c +++ b/sys/arm64/linux/linux_sysvec.c @@ -51,7 +51,6 @@ #include #include -#include #include #include #include @@ -107,12 +106,6 @@ static void linux_exec_sysvec_init(void *param); static int linux_on_exec_vmspace(struct proc *p, struct image_params *imgp); -/* DTrace init */ -LIN_SDT_PROVIDER_DECLARE(LINUX_DTRACE); - -/* DTrace probes */ -LIN_SDT_PROBE_DEFINE0(sysvec, linux_exec_setregs, todo); - LINUX_VDSO_SYM_CHAR(linux_platform); LINUX_VDSO_SYM_INTPTR(kern_timekeep_base); LINUX_VDSO_SYM_INTPTR(__user_rt_sigreturn); @@ -178,19 +171,9 @@ linux_exec_setregs(struct thread *td, struct image_params *imgp, struct trapframe *regs = td->td_frame; struct pcb *pcb = td->td_pcb; - /* LINUXTODO: validate */ - LIN_SDT_PROBE0(sysvec, linux_exec_setregs, todo); - memset(regs, 0, sizeof(*regs)); - /* glibc start.S registers function pointer in x0 with atexit. */ - regs->tf_sp = stack; -#if 0 /* LINUXTODO: See if this is used. */ - regs->tf_lr = imgp->entry_addr; -#else - regs->tf_lr = 0xffffffffffffffff; -#endif - regs->tf_elr = imgp->entry_addr; - + regs->tf_sp = stack; + regs->tf_elr = imgp->entry_addr; pcb->pcb_tpidr_el0 = 0; pcb->pcb_tpidrro_el0 = 0; WRITE_SPECIALREG(tpidrro_el0, 0);