From nobody Fri Sep 15 08:49:02 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rn7CL5Ymhz4tKm7; Fri, 15 Sep 2023 08:49:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rn7CL56Hvz4TQP; Fri, 15 Sep 2023 08:49:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694767742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WkC+uuS//wiaY9vnmkBGD6aj8bovAVPSZZdwCz7F7hU=; b=snoPzB9T0xOizWSUmpw49sKepg33QNzvMhAE5iNDaAzlgojLnlOmoo7PLfkE54cEBX7ZYa 7aV4KMyt70SDM9OVDeQPfZBgPfKxICTSoIqSFhWzoMh8ZDAcYF7peo73Pk++xxEgg551Aa QzBikXjbiLj7dIbJbCJG5AM1bE1ZbId2KkDhxCMPiA0JnesREGs3NPH50XL3p5sQIts7Gm k0UziMKwGiPy3i2RMQnuO7dEyJrxJvQi6a9vZEM3PHdHBjDKfn8F8Z3o68NAjK1MfszXl6 xMdp1Nl1ONG+CrwsWhqr1JaY2SL2EFxtPVzcoIyJ/YGkgb7xyGxMRzfQxa5OLg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694767742; a=rsa-sha256; cv=none; b=mDVovEhRLA9y4pmZK6j4Ssi0Z9poPyfVfRKTPQ5CWr1k7Y16buDPYjD01k2X77K2dArcdN eBMhBRVJzcBkHbrYoJNvFEj1IT9WA+PpzVH/HWpn2iQRzocVTrf7asZ8i7RTS3kY5y9wgq jnJZWt4ah+LqKVmS9p0J/Jyf+SzcghCnIZnrrvoF/CJtMdPyIf8i5w0CGCFhTJC9TuqBdA /GVno8MdewfVT+hGwiyvnAz3E/k6eL9MRmYtTduuKZH2mYscx5HrLq6hkeWCGTeoSwYdot meaDkF/QcTkPAxBGpZkNOB3E0u96x/VaTOKp2w+iU81PK0L4NyKk0IxyJTxayw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694767742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WkC+uuS//wiaY9vnmkBGD6aj8bovAVPSZZdwCz7F7hU=; b=Qu6vauFw5iolZjFneDKdpaoLbPBU7BLtyuk0aElSZTTWJ0ND05gGO9hTw5dl2Sq+Qh+hi/ mBx7yjHRzvLimJ0ry5Z0nJhJPsM6zvpvRIdL+3Ua0Ufj4G95Tg5Xu9GVqJHem0tNc6Xf2Z LCb25qyB/mbprNkQmRI0D8iWfbxeq/Fmi+zwm/URAuARfT3crE2B9JICFHZG4kTns+/Y1F UuvHqqgIcEyxd4UvCMk7v4irUYjDuJFsezBhGOB29gLHyigXf4vL7BPd+rVXCww+lnE/I1 zcLuX17W0vhO+qU0IavbYkxpTGq6uffDoo/Bonw6q4Vy5K/ojBr4WTjz6ABb4g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rn7CL45pPz28K; Fri, 15 Sep 2023 08:49:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38F8n2I5057902; Fri, 15 Sep 2023 08:49:02 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38F8n29m057899; Fri, 15 Sep 2023 08:49:02 GMT (envelope-from git) Date: Fri, 15 Sep 2023 08:49:02 GMT Message-Id: <202309150849.38F8n29m057899@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: f799833f4fce - releng/14.0 - gve: Make LRO work for jumbo packets List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: f799833f4fce5f7f1f472bdcce86c792f6d3c9f3 Auto-Submitted: auto-generated The branch releng/14.0 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=f799833f4fce5f7f1f472bdcce86c792f6d3c9f3 commit f799833f4fce5f7f1f472bdcce86c792f6d3c9f3 Author: Shailend Chand AuthorDate: 2023-09-07 13:28:26 +0000 Commit: Mark Johnston CommitDate: 2023-09-15 08:48:33 +0000 gve: Make LRO work for jumbo packets Each Rx descriptor points to a packet buffer of size 2K, which means that MTUs greater than 2K see multi-descriptor packets. The TCP-hood of such packets was being incorrectly determined by looking for a flag on the last descriptor instead of the first descriptor. Also fixed and progressed the version number. Approved by: re (gjb) Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D41754 (cherry picked from commit 5f62584a9adb7887bae33af617cfa4f43017abf8) (cherry picked from commit 04ada3cc2b530a5c170ebefa8c28c5625009d37a) --- sys/dev/gve/gve.h | 1 + sys/dev/gve/gve_main.c | 8 ++++---- sys/dev/gve/gve_rx.c | 3 ++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/sys/dev/gve/gve.h b/sys/dev/gve/gve.h index 61781cddee94..c446199dff2d 100644 --- a/sys/dev/gve/gve.h +++ b/sys/dev/gve/gve.h @@ -164,6 +164,7 @@ struct gve_rx_ctx { struct mbuf *mbuf_tail; uint32_t total_size; uint8_t frag_cnt; + bool is_tcp; bool drop_pkt; }; diff --git a/sys/dev/gve/gve_main.c b/sys/dev/gve/gve_main.c index c3ee6d5c3433..cd7849778bce 100644 --- a/sys/dev/gve/gve_main.c +++ b/sys/dev/gve/gve_main.c @@ -31,10 +31,10 @@ #include "gve.h" #include "gve_adminq.h" -#define GVE_DRIVER_VERSION "GVE-FBSD-1.0.0\n" -#define GVE_VERSION_MAJOR 0 -#define GVE_VERSION_MINOR 9 -#define GVE_VERSION_SUB 0 +#define GVE_DRIVER_VERSION "GVE-FBSD-1.0.1\n" +#define GVE_VERSION_MAJOR 1 +#define GVE_VERSION_MINOR 0 +#define GVE_VERSION_SUB 1 #define GVE_DEFAULT_RX_COPYBREAK 256 diff --git a/sys/dev/gve/gve_rx.c b/sys/dev/gve/gve_rx.c index f5d8fd7a7b75..9be96cf1ee3a 100644 --- a/sys/dev/gve/gve_rx.c +++ b/sys/dev/gve/gve_rx.c @@ -546,6 +546,7 @@ gve_rx(struct gve_priv *priv, struct gve_rx_ring *rx, struct gve_rx_desc *desc, if (is_first_frag) { mbuf->m_pkthdr.rcvif = priv->ifp; + ctx->is_tcp = desc->flags_seq & GVE_RXF_TCP; if (gve_needs_rss(desc->flags_seq)) { gve_set_rss_type(desc->flags_seq, mbuf); @@ -567,7 +568,7 @@ gve_rx(struct gve_priv *priv, struct gve_rx_ring *rx, struct gve_rx_desc *desc, do_if_input = true; if (((if_getcapenable(priv->ifp) & IFCAP_LRO) != 0) && /* LRO is enabled */ - (desc->flags_seq & GVE_RXF_TCP) && /* pkt is a TCP pkt */ + (ctx->is_tcp) && /* pkt is a TCP pkt */ ((mbuf->m_pkthdr.csum_flags & CSUM_DATA_VALID) != 0) && /* NIC verified csum */ (rx->lro.lro_cnt != 0) && /* LRO resources exist */ (tcp_lro_rx(&rx->lro, mbuf, 0) == 0))