From nobody Wed Sep 13 18:22:25 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rm81s3Zgrz4shxP; Wed, 13 Sep 2023 18:22:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rm81s39Byz4XHC; Wed, 13 Sep 2023 18:22:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694629345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hPewDvtN3BBHYhp6zTOy+e1fgNdUxQXjuYTEbmbnfdk=; b=Onvby8u95B9qMjm0MGX4wERXAwZLN0rzSkjNcaZvKEh/I56abjGCHaU8BuIh7GViqhDy0D rXYjjPG4EuWUNGoTfdDu2X8a07ySLDaCtOyYgtvlRHDz5URDwlSSyWIdirDLvACX/ACquB iTi4lJ53NyHARhCrwkqdG7qyMxdYzvkbTEwPxacPKgwTVFk/FeoFL/z0dkJTIrlrVkBS01 lhC5poY4BbEm7my//Qfj+d4jdUPyQT0AIkAKSLgr37Vc7JxEC1FW6sSfMjMSC0tgQ6gfYJ Hp/2+aFKCwgLS/2IO3sO43KNBmY4uLPe9KTCOaVJ/skcIfnZr6bQPftwqnm4Ow== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694629345; a=rsa-sha256; cv=none; b=o1h8SnmMiBy+INMH95UA8xeljUlAnRRm+216FbHnKNGSOpvXF5olvmv/T6Ri8Qi9dIf5OW 6cmvVVEQVaEE2184vdEr5tyDP3ACskFTwgtpttwj6D/Fae2UpZsUHW/7koTXD7KAR/hEIV Ax1+vTcuEQnLEGlRgX+2ZTBAwtANegotbscCAk2ne4vg0dKxad9pBZ8dUfkAZnkdo2SCJt dUJOn6DACa2EvUjsLB3PDJtWeVeikFrl6rMmjocx6r7ubuOsU9cRMHjvjQ8Z4THm2PWbwu SJvI1pnWd4d5LbaXFZGErJIeRzEU1kypAHtf+WSGhRBO5Y9+o/zgTsqit5FZaQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694629345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hPewDvtN3BBHYhp6zTOy+e1fgNdUxQXjuYTEbmbnfdk=; b=VFDfEM8YNV4wNQ+bZ4ax/XGEC5GBW0plAhweWlpZ8xO4uTj4myfp4FJXdPDS8hDpQnFSqX +6M19Vmp2/tPFS5byMsZ8SCkhy5ohPnOMscHOKvEL/64HP0k3IO7Rb+OAo1IUVS2uDq6n+ T565qvpTqunEjIgDnHsSn8896BM1r4xAkQAthqlsVeHThRNW4kerhau/5Re8vOa5F5OutB in/IK4PWu3lK7ro3oSTGGzpb8+A5IRsaYer0bHvg+k/ZWnfu9375cNeZ+xDzpD+Zv9g59A plEVITZ9yVD5Qiq37SqqmH4NdOHMlYwedXrXo398xHhxVlmZD0cSd4jnR28D1A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Rm81s2FzCz91t; Wed, 13 Sep 2023 18:22:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38DIMPrq030526; Wed, 13 Sep 2023 18:22:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38DIMPQL030523; Wed, 13 Sep 2023 18:22:25 GMT (envelope-from git) Date: Wed, 13 Sep 2023 18:22:25 GMT Message-Id: <202309131822.38DIMPQL030523@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Doug Moore Subject: git: 8763b9862f90 - main - powerpc pmap: initialize kernel pmap radix trie List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8763b9862f90dc3bdbbc5e3c2664890be7c1f0c4 Auto-Submitted: auto-generated The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=8763b9862f90dc3bdbbc5e3c2664890be7c1f0c4 commit 8763b9862f90dc3bdbbc5e3c2664890be7c1f0c4 Author: Doug Moore AuthorDate: 2023-09-13 18:17:57 +0000 Commit: Doug Moore CommitDate: 2023-09-13 18:17:57 +0000 powerpc pmap: initialize kernel pmap radix trie Commit 2d2bcba7ba70141388729ed49674b36fd01146c5 changed radix trie implementation and made it necessary that radix tries be initialized with vm_radix_init. @dbaio reports that in some configurations, there is a powerpc boot panic and that this commit introduced the problem. In powerpc/aim/mmu_radix.c, the radix trie in kernel_pmap is initialized by zeroing all its fields. Add a call to vm_radix_init to properly initialize kernel_pmap->pm_radix. Reported by: dbaio Reviewed by: alc, jhibbits Fixes: 2d2bcba7ba drop NULL check from radix trie search MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D41846 --- sys/powerpc/aim/mmu_radix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/powerpc/aim/mmu_radix.c b/sys/powerpc/aim/mmu_radix.c index 9c5b67121803..e26508a3bddf 100644 --- a/sys/powerpc/aim/mmu_radix.c +++ b/sys/powerpc/aim/mmu_radix.c @@ -1844,6 +1844,7 @@ mmu_radix_setup_pagetables(vm_size_t hwphyssz) bzero(kernel_pmap, sizeof(struct pmap)); PMAP_LOCK_INIT(kernel_pmap); + vm_radix_init(&kernel_pmap->pm_radix); ptpages = allocpages(3); l1phys = moea64_bootstrap_alloc(RADIX_PGD_SIZE, RADIX_PGD_SIZE);