From nobody Thu Sep 07 18:19:23 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhSF835MWz4sn8g; Thu, 7 Sep 2023 18:19:24 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhSF82gxmz3Fs7; Thu, 7 Sep 2023 18:19:24 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Authentication-Results: mx1.freebsd.org; none Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id EFC0A3C019A; Thu, 7 Sep 2023 18:19:23 +0000 (UTC) Date: Thu, 7 Sep 2023 18:19:23 +0000 From: Brooks Davis To: Colin Percival Cc: Zhenlei Huang , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 1926d5cef6ea - main - init_main: Record completed SYSINITs Message-ID: References: <202309061837.386Ib5AK086264@gitrepo.freebsd.org> <5BC96D9F-E4C4-4D34-B7B3-41576AD296DA@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US] X-Rspamd-Queue-Id: 4RhSF82gxmz3Fs7 On Wed, Sep 06, 2023 at 06:46:59PM -0700, Colin Percival wrote: > On 9/6/23 18:12, Zhenlei Huang wrote: > > > On Sep 7, 2023, at 2:37 AM, Colin Percival wrote: > > > init_main: Record completed SYSINITs > > > > > > When removing them from sysinit_list, append them to sysinit_done_list; > > > print this list from 'show sysinit' along with the list of future > > > sysinits. > > > > So the `sysinit_done_list` is for DDB only. > > Well... sort of. You can open up kgdb and run 'p sysinit_done_list'. > > > > static STAILQ_HEAD(sysinitlist, sysinit) sysinit_list; > > > +static struct sysinitlist sysinit_done_list = > > > + STAILQ_HEAD_INITIALIZER(sysinit_done_list); > > > > Then it should be wrapped around with #ifdef DDB and #endif > I considered that, but since we're literally talking about 2 pointers of > memory I figured it wasn't worth making it conditional. IMO loss of the run order in a dump was a (minor) regression so this should be unconditionally available. -- Brooks