From nobody Thu Sep 07 13:38:25 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhL0x4sCRz4s3f7; Thu, 7 Sep 2023 13:38:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhL0x4FHyz4LQ8; Thu, 7 Sep 2023 13:38:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694093905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s0TfuFoD3deyCcDM2N3nBBdyULmjZsO6rEighEYxGAc=; b=eoJcf8g35xToLtA2MAkNFmlVZGqFehhxU2SpwuP/42WUZRe21tmFepFFkrRMdavIYDj0LO JXjKj0Ypr45We4ulUlUzCf7DbrlZdjXZWCLLzDWA91nrGWoPW7pMssxPsEWXCxYOPW5aaA QPLyW8m3BhjaFwYkrpFIuNuuJLZR3lrK3dgq/cTNjZoW7A7BbrfC0KxBc79gpwMzqTD3ib O3rkIr5kD3+jtr3tK8GPWvQmj/MCclSgPaEYTfVcCd0usnAEl27aTNwJwLgjGCY/jRwe4U /wUkrK3CzLP3QDnlqSNRwQdusv0lToqUeKL5+lcpvRI+++//o5DC696+I2johQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694093905; a=rsa-sha256; cv=none; b=aRDC47el7eCx+LZBU19kYCPqdaWF2H69E8V2GLP6MxMAfs0EqN05fDxptmRHzdZOVBh2+/ tnTlOxMH5trS0LHB/b3kZtWanhZjTF0FmdEeF0ru3ZDDF2k5Zvh8k8QkMQ5pov7yIEdytW BQ2jRN9GTkp91MofQb6IiHi71dbHVnHfg1BuyLJ2c3RzzIOHFU17VVELj0ouvya+kFP+Sn p8lBgQDQD65bCOyq7qxrMx69lQX4ccFJWH71bPiSUck1zeUoXtKxRYLye5yqhRf5JA+Dba Xc8VeXh4PJ2LdgmtR/aJPO/APr3sM3/sdguvbFCbpLj2O4sGDXjfpyVRikfeNg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694093905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=s0TfuFoD3deyCcDM2N3nBBdyULmjZsO6rEighEYxGAc=; b=sGxsDdKZCidLhbgTCb3M08wZmweofJdpFxQKOOAZOsAR8qisk2zlHi8srHZpIK2atgAZBC kXyWUY5aNylXaZV/lwGITA4tC+z+sgNLcc3SumW1IVHTyHNSUePwUYcYtkLHuO+rkNoNEn q5XrQgM4KL/1nJK3PVWFSJUB7efce1zDApFrAHA9oPdKV7hHaX0CL0ujQPSoKEiucHqxMb sH9SinQnc+miuNK6wC36h4satMs5L1t6Gd6kY1w9hw2c46v6OL6UXBJuHHwERFj1OvjSuM HUKZtRBxYzpdSRdh4CuxZw7mmAnDbyjhompGS3tmHF3y8vgi+xRSdt0/TdqFOw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RhL0x3Fhxz11f1; Thu, 7 Sep 2023 13:38:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 387DcPQY082654; Thu, 7 Sep 2023 13:38:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 387DcPYE082651; Thu, 7 Sep 2023 13:38:25 GMT (envelope-from git) Date: Thu, 7 Sep 2023 13:38:25 GMT Message-Id: <202309071338.387DcPYE082651@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 5f62584a9adb - main - gve: Make LRO work for jumbo packets List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5f62584a9adb7887bae33af617cfa4f43017abf8 Auto-Submitted: auto-generated The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=5f62584a9adb7887bae33af617cfa4f43017abf8 commit 5f62584a9adb7887bae33af617cfa4f43017abf8 Author: Shailend Chand AuthorDate: 2023-09-07 13:28:26 +0000 Commit: Mark Johnston CommitDate: 2023-09-07 13:28:26 +0000 gve: Make LRO work for jumbo packets Each Rx descriptor points to a packet buffer of size 2K, which means that MTUs greater than 2K see multi-descriptor packets. The TCP-hood of such packets was being incorrectly determined by looking for a flag on the last descriptor instead of the first descriptor. Also fixed and progressed the version number. Reviewed by: markj MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D41754 --- sys/dev/gve/gve.h | 1 + sys/dev/gve/gve_main.c | 8 ++++---- sys/dev/gve/gve_rx.c | 3 ++- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/sys/dev/gve/gve.h b/sys/dev/gve/gve.h index 61781cddee94..c446199dff2d 100644 --- a/sys/dev/gve/gve.h +++ b/sys/dev/gve/gve.h @@ -164,6 +164,7 @@ struct gve_rx_ctx { struct mbuf *mbuf_tail; uint32_t total_size; uint8_t frag_cnt; + bool is_tcp; bool drop_pkt; }; diff --git a/sys/dev/gve/gve_main.c b/sys/dev/gve/gve_main.c index c3ee6d5c3433..cd7849778bce 100644 --- a/sys/dev/gve/gve_main.c +++ b/sys/dev/gve/gve_main.c @@ -31,10 +31,10 @@ #include "gve.h" #include "gve_adminq.h" -#define GVE_DRIVER_VERSION "GVE-FBSD-1.0.0\n" -#define GVE_VERSION_MAJOR 0 -#define GVE_VERSION_MINOR 9 -#define GVE_VERSION_SUB 0 +#define GVE_DRIVER_VERSION "GVE-FBSD-1.0.1\n" +#define GVE_VERSION_MAJOR 1 +#define GVE_VERSION_MINOR 0 +#define GVE_VERSION_SUB 1 #define GVE_DEFAULT_RX_COPYBREAK 256 diff --git a/sys/dev/gve/gve_rx.c b/sys/dev/gve/gve_rx.c index f5d8fd7a7b75..9be96cf1ee3a 100644 --- a/sys/dev/gve/gve_rx.c +++ b/sys/dev/gve/gve_rx.c @@ -546,6 +546,7 @@ gve_rx(struct gve_priv *priv, struct gve_rx_ring *rx, struct gve_rx_desc *desc, if (is_first_frag) { mbuf->m_pkthdr.rcvif = priv->ifp; + ctx->is_tcp = desc->flags_seq & GVE_RXF_TCP; if (gve_needs_rss(desc->flags_seq)) { gve_set_rss_type(desc->flags_seq, mbuf); @@ -567,7 +568,7 @@ gve_rx(struct gve_priv *priv, struct gve_rx_ring *rx, struct gve_rx_desc *desc, do_if_input = true; if (((if_getcapenable(priv->ifp) & IFCAP_LRO) != 0) && /* LRO is enabled */ - (desc->flags_seq & GVE_RXF_TCP) && /* pkt is a TCP pkt */ + (ctx->is_tcp) && /* pkt is a TCP pkt */ ((mbuf->m_pkthdr.csum_flags & CSUM_DATA_VALID) != 0) && /* NIC verified csum */ (rx->lro.lro_cnt != 0) && /* LRO resources exist */ (tcp_lro_rx(&rx->lro, mbuf, 0) == 0))