Re: git: ea82362219ee - main - tests: Skip all tests that require mdconfig when /dev/mdctl missing

Warner Losh <imp@FreeBSD.org> writes:
> diff --git a/tests/sys/cddl/zfs/tests/cache/cache_test.sh b/tests/sys/cddl/zfs/tests/cache/cache_test.sh
> index 4d77d9fa56a7..79b09dd93183 100755
> --- a/tests/sys/cddl/zfs/tests/cache/cache_test.sh
> +++ b/tests/sys/cddl/zfs/tests/cache/cache_test.sh
> @@ -280,6 +280,7 @@ cache_010_neg_body()
>  	. $(atf_get_srcdir)/cache.kshlib
>  	. $(atf_get_srcdir)/cache.cfg
>  
> +	[ -c /dev/mdctl ] || atf_skip "no /dev/mdctl to create md devices"
>  	verify_disk_count "$DISKS" 1
>  	ksh93 $(atf_get_srcdir)/setup.ksh || atf_fail "Setup failed"
>  	ksh93 $(atf_get_srcdir)/cache_010_neg.ksh || atf_fail "Testcase failed"

the canonical way to do this would be to add

    atf_set "require.files" "/dev/mdctl"

to the testcase head.

DES
-- 
Dag-Erling Smørgrav - des@FreeBSD.org