From nobody Sun Sep 03 20:30:38 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Rf3Lh3w4rz4sNmh for ; Sun, 3 Sep 2023 20:30:52 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Rf3Lh0Fhgz4V3K for ; Sun, 3 Sep 2023 20:30:51 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-401da71b7faso7964925e9.2 for ; Sun, 03 Sep 2023 13:30:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693773050; x=1694377850; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dsb9Wa/yHX4THOPhn5GHL3wsCkeTS1SgubMa6gSBiso=; b=SzXtg0Ot9y3vO9LGZeI3sQM8qQ1KJX2V3JdTFDu5JbBBTG+yFpzEzkIRqGIi4rMXQb TQwRO0pAic70fmq1I/RZkrwfKOm6WymZ20PSf1/67+HSZ3itT9FmFceCurBTHcPcp9XB 9t3t+s3d94O5LPGx05yIMt1XL/LPclMmbmo6L6PiNLg7OEHZ50OUeGraRmE4gCzxxYMh YeaH6CMph7S/QgUgzq8cZotcn0tPonPNJURSQDlu5LEMp0B1aEN5JwUOmuMlEYw8dpAh /IJuelwKGBVINYA0C2bGXz65/Do8NsowjwZxzQ3uDyAwS3AWl2HnlT5Z03sCJ2EWoFYH cLUw== X-Gm-Message-State: AOJu0Yzyr5DDaidYsu8r0ezcYjCJMixRBYzcg9BnVCdBb40Pt9/nSlY9 a+Hzw1cbCcWmYUgdv5vzHkE0yA== X-Google-Smtp-Source: AGHT+IFNSWy2rwZCRUbGigjXqK76+aU7hmS6z9JD9OaCyVNS7BDwhKHrjOvX+TmPjRx/i1sgwFpzkw== X-Received: by 2002:a1c:4b15:0:b0:3fb:e356:b60d with SMTP id y21-20020a1c4b15000000b003fbe356b60dmr5882087wma.38.1693773049765; Sun, 03 Sep 2023 13:30:49 -0700 (PDT) Received: from smtpclient.apple ([131.111.5.246]) by smtp.gmail.com with ESMTPSA id 11-20020a05600c234b00b003fee8793911sm11813723wmq.44.2023.09.03.13.30.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Sep 2023 13:30:49 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: git: 02183951bfb1 - stable/13 - Fix build for FreeBSD 13. From: Jessica Clarke In-Reply-To: Date: Sun, 3 Sep 2023 21:30:38 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-branches@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <1D25197C-63A0-429E-A7C9-5A662E29AD46@freebsd.org> References: <202309031849.383In8u2023677@gitrepo.freebsd.org> <3D2AC67E-C1F8-4DD0-9D7C-65AD4E283C44@freebsd.org> To: Xin Li X-Mailer: Apple Mail (2.3731.600.7) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4Rf3Lh0Fhgz4V3K On 3 Sep 2023, at 21:18, Xin Li wrote: >=20 > On 2023-09-03 12:39 PM, Jessica Clarke wrote: >> On 3 Sep 2023, at 19:49, Xin LI wrote: >>>=20 >>> The branch stable/13 has been updated by delphij: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D02183951bfb19fda7a199acaeb9223cd= 28f29de3 >>>=20 >>> commit 02183951bfb19fda7a199acaeb9223cd28f29de3 >>> Author: Xin LI >>> AuthorDate: 2023-09-03 18:49:02 +0000 >>> Commit: Xin LI >>> CommitDate: 2023-09-03 18:49:02 +0000 >>>=20 >>> Fix build for FreeBSD 13. >>>=20 >>> The minigzip utility has been removed in FreeBSD 14 but still >>> exists in FreeBSD 13. The upstream revision e9d5486e removed >>> prototype definitions, rendering the code no longer compliant >>> with WARNS=3D5. >> Uh, what on earth is upstream doing? Has this been reported / >> complained about? >=20 > I've created a PR for this https://github.com/madler/zlib/pull/855 (by = converting the functions to static ones). Oh, -Wmissing-prototypes, not calling a function without a prototype. That=E2=80=99s not a big deal. Why not let WARNS stay as 5 but build = with -Wno-missing-prototypes? Jess