From nobody Sat Sep 02 20:36:44 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RdRWw4tbYz4s76p; Sat, 2 Sep 2023 20:36:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RdRWw4RKnz4JTt; Sat, 2 Sep 2023 20:36:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693687004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q6XPbq2H+5cu4Y0o2svoK7ObZylh+rZPFJrxOyZoCBo=; b=i2dDYDsHkHQ8IVwEldADewe+XCNBmq5Pg0zxw3TzNwrR1aRC3jxhGQbFvpVVPsqKBI2SIO 75hKm72SHwLCTLhZ5PvEYm0wRVhAe/ZO3HRXgW3Pdegfok4bkhkj/RlwPZfdnn3IigqALR oMo3PFaoPMOdknLCyW6s/eHKXQwnDvAag316+dI7E9hiOpG4S1ZivfuwQN1bItmlcN8MpK D9WDu6/Kj27BesRs65g9wRIK9c+Z47ArcapJoTfke/9KKHV5isewgMuQREsPStkErzkX1E SX/QQK8cu7KzGUTGsfg4hvqbigxd/nd1miI9orhj+JXiO51tYfAldl1en3wSiA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693687004; a=rsa-sha256; cv=none; b=HFP25UZGlfHzlm1/h94RS4zHzthBxGLCp5AcGWrnjTOJ/f/nqDNy8Uw86k5Ha0u4dJ4UeG UV0O7lGch8+nrup1kzlPMFZ57AcA4UDxHKsIYFKhMe5pakS+M5V0yR/IyKrpPIjhrFuWkn k3VUn4YGGF05aPLPNKw6F8bOrSzyEZkzqBTo4yLibFVuD7jnXlYcQY9L7ZlOSZbUK6yVtF KT1erKUthIiSj6OWf7yvno7ecOrcsqErOivanxpL7Bq4lNVgqqT7aq4X8WbhnFRppYq/bZ aap18qPrW5Sg1KeXx+HcV4QH/0db4s9dxr6zTqKE6yCbc5R+y6oYd3I9DTvpYQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693687004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=q6XPbq2H+5cu4Y0o2svoK7ObZylh+rZPFJrxOyZoCBo=; b=xKuUrQVHBwGrphtLVPL3xjeSE1J7DGpxnCjWFKx7mp3rW7kdZe6MFhNm0bB1ibv8xMJ3fi xV6++MRgtosAYSBWwhS1scxHn5x9mwM3bFEnaNHDOCY6L5OCzLYOuPne06AqUrR5PTTxXN ZRexrExGvJ5TmWPyQBtCiXAsx2PON02HEpqoNt1Bdi4iBmyZs9FX9pZtVKWjo3eJkCHBrz AC0k+g98HIUlbJrec549SIeMV48CdvsngzsVwMePx/geS1eb6dp7/tiqZH/0Mmmei8slhH ISMZ0a/gjisDq19Bghwe5yts9NUZlLT+mQ8sJLKz/jtG3hJsOeAAAeivbuuB3w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RdRWw3TVczx6p; Sat, 2 Sep 2023 20:36:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 382Kai0t024327; Sat, 2 Sep 2023 20:36:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 382KaisV024324; Sat, 2 Sep 2023 20:36:44 GMT (envelope-from git) Date: Sat, 2 Sep 2023 20:36:44 GMT Message-Id: <202309022036.382KaisV024324@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: 224aec05e732 - main - tcp: Initialize the maximum number of entries in a client cookie cache bucket List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 224aec05e732bb97a0d3c91142973b98a91238d1 Auto-Submitted: auto-generated The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=224aec05e732bb97a0d3c91142973b98a91238d1 commit 224aec05e732bb97a0d3c91142973b98a91238d1 Author: Zhenlei Huang AuthorDate: 2023-09-02 20:34:07 +0000 Commit: Zhenlei Huang CommitDate: 2023-09-02 20:34:07 +0000 tcp: Initialize the maximum number of entries in a client cookie cache bucket This vnet loader tunable is defined with SYSCTL_PROC, thus will not be initialized by kernel on vnet creating and will always have the default value TCP_FASTOPEN_CCACHE_BUCKET_LIMIT_DEFAULT. Fix by fetching the value from the corresponding kernel environment during vnet constructing. PR: 273509 Reviewed by: #transport, tuexen Fixes: c560df6f12f1 This is an implementation of the client side of TCP Fast Open (TFO) [RFC7413] MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D41691 --- sys/netinet/tcp_fastopen.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/netinet/tcp_fastopen.c b/sys/netinet/tcp_fastopen.c index 9b6f9c17b05c..c31225214d1d 100644 --- a/sys/netinet/tcp_fastopen.c +++ b/sys/netinet/tcp_fastopen.c @@ -271,7 +271,7 @@ SYSCTL_PROC(_net_inet_tcp_fastopen, OID_AUTO, autokey, static int sysctl_net_inet_tcp_fastopen_ccache_bucket_limit(SYSCTL_HANDLER_ARGS); SYSCTL_PROC(_net_inet_tcp_fastopen, OID_AUTO, ccache_bucket_limit, - CTLFLAG_VNET | CTLTYPE_UINT | CTLFLAG_RWTUN | CTLFLAG_NEEDGIANT, + CTLFLAG_VNET | CTLTYPE_UINT | CTLFLAG_RWTUN | CTLFLAG_NOFETCH | CTLFLAG_NEEDGIANT, NULL, 0, &sysctl_net_inet_tcp_fastopen_ccache_bucket_limit, "IU", "Max entries per bucket in client cookie cache"); @@ -393,7 +393,8 @@ tcp_fastopen_init(void) V_tcp_fastopen_keys.newest = TCP_FASTOPEN_MAX_KEYS - 1; V_tcp_fastopen_keys.newest_psk = TCP_FASTOPEN_MAX_PSKS - 1; - /* May already be non-zero if kernel tunable was set */ + TUNABLE_INT_FETCH("net.inet.tcp.fastopen.ccache_bucket_limit", + &V_tcp_fastopen_ccache.bucket_limit); if (V_tcp_fastopen_ccache.bucket_limit == 0) V_tcp_fastopen_ccache.bucket_limit = TCP_FASTOPEN_CCACHE_BUCKET_LIMIT_DEFAULT;