From nobody Sat Oct 28 21:02:18 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SHsRb068jz4y2cb; Sat, 28 Oct 2023 21:02:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SHsRZ6TDGz4RCn; Sat, 28 Oct 2023 21:02:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698526938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HffRY6NrXcNu189za1MOxF58odKzrRsBqDTLnGghLXk=; b=MfWVCyaNudUSDFTholtkTKBkWlmIlSkx3F37E10Z5qY9MNYfb+972QmTQhsdjNAHmqrGDj sGnSA0+BxbO6IIA65aeX/FbUJoNbP5JkWXaz+F8tnkpt+GJaJy878Dx3XShLeseQL7ZCpi blDxnzMBedMgCFexfNKQV/43593gYTKhZMlU8zf+7Socb7UqGNo4Cfkn1JAxEbnXmdxtmy +gpual61iKyv+x2MQWlmb8OIajV8V5zT8gDMXTYgLlAH8cmtU/aaI2k9OllUsHRpn0A4Yf REDGbksn1MS8Cj7fSttcGDnwofzVQH65xqKyVS3Dh/fjCyPQiVLD2t61r7YKSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698526938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HffRY6NrXcNu189za1MOxF58odKzrRsBqDTLnGghLXk=; b=ntpl30Cj88CKYxXLfGOG3yeRCo0hC1XPffDhyQo57aIQ0lgpdi08hGiYRCmroQfyy2yzmT G0G9UcrYB4TW7FDURhdvAed+SVmVvCnhkjCgiEAbZvjnbs4uA/Mr4iYrvRABK9cYGFrfNR LnC/+uN4iZ5IxTs/HC5tohXUQ1MWtzBB4h/MfpShd0smpcZfZeSXEWeemZV2s0ZP9xJWKI X3YgpYcJbUDcxripsxWCHjOVOgKhefjVcbXEpfs0KBpS5UVJICgLdBa9PUnJPY26zzqwpf v6ivataZuB7dDIo0B1hQhrpFnSFhG06calIrKPiGcsF622Qvq1odWg7nIZX3rw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1698526938; a=rsa-sha256; cv=none; b=fT0G4zDNjeFVDPTBC2NRHUCgg+sHlrUD5qnInD9QvIjqSUDszwiZrwrf8EU2pgEBRtYPJU XQvqeOaTCDWA0wSLF2d93GKWSoiPw1wfYWh2feo40ncrAxcsYu/1zhNOfXAQETXG7MH2IT RarzRZA26+EY00J5vX0Ko4zehPpUE3dsRyqPbS6PznsNxlf7qH5iLPOkbT5LEkgWBS36Tu GCNh70acP+rV3Q4RuWQi/tNWRjV2WuHlsi81TdB1g9ZgdoysH9V64+xEHdLs/GwfovTgLp Ekju2t6994Z+NQCDuAw2BIIDgHq5D36s+l3GlTrxay4Dh0IIjYDb06+hBUopeg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SHsRZ5SNTz1B9R; Sat, 28 Oct 2023 21:02:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39SL2IRo040771; Sat, 28 Oct 2023 21:02:18 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39SL2Ixv040768; Sat, 28 Oct 2023 21:02:18 GMT (envelope-from git) Date: Sat, 28 Oct 2023 21:02:18 GMT Message-Id: <202310282102.39SL2Ixv040768@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ka Ho Ng Subject: git: 813d981e1e78 - main - mlx5ib: Fix RSS Toeplitz setup to be aligned with the HW specification List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: khng X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 813d981e1e78daffde4b2a05df35d054fcb4343f Auto-Submitted: auto-generated The branch main has been updated by khng: URL: https://cgit.FreeBSD.org/src/commit/?id=813d981e1e78daffde4b2a05df35d054fcb4343f commit 813d981e1e78daffde4b2a05df35d054fcb4343f Author: Yishai Hadas AuthorDate: 2023-10-28 20:55:47 +0000 Commit: Ka Ho Ng CommitDate: 2023-10-28 20:59:09 +0000 mlx5ib: Fix RSS Toeplitz setup to be aligned with the HW specification The specification for the Toeplitz function doesn't require to set the key explicitly to be symmetric. In case a symmetric functionality is required a symmetric key can be simply used. Wrongly forcing the algorithm to symmetric causes the wrong packet distribution and a performance degradation. Link: https://lore.kernel.org/r/20190723065733.4899-7-leon@kernel.org Fixes: 28d6137008b2 ("IB/mlx5: Add RSS QP support") Signed-off-by: Yishai Hadas Reviewed-by: Alex Vainman Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe [khng: cherry-picked from Linux b7165bd0d6cbb93732559be6ea8774653b204480] Sponsored by: Juniper Networks, Inc. MFC after: 7 days Reviewed by: kib, zlei Differential Revision: https://reviews.freebsd.org/D42178 --- sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c b/sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c index 08e73a6dedd8..a504f1ff1788 100644 --- a/sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c +++ b/sys/dev/mlx5/mlx5_ib/mlx5_ib_qp.c @@ -1449,7 +1449,6 @@ static int create_rss_raw_qp_tir(struct mlx5_ib_dev *dev, struct mlx5_ib_qp *qp, } MLX5_SET(tirc, tirc, rx_hash_fn, MLX5_RX_HASH_FUNC_TOEPLITZ); - MLX5_SET(tirc, tirc, rx_hash_symmetric, 1); memcpy(rss_key, ucmd.rx_hash_key, len); break; }