From nobody Sun Oct 22 22:13:15 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SDCJN4bnjz4xtgV; Sun, 22 Oct 2023 22:13:24 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from glebi.us (glebi.us [162.251.186.162]) by mx1.freebsd.org (Postfix) with ESMTP id 4SDCJM5Q91z3RgM; Sun, 22 Oct 2023 22:13:23 +0000 (UTC) (envelope-from glebius@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 162.251.186.162 is neither permitted nor denied by domain of glebius@freebsd.org) smtp.mailfrom=glebius@freebsd.org; dmarc=none Received: by glebi.us (Postfix, from userid 1000) id D9C786EBB8; Sun, 22 Oct 2023 15:13:15 -0700 (PDT) Date: Sun, 22 Oct 2023 15:13:15 -0700 From: Gleb Smirnoff To: Dimitry Andric , markj@freebsd.org Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 6120673f7566 - main - tests: fix ATF_TESTS_PYTEST no clean build Message-ID: References: <202310201747.39KHlUgB005433@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: / X-Spamd-Result: default: False [0.63 / 15.00]; VIOLATED_DIRECT_SPF(3.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.974]; ONCE_RECEIVED(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_FIVE(0.00)[5]; R_SPF_SOFTFAIL(0.00)[~all:c]; FREEFALL_USER(0.00)[glebius]; TO_DN_EQ_ADDR_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[freebsd.org]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 4SDCJM5Q91z3RgM On Sat, Oct 21, 2023 at 09:07:26PM +0200, Dimitry Andric wrote: D> > commit 6120673f7566c35023921540d2d682572d1bf1ce D> > Author: Gleb Smirnoff D> > AuthorDate: 2023-10-20 17:47:08 +0000 D> > Commit: Gleb Smirnoff D> > CommitDate: 2023-10-20 17:47:08 +0000 D> > D> > tests: fix ATF_TESTS_PYTEST no clean build D> > D> > The hack with .xtmp file was effectively making the make to D> > ignore changes to the sources, breaking NO_CLEAN builds. The D> > hack can be actually omitted as setting SCRIPTSNAME_${_T} for D> > every test is sufficient to prevent renaming by bsd.prog.mk. D> > D> > Reviewed by: melifaro D> > Differential Revision: https://reviews.freebsd.org/D42283 D> D> This appears to break clean builds, in that it now deletes files D> mentioned in ATF_TESTS_PYTEST in the _source_ directories, leaving your D> git checkout looking as follows: Oh shit... Sorry. :( When I come up with a better change, who would be a good reviewer for the change? Mark, thanks for reverting promptly. -- Gleb Smirnoff