From nobody Sat Oct 21 19:07:26 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SCWDc0Xvdz4xQN4; Sat, 21 Oct 2023 19:07:44 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SCWDc02h4z3FxX; Sat, 21 Oct 2023 19:07:44 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697915264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+bNQWu2Dx/1h/gmdxiIFbRol9Sp5JWQGGSTTfrxJGx0=; b=xnM94k9evC1afxeqtiY5z7J26/TjeVlriC4akFPH5AS0vkvKk2sFo06Tlp9gkOGkUocbjF pKDKGrBJrFrzeSl6ocVCYpTIk4oFRhVMVLflKbg0ecjmPnkdWK6IXWJcM7IUDdrFkvzWY4 nsXfhdAxFD/EkUt4KMfZtWnmSLKEqnhPHIM4+7ygjMa2ezFq+a33+zNONZsYU+4jMmEgxz fOh2ix5THd+oXmg55ySdOaSV2vCx/ZHsfpCSyy3ko/HcCoNbUACVTFt2aHC9TUg79HVaAZ 7pPFkt7G2/lfI26Y+297zmCnKlKQ1XOylij3niE6OvEKBNL7xZDZhz7EJ2F53Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697915264; a=rsa-sha256; cv=none; b=dpiBLs/hqC21SHPESXirP8hKlk6kSvFJ0i6+EPHje43uC89KWpQoj/7U4xPEyO6JL0gGHD VPoDQfa4TjG4SxTpblF2N8+UJnL+dKD8+E0azdTvNHtfIfC/Z4tlyHd8anGHlOkM+ocX8Z 5/SBf2mfEQ2SUn3XG7aL3ZTUz+L8HyNNZf3zqLoXWBQnAn7W/f0ogOXrgdSqFy28Dyk7GR Tx0ODrNhs4zqKSOiv2ihr1UO2VDI85FnOzDeAHNUKEVaTf/WVT7FRexh8zZAhb8/bF8O56 iDkYsQfUVg8bYa0gXZhvhS1OsqspZY+2TzwXxYcZSOzPSdhM76x6ZHbYJ5kMlA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697915264; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+bNQWu2Dx/1h/gmdxiIFbRol9Sp5JWQGGSTTfrxJGx0=; b=YJDqRuw555caOM30ozhVPgyc2NRhEyMQQjftkMRELsb5lxunOuSK+sdsBUGaLznOBVe2IW Bd2ZCHmxz9rm5q1hauF9/BXkNGrQ+4NB2laDXCTRQZCb1c1XIhEfSykQJV8AMiALS9EAz7 Mnnbp+S9NMOfnI+bdmVKIXRSgS/3qjnWntkXBJv4y1cfwRuczwcbTAliZuwUWqDZB8MXOY y4r2CdK+L7tQHpWAJ2XJkQ/gc06ssAFFKNK7AAxabwMfw/ktO/zrFFPAeQaRtLJie/PFZ2 7sO2CS/+0H+4/dfOgy2O8i3v8P6yY6FtndSKYHGa88K49ApN/75hTnq8Ea2Xow== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SCWDb5TCYz16JC; Sat, 21 Oct 2023 19:07:43 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 858344B47A; Sat, 21 Oct 2023 21:07:42 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_E28B79DB-8046-400C-B45A-296D44A09268"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: git: 6120673f7566 - main - tests: fix ATF_TESTS_PYTEST no clean build From: Dimitry Andric In-Reply-To: <202310201747.39KHlUgB005433@gitrepo.freebsd.org> Date: Sat, 21 Oct 2023 21:07:26 +0200 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: References: <202310201747.39KHlUgB005433@gitrepo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3731.700.6) --Apple-Mail=_E28B79DB-8046-400C-B45A-296D44A09268 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 20 Oct 2023, at 19:47, Gleb Smirnoff wrote: >=20 > The branch main has been updated by glebius: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6120673f7566c35023921540d2d68257= 2d1bf1ce >=20 > commit 6120673f7566c35023921540d2d682572d1bf1ce > Author: Gleb Smirnoff > AuthorDate: 2023-10-20 17:47:08 +0000 > Commit: Gleb Smirnoff > CommitDate: 2023-10-20 17:47:08 +0000 >=20 > tests: fix ATF_TESTS_PYTEST no clean build >=20 > The hack with .xtmp file was effectively making the make to > ignore changes to the sources, breaking NO_CLEAN builds. The > hack can be actually omitted as setting SCRIPTSNAME_${_T} for > every test is sufficient to prevent renaming by bsd.prog.mk. >=20 > Reviewed by: melifaro > Differential Revision: https://reviews.freebsd.org/D42283 This appears to break clean builds, in that it now deletes files mentioned in ATF_TESTS_PYTEST in the _source_ directories, leaving your git checkout looking as follows: Changes not staged for commit: (use "git add/rm ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) deleted: sbin/ping/tests/test_ping.py deleted: tests/examples/test_examples.py deleted: tests/examples/test_ktest_example.py deleted: tests/sys/net/routing/test_routing_l3.py deleted: tests/sys/net/routing/test_rtsock_multipath.py deleted: tests/sys/netinet/carp.py deleted: tests/sys/netinet6/test_ip6_output.py deleted: tests/sys/netlink/test_netlink_message_writer.py deleted: tests/sys/netlink/test_nl_core.py deleted: tests/sys/netlink/test_rtnl_iface.py deleted: tests/sys/netlink/test_rtnl_ifaddr.py deleted: tests/sys/netlink/test_rtnl_neigh.py deleted: tests/sys/netlink/test_rtnl_route.py deleted: tests/sys/netpfil/pf/frag6.py deleted: tests/sys/netpfil/pf/sctp.py Then of course when buildworld arrives at the point where the tests are built, it errors out with "don't know how to make sbin/ping/tests/test_ping.py", and similar. Do you mind if I revert this for now? -Dimitry --Apple-Mail=_E28B79DB-8046-400C-B45A-296D44A09268 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCZTQhbgAKCRCwXqMKLiCW o9N8AKDKzBJQ+HXri5P5hyaghceDBEZHQwCg0gWmyB/rdY0ZoWPZe5X+piHLXY8= =G191 -----END PGP SIGNATURE----- --Apple-Mail=_E28B79DB-8046-400C-B45A-296D44A09268--