From nobody Thu Oct 19 15:09:12 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBB2M20gfz4xY8Y; Thu, 19 Oct 2023 15:09:15 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBB2M1Pqnz4cQr; Thu, 19 Oct 2023 15:09:15 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697728155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ymcvD0Llk9TgxiEpUSoJY2mC52cjwvXlV/Ss4RsmJH8=; b=kEsJAqikz8FcUENS1S9lWIviE3Q3z7UzdSGALSST05kz9NML85ywkty/TbgdV8L4VhrKhl rJhBEls+k/BltbMIowrOiQl0Rpv5/hAMhQCLF2SfVbIRNecOZh96TQg5tnWX61PZbQVENr pvTvFmi0bYYO/FnDuD/RXL2MJonq6P+Hdk/4UPuGATdFwCxf7/6ARp5KcnfsLW2Kholibf EQQ5KAOP9WT74ue7s3W9Z0VSvt+Fa1UiySKqIstNKhYCZO7qrAhaNCw47k4aljkE2U2j7a TWN2fLBRVICD51w5aEbFZF4IqT4JeSwoFF2uwDtcy6E36F88zfACL2E9Lc3tpw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697728155; a=rsa-sha256; cv=none; b=mJdNKAHeRDYx4ClrT0zYqYOVvCjYKnKIcttGdb7zs1M9IFjOL/jnPli9WIa7kTshLiolpq UWnMUOijkXTLnlRWDijweqjfjNilnQnQd3kUWcE0BlrdIKqb27KkjI/2viSIdtfcU19h5Y zMHQkBzEgXAHV/CFOefJoWZdXpvhn3zq8H5iWyvCzc/8Bitr2QBuwQr5xxLEXBfoBnjcvb M6i/KKDz9C3cbCo08r7iw4kwodmSsWF8KG7I7V8Gs9XzTUCni/dICjN2qIaVYPOFoa/peC tJT03dbQC+U5CfuJLx4tMuffCbjDLFpXwM8KkrgdIF0ysUY3nsWYbTJ7NGiMNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697728155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ymcvD0Llk9TgxiEpUSoJY2mC52cjwvXlV/Ss4RsmJH8=; b=ZzSuRAm3VyHzj1x7H6SWVIbdz/QiRblwYkeVkwOZuYZ76XXHcngt4v8X9WthSbCxRSgzSr g0tU73v9HIHtRAHZXJWHGUeC/d0hnJ2huMyM/Cp/0iCpRE4sur50Q2cX+X9wm/YRTTunPx JcpbrYG6z1aXqmjl7wsD6LjLd/BAMcgu1+mnnd57Dit+zeT/WsvKCbh2iOvgUFu+dVdn+V maXGBCh6EK6/meo2w4wsibpObMKRaA55KN17fF/clldmTF7bpvLWusURjKGTXdU9baAjo5 5v+2hZAcYUv9/jutypdWA5EuPscRqsbAD0PIXG00Cyw3y/+psExTWEWFKcnZ2w== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SBB2L6ts7z169B; Thu, 19 Oct 2023 15:09:14 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 76216843E; Thu, 19 Oct 2023 17:09:13 +0200 (CEST) From: Kristof Provost To: Jessica Clarke Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 9eff6390718d - main - pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h Date: Thu, 19 Oct 2023 17:09:12 +0200 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: <1EB17D31-16CB-44D2-A19E-6CC9699156D1@freebsd.org> References: <202310191420.39JEKitw071108@gitrepo.freebsd.org> <1DDF7B7C-9137-48F4-80C9-FDCC82F47118@freebsd.org> <1EB17D31-16CB-44D2-A19E-6CC9699156D1@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 19 Oct 2023, at 17:02, Jessica Clarke wrote: > On 19 Oct 2023, at 15:56, Kristof Provost wrote: >> >> On 19 Oct 2023, at 16:41, Jessica Clarke wrote: >>> On 19 Oct 2023, at 15:20, Kristof Provost wrote: >>>> >>>> The branch main has been updated by kp: >>>> >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=3D9eff6390718d0fa67dffc= 6cd830b0bc6b815e8c4 >>>> >>>> commit 9eff6390718d0fa67dffc6cd830b0bc6b815e8c4 >>>> Author: Kristof Provost >>>> AuthorDate: 2023-10-19 10:06:29 +0000 >>>> Commit: Kristof Provost >>>> CommitDate: 2023-10-19 14:19:39 +0000 >>>> >>>> pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h >>>> >>>> When userspace includes pfvar.h it doesn't get the kernel's COMPAT= _* >>>> defines, so we end up not having required symbols in userspace. Th= is >>>> caused the libpfctl port to fail to build. >>>> >>>> libpfctl will be updated to use the new netlink-based state export= code >>>> soon, which will also fix thix build issue. >>>> >>>> Sponsored by: Rubicon Communications, LLC ("Netgate") >>> >>> That=E2=80=99s normally a feature to stop userspace using deprecated = things. >>> Will you be reverting this once libpfctl is fixed? One could also hac= k >>> libpfctl instead to define COMPAT_FREEBSD14 temporarily (IIRC that=E2= =80=99s >>> what was done for kbdcontrol to allow it to run on old kernels). >>> >> I wasn=E2=80=99t planning on that, no. The libpfctl port fix should la= nd soon, but I figured that it=E2=80=99d be better to keep the definition= s, because userspace doesn=E2=80=99t know if the kernel is built with or = without COMPAT_FREEBSD14. >> I=E2=80=99m open to being persuaded that that=E2=80=99s a bad idea tho= ugh. > > Indeed it doesn=E2=80=99t, because it shouldn=E2=80=99t. The thinking i= s that userspace > should *never* explicitly use them, only the kernel to provide > compatibility with binaries built against older versions. Deliberately > exposing them to userspace is quite unusual and deemed generally dodgy.= > That makes sense. I=E2=80=99ll revert this change once the libpfctl port = update has had a chance to land and get built. Best regards, Kristof