From nobody Thu Oct 19 14:56:23 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SB9lZ1dlKz4xXlM; Thu, 19 Oct 2023 14:56:26 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SB9lZ13V0z4bKv; Thu, 19 Oct 2023 14:56:26 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697727386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xLiJswrXTJeF9HUk9Y6A8p+5EQxcSLwVKpBv+t0RlY4=; b=PI2SQOqmZS0v0jsCHH+svPtmb7559yJuWL8r4DCEf6HQqinh/GvN9XurHETZuP+9HxTkAr FyqsM+8GYrYOqt6GFG86HMqnWqpd0GQCV/yauGj/V0XvGoTSPEkZElMoCs+xZf/5DIoevG 5o90v39eDirSNEPPcRzuxe793lb4bu2toJU8dYSPNtWH5sOze1mtoI47PuuxHdOqEeOKt+ Z7i1ICJkzAaLUp9oy6MLJ7qofANfoPMqvGhloPyTTM6jxQ8siqXM/5yVnG1aSQs8rpASLQ UmwHrD+Lixorj6w3W1M4YMda6/Dle42ugGmKim93uew9xY7V0upNsVulQgH53A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697727386; a=rsa-sha256; cv=none; b=EgK9RE1PKk+8Jm714gh+3rLJ0amZSW8N8HZGBNoSGN/4YTW6TJZHotUoG5CU5GrHkijHCl M/8qa40ENh5c2bkWEI5Mm9QGaq4cWQyKI6dsGD3y4LoEkL6FFcM8naMFUvAUKNf/Qn7Djn bKnALhKlNhZ81zQ7xaDnP1rAuoNFmFyWf2Yfx4BpNjuq9iy+uEqfJhbTZZA8JGBV3ncrb+ HizzmLWBRrjLski4inqtprv9wZGMh+kSMWzc2I+xvGsl0M2vl2JjiWaRWvOSE5BlSliK3g 1rDXV0F6+awPPDOTe/twDG2A5L+67Abje92GScyKDWoMG7FF60zxVvFjf6x1qA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697727386; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xLiJswrXTJeF9HUk9Y6A8p+5EQxcSLwVKpBv+t0RlY4=; b=nHyuT3/CR1VkwgPFAAoDyIjkuNu9XwGdmQ+ii+LEAJbR73Yt1KF7CAxf+R8zlcdi5Uj2GJ ndMFapDUTrrtYTk9MLKddc57+F5rAHuiq7eMfy0bvTaJzCzlbpW2BORZcGczpC69Yl1pQz oLnTaabBwTkGr+/H6fi4DJyi0P26Zo9kS/nDhoeOOxfQPabMUB5vWVZwCV9wjrNsFI4j7S mZ59WZACWxcYs3N2G+FGEfTesMV9TFBl+Do9zeazDptIN6afTzDQGEK5eP7/iCtP0Fcxz2 e0m5qW5bzYxYIu/KcUvH1F/2ipWb9SUY0UE1iNrLd7MgFcl8BU4JaCgNiCBlng== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SB9lY6c8zz1694; Thu, 19 Oct 2023 14:56:25 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 0F8D581D7; Thu, 19 Oct 2023 16:56:24 +0200 (CEST) From: Kristof Provost To: Jessica Clarke Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 9eff6390718d - main - pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h Date: Thu, 19 Oct 2023 16:56:23 +0200 X-Mailer: MailMate (1.14r5937) Message-ID: In-Reply-To: <1DDF7B7C-9137-48F4-80C9-FDCC82F47118@freebsd.org> References: <202310191420.39JEKitw071108@gitrepo.freebsd.org> <1DDF7B7C-9137-48F4-80C9-FDCC82F47118@freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 19 Oct 2023, at 16:41, Jessica Clarke wrote: > On 19 Oct 2023, at 15:20, Kristof Provost wrote: >> >> The branch main has been updated by kp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D9eff6390718d0fa67dffc6c= d830b0bc6b815e8c4 >> >> commit 9eff6390718d0fa67dffc6cd830b0bc6b815e8c4 >> Author: Kristof Provost >> AuthorDate: 2023-10-19 10:06:29 +0000 >> Commit: Kristof Provost >> CommitDate: 2023-10-19 14:19:39 +0000 >> >> pf: remove COMPAT_FREEBSD14 #ifdef from pfvar.h >> >> When userspace includes pfvar.h it doesn't get the kernel's COMPAT_= * >> defines, so we end up not having required symbols in userspace. Thi= s >> caused the libpfctl port to fail to build. >> >> libpfctl will be updated to use the new netlink-based state export = code >> soon, which will also fix thix build issue. >> >> Sponsored by: Rubicon Communications, LLC ("Netgate") > > That=E2=80=99s normally a feature to stop userspace using deprecated th= ings. > Will you be reverting this once libpfctl is fixed? One could also hack > libpfctl instead to define COMPAT_FREEBSD14 temporarily (IIRC that=E2=80= =99s > what was done for kbdcontrol to allow it to run on old kernels). > I wasn=E2=80=99t planning on that, no. The libpfctl port fix should land = soon, but I figured that it=E2=80=99d be better to keep the definitions, = because userspace doesn=E2=80=99t know if the kernel is built with or wit= hout COMPAT_FREEBSD14. I=E2=80=99m open to being persuaded that that=E2=80=99s a bad idea though= =2E Long-term (i.e. by freebsd 16) the plan is for all of these ioctls to go = away (so the code for them will stay in 15, but not be in 16), but that d= oes depend on me doing a fair bit of work before then. Best regards, Kristof