From nobody Fri Oct 13 23:53:47 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S6jyM6Cvxz4wy2v; Fri, 13 Oct 2023 23:53:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S6jyM56C1z3Jcx; Fri, 13 Oct 2023 23:53:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697241227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ObAz5EMHQR4HOxrnpBdxhJVEm32dg4zNxTtE7lyRHFE=; b=cIS5P8u16Hl8OzI4DCUlTKKEzuTGrz6dKwr/fskmkKDx2R6E5FblMt0uQMNjrxp/YaT/2g IyMqjaLMg3OghKzHFymGXIcVPc5C/X67tcCbH0vBa6z+RlKFzVe5wBokQKJOGiXGQMNYs3 ZGFFTwRl2W5Imsilg8xdUHPGcndy07eLewOc3Xj0L+jDto28Qsxc8GjQC6hqnvJzV/a+Ey DjA0J13fUbNollaWCgWez7x9CJE9BvOoAEve4tBkWy4I5WCFzuVdM6hyWjlRN0+z3JIHdL JBbf++2/d0rQgMPpa8mH1XCjukyXi3C+maJsZJsPRT0lyJxkXDHjNUweDqbilA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697241227; a=rsa-sha256; cv=none; b=HD9fX9AK6pXESJAtQ4LfTSfU4H3wvr4A8azEbGHp417b6q/aSGZkQqXIZNGlL2AA6FduLI LadXif4fHfS26T7X9HQh6sByPCPtSoXPc8a3aVPNP65Wp5uMym8mJqvFXdJV5aJYTTc7L5 5Xp14eFo06EAR8z/1EidfuAAgn96XQb4ln8aQq9JcJLFguXpPfkNsah9WAGnzsZ+9rjRlA wmzIXyMq70gcdhpHNiM1oVC0c86x2c3ouncTM551Fa3+ppU9ssqSeI2nz4z6eHjTCqK17T CPu8nmld7ThBMlbt9Uz6lFQyDShQnHi5mDZCie59f0dpXwiebYOmrl+Kgb5nbg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697241227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ObAz5EMHQR4HOxrnpBdxhJVEm32dg4zNxTtE7lyRHFE=; b=vPuajoRdp7q5S7KeHJbjza+RqYYXKK6LNH1/vxQgKkjPJbyTGrwE0k3UvQomf2UKc8xA8j N8RDAYPM8gP7sf83J7IrQYO6BAWl2RahfyZK2Jj003UvqUpeuZonLYtRP+VUqhllEaDHhQ tY8Kr+7E/Tqt7RgJtKDY0TDjNoNjpHixL7ZjIHkunkYpUB0t7Ue/iKaX3rW9lpl/jTUqs0 s6KrMw4Ls4i7YMA1nRxR9HfSroGOu1FKnMU0DxJVpbZJNK3yLtmSdUoKjyR/Ct8P7cjgSu Q36jyVd31rehtLBfmJS+EMZqM5TAMOFcSPjVS51y7SEBjNgFtVFsAcQMVma1nA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S6jyM3wTLz17nc; Fri, 13 Oct 2023 23:53:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39DNrlsa031908; Fri, 13 Oct 2023 23:53:47 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39DNrl9U031905; Fri, 13 Oct 2023 23:53:47 GMT (envelope-from git) Date: Fri, 13 Oct 2023 23:53:47 GMT Message-Id: <202310132353.39DNrl9U031905@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 1dca3a9406f1 - stable/13 - vfs cache: retire dothits and dotdothits counters List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 1dca3a9406f12168919bdcafdb45cbbb613e9c8c Auto-Submitted: auto-generated The branch stable/13 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=1dca3a9406f12168919bdcafdb45cbbb613e9c8c commit 1dca3a9406f12168919bdcafdb45cbbb613e9c8c Author: Mateusz Guzik AuthorDate: 2023-09-23 00:08:49 +0000 Commit: Mateusz Guzik CommitDate: 2023-10-13 23:48:12 +0000 vfs cache: retire dothits and dotdothits counters They demonstrate nothing, and in case of dotdot they are not even hits. This is just a count of lookups with "..", which are not worth mentioniong. (cherry picked from commit bb124a0f611a1288c8496e3b33494f23ba929ca1) --- sys/kern/vfs_cache.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index 671451cadabc..29f14fb931e6 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -534,8 +534,6 @@ STATNODE_ULONG(neg, numneg, "Number of negative cache entries"); STATNODE_ULONG(count, numcache, "Number of cache entries"); STATNODE_COUNTER(heldvnodes, numcachehv, "Number of namecache entries with vnodes held"); STATNODE_COUNTER(drops, numdrops, "Number of dropped entries due to reaching the limit"); -STATNODE_COUNTER(dothits, dothits, "Number of '.' hits"); -STATNODE_COUNTER(dotdothits, dotdothits, "Number of '..' hits"); STATNODE_COUNTER(miss, nummiss, "Number of cache misses"); STATNODE_COUNTER(misszap, nummisszap, "Number of cache misses we do not want to cache"); STATNODE_COUNTER(poszaps, numposzaps, @@ -1786,7 +1784,6 @@ cache_lookup_dot(struct vnode *dvp, struct vnode **vpp, struct componentname *cn int ltype; *vpp = dvp; - counter_u64_add(dothits, 1); SDT_PROBE3(vfs, namecache, lookup, hit, dvp, ".", *vpp); if (tsp != NULL) timespecclear(tsp); @@ -1831,7 +1828,6 @@ cache_lookup_dotdot(struct vnode *dvp, struct vnode **vpp, struct componentname return (0); } - counter_u64_add(dotdothits, 1); retry: dvlp = VP2VNODELOCK(dvp); mtx_lock(dvlp); @@ -5078,7 +5074,6 @@ cache_fplookup_dot(struct cache_fpl *fpl) fpl->tvp = fpl->dvp; fpl->tvp_seqc = fpl->dvp_seqc; - counter_u64_add(dothits, 1); SDT_PROBE3(vfs, namecache, lookup, hit, fpl->dvp, ".", fpl->dvp); error = 0; @@ -5167,7 +5162,6 @@ cache_fplookup_dotdot(struct cache_fpl *fpl) return (cache_fpl_aborted(fpl)); } - counter_u64_add(dotdothits, 1); return (0); }