From nobody Tue Oct 10 22:26:17 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S4r8p1L77z4wPt0; Tue, 10 Oct 2023 22:26:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S4r8p0mdqz4H4p; Tue, 10 Oct 2023 22:26:18 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696976778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y+QaTl9eeIxV3vtKQrvHUUc0biwIVs/po1HNEe9ggiY=; b=QRN/rxPrEf/vuR2/piNb2xjStJBPN6oA9x1ezdN0jFS3BXND4TX6W+4rl9Xuo2xBNEqBlC pkMeNe3gC8W52cjQF2MlEYAHND7nLuk9egbbyoCzHgst/PpR7Qw+xQjVuQEkOdFSIs9JPQ gyoDdLfzLXdPMNkOYGWioPWL2Db+a2ZVjf5AnVcBEC/AwjpawkT0Wf0NpFU1t5aUsL9e+k cxvrgabO+6RshHZT+RQSFqbZQBU37/DfkI5NUqYGojoKRCsz7NFJyAmpIVqOfRBzccxgyo 8RotlDfqyKkM7Z6f0d40+wn0E8n6u7U42GTLmt34M+WtAJWwf9cZp0m0IPtn9g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696976778; a=rsa-sha256; cv=none; b=F7mdNx2cOzeO22RyI1ribhqNQ4viKFbR5Z3w2U4y4fr9dcS5Vfos+W1HmFdh6L8LG3NaND p+0m7NV4fYKU/3tJFYJkDBVNT0+VSa44ePi9DbaLbvQOtGsjyCXpEnr58yrgboc4P3JzJX 3EpZVhN+gjO9Z07w5zvaZrDWcluvNgtf1RFkcQhBcb51O0MvcFiD8G0FhzFoMwGJIXoq5Z vVMH7JSqz4rjezUzZO0JEB77PWpNNRJvGji2t1tX/Xl8SCzW8Y3QHCrrAgFPvJ79rY1OL3 3X9UpNH/NzNxszXWxhTFpY0C3Ai/oHlBtDzZaX8+7hYUG41kFV67BYx7f1+JLQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696976778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Y+QaTl9eeIxV3vtKQrvHUUc0biwIVs/po1HNEe9ggiY=; b=kUrDbu7hTsLd+Q6Oo7Tmj0v3FsYJ4Mvbl9qODe5PXJXOmaW9eD4ia2zaP1CM4TTepdrchd 9hKQ6sABPHj8StjSfKtXXXSvdNO+axM3B96D1XFBi7kgWOqWOweeD+ycGkzPMAhvp6L95a Zyt8KzHh46fsG0swGqqviF6J98pOLvw3+as1G3mstMnbNVXFa3wG0m2g8/BK/4SH9sDDDy o4njBViVacb4qnmOYSjCnX8/+6MNxiBrlwzmwKWxnPL0W0SCsZU4YEk7BfxsjI8IXTlbPU MQl6OUgHobqmjJ2U17ootQtA0zHCBR2NyH3zD3Thnw8pa58GivXz+JjZMs79cw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S4r8n6x8LzwTx; Tue, 10 Oct 2023 22:26:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39AMQHZV085459; Tue, 10 Oct 2023 22:26:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39AMQHc0085456; Tue, 10 Oct 2023 22:26:17 GMT (envelope-from git) Date: Tue, 10 Oct 2023 22:26:17 GMT Message-Id: <202310102226.39AMQHc0085456@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 6b2a6e9cb09b - main - nvme: Remove stale comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6b2a6e9cb09b1250b2a4042e0bfc60ae43835fc7 Auto-Submitted: auto-generated The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=6b2a6e9cb09b1250b2a4042e0bfc60ae43835fc7 commit 6b2a6e9cb09b1250b2a4042e0bfc60ae43835fc7 Author: Warner Losh AuthorDate: 2023-10-10 17:13:07 +0000 Commit: Warner Losh CommitDate: 2023-10-10 22:13:56 +0000 nvme: Remove stale comment After da8324a9258f, the pre/post hooks are gone. So remove a coment about why we don't call them in this case. Sponsored by: Netflix Reviewed by: chuck, jhb Differential Revision: https://reviews.freebsd.org/D42050 --- sys/dev/nvme/nvme_ctrlr.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/dev/nvme/nvme_ctrlr.c b/sys/dev/nvme/nvme_ctrlr.c index e5a548b6f6b2..90cd0b64a980 100644 --- a/sys/dev/nvme/nvme_ctrlr.c +++ b/sys/dev/nvme/nvme_ctrlr.c @@ -1133,11 +1133,6 @@ nvme_ctrlr_start_config_hook(void *arg) TSENTER(); - /* - * Don't call pre/post reset here. We've not yet created the qpairs, - * haven't setup the ISRs, so there's no need to 'drain' them or - * 'exclude' them. - */ if (nvme_ctrlr_hw_reset(ctrlr) != 0) { fail: nvme_ctrlr_fail(ctrlr);