From nobody Mon Oct 09 19:50:38 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S48lg0VCQz4wFdT; Mon, 9 Oct 2023 19:50:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S48lf75GZz4Yg3; Mon, 9 Oct 2023 19:50:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696881039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xNePUKc5+nKODCbC0lnQSoINuRL3uBjvb4gRdO9x420=; b=ydyby1Gnyi+pV1tqXyPQzMU42vcMUCOM2xZKvCzNzi6S0ojcR8R0fKC7AiYvACRqYnmJr7 TRG50Q+OPuWuV4Rxy4LYFMXsa05ujIQAG57MAsujcXt+4byJ73akqTfLMznVYuyBIIDc05 meG4au0unibjvk9I/+dJbBwtsjH7sb8POGaEF+7q192+1XxDn8KLHykodlAPS31uBkfdWi TLoQrWtuUyciQkitOS+i4liOciIdZOxgrT1abQBH9d4sw9WPQWE3byf7K3SuNeXQFITaMn +94fwrxPZdsYaRn5gxpPam+0u9MBc8B1GqezjOyzRnB0sLGoO8/E0dADOJPeCQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696881039; a=rsa-sha256; cv=none; b=dbsPeOz0QtdFIqGcG/RY7giVVPAr9JjmK4SUiWETxfDDCgTsnHzgeF0gYrWz0qJdmDMbYn VzNpoYr1W9JBg4u+DcooCGpWfSfEYxGSbwHTgc04bZ67zZbJ7s5JBcd3TAeTfcjA2VyATk yT/0WICQNW5tmZdgAhqMxuzDnApDVkRdEsD2vnggiaZMVlzYEFrFzG9xvNSzjh1VlPzIGv uo/I8H0ueRhdV2oRhbF8V+Q/qR/lRqY4sDa2qEznT0nhOQgDx5jG6jgaLLF05sTpAjdHoi Y5XUW4umhIW2SwNShYTZEciuopjdRcNIdoKSlSl6XL0ksD0IK+a7LSFCoPQqEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696881039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xNePUKc5+nKODCbC0lnQSoINuRL3uBjvb4gRdO9x420=; b=n7ZfNN8rB5R8WKoy5u6BVvvqSpfk1P0mcn6cqh6KD+EcXTDn3t6qf+sIVqYSLfO7KXGrlJ 4af0noqU+RnrQJA/exLl5FTtNQpZTc+Zh0XfS9N9uV7YsqJJUaAnedHmeZI17MFitQH6mb htuhXVbRu/YzACRq8PHrfWxvGnien5Fm/3cbzVjZd2U1DcATpzj2MiNQS/uKDSqFxLLXTC 0jp4PVEKTE2KhogDT4LOYF6oLN/NU3TesuUL5nlA3JiWrk9OePoi5tQ3ALXpczvUznu+SW iApOcey1XdAfgwVO8bDHcLHb/NHXwUWvtS+kIMz8rNFyMI9e1mYhtLcV5P4n+Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S48lf68Z4z17Hm; Mon, 9 Oct 2023 19:50:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 399JocAB033348; Mon, 9 Oct 2023 19:50:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 399Jocsa033345; Mon, 9 Oct 2023 19:50:38 GMT (envelope-from git) Date: Mon, 9 Oct 2023 19:50:38 GMT Message-Id: <202310091950.399Jocsa033345@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: ad134f8ab768 - main - iwlwifi: re-enable "Invalid TXQ id" logging List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ad134f8ab768e3b1d2db203f1cc963bdf0eea857 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=ad134f8ab768e3b1d2db203f1cc963bdf0eea857 commit ad134f8ab768e3b1d2db203f1cc963bdf0eea857 Author: Bjoern A. Zeeb AuthorDate: 2023-10-09 19:47:39 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-10-09 19:50:02 +0000 iwlwifi: re-enable "Invalid TXQ id" logging Various reports recently hit the "Invalid TXQ id" in iwlwifi again. Unconditionally enable logging and add a note to report to a specific PR in the log message for now. Along with 018d93ece16b this will hopefully help us to understand what is going on. Sponsored by: The FreeBSD Foundation PR: 274382 --- sys/contrib/dev/iwlwifi/mvm/tx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sys/contrib/dev/iwlwifi/mvm/tx.c b/sys/contrib/dev/iwlwifi/mvm/tx.c index 2407d0ee832e..da33c1a5cc46 100644 --- a/sys/contrib/dev/iwlwifi/mvm/tx.c +++ b/sys/contrib/dev/iwlwifi/mvm/tx.c @@ -1199,9 +1199,10 @@ static int iwl_mvm_tx_mpdu(struct iwl_mvm *mvm, struct sk_buff *skb, if (WARN_ONCE(txq_id == IWL_MVM_INVALID_QUEUE, "Invalid TXQ id")) { #if defined(__FreeBSD__) - IWL_DEBUG_TX(mvm, "fc %#06x tid %u txq_id %u mvm %p " - "skb %p { len %u } info %p sta %p\n", fc, - tid, txq_id, mvm, skb, skb->len, info, sta); + printf("%s:%d: fc %#06x tid %u txq_id %u mvm %p " + "skb %p { len %u } info %p sta %p (if you see this please " + "report to PR 274382)\n", __func__, __LINE__, + fc, tid, txq_id, mvm, skb, skb->len, info, sta); #endif iwl_trans_free_tx_cmd(mvm->trans, dev_cmd); spin_unlock(&mvmsta->lock);