From nobody Fri Oct 06 14:25:10 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S29gV5XYnz4wgkM; Fri, 6 Oct 2023 14:25:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S29gV4srWz3R6l; Fri, 6 Oct 2023 14:25:10 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696602310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QJWoYEfDLO+JH2Z13vnqZI3dJhyqKkXTlrL2LEEDMKs=; b=TS4skLsGfuAkY+/KnIDGUlMqnF5PVtw/WPhCII9xEt1tvvYHhP4/5N1LUvmS2Hq3REv4fW uZZb5539yCxbeMEcDOJKH/a4oKoY+xYh/nOjhGHwNPC9cIg1cUfNEYY3EfF6VGprY6mJOa iqi98hoqOmCp/UiUysZlQEtH2o6IYqGCMh7tfNy7k+I2/1h+4pkE3RXZVEpolDEKZ34xIe vX3LUFpVcyOS+/dUT1+mmB56NXr9DshOKbDFcpOfWaA+bLDTlpnmy0/ZkX5qxo9v6le/bs DjSO2qqGs1ZbkBCz4GsunAXZUidFKAYxN+G4Wdz5tc8zWqeA1GDc8x+duW5vhQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696602310; a=rsa-sha256; cv=none; b=VjBXjkS670oXJNnMnPCOOIqI3J1ZlKUsaTmGqyON9pTLgn6At1mRJPCSFGyGFknkKQGSF8 wKNSvNpPuuSoYi0GeRt356/seVgR68x5relYzKL1Re0hENoXk14R4FJ7cWKCCZsCj7UBQh yAb+JsG4QoR/EZw6SCmj6rva4quxjSdRLcPtcPI+fUhBBsyQXYAfCBpNMr2U4ESQOuV1wM 5O8hIl4tE1SQh5v99k8W5IYYnXfmguIKUnxNiFflG8veAxI61cX8BzCSRDDjQzHGxpLbTZ lwq9vx3KMBnuU29BCztqAIEUxnSkKyk+5P/qXHxIUu+Ruk6oyN07iOsXggUZdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696602310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QJWoYEfDLO+JH2Z13vnqZI3dJhyqKkXTlrL2LEEDMKs=; b=w/EjOceNpM/kcwZ3uEZDUj+aizCVR5ZmJpJY06AXi6pARNT3Dtc4fcPtSyC/oJWZ4gfknm XVxfgIX+81/irwtZFuH2ZuBkArB0GJJCgmC2/tl0Gau20ykBQ+Ywu21dkIp3cT0YS42jgH WOXXg/kraOgKjl863BYutSECH2PexwNv/Tan35Zyku7APOwLSwW3Mzbc5RN5jHdIrenVpC ti8/xWNp7GDGNX/dsT9lyz4WdTLbReUlg44HZULhmVs44my0SKyEGf47W3hPRabluYwDBZ 2gQdK0DjGM2jRSLUzmKGQ0WdFOA2Z+jX+OqJB3AstlFRusJNtz5kddVM7Ai3cg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S29gV3ysVzrkF; Fri, 6 Oct 2023 14:25:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 396EPAEO093290; Fri, 6 Oct 2023 14:25:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 396EPAFg093287; Fri, 6 Oct 2023 14:25:10 GMT (envelope-from git) Date: Fri, 6 Oct 2023 14:25:10 GMT Message-Id: <202310061425.396EPAFg093287@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 753730087671 - stable/14 - LinuxKPI: 802.11: change ic_parent() to not call mo_stop()/mo_start() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 753730087671551425554a28d64c898997f9bbdd Auto-Submitted: auto-generated The branch stable/14 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=753730087671551425554a28d64c898997f9bbdd commit 753730087671551425554a28d64c898997f9bbdd Author: Bjoern A. Zeeb AuthorDate: 2023-09-21 12:25:20 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-10-06 12:47:40 +0000 LinuxKPI: 802.11: change ic_parent() to not call mo_stop()/mo_start() Driven by net80211 we may call mac80211 ops stop() and start() mostly when toggling a first VAP. While this is FreeBSD behaviour the firmware based LinuxKPI drivers seem to possibly clear state in the case of stop() triggering further errors down the line. We call mo_start() when starting the VAP and mo_stop() when destroying it now only. In the future (e.g., in multi-VAP setups) we may need to re-address some of this so keep the code under #ifdef. Sponsored by: The FreeBSD Foundation (cherry picked from commit 8d58a0578635dc7dd1025ab08b0479f2b383e1a4) --- sys/compat/linuxkpi/common/src/linux_80211.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index ac43b1248536..04ee75eb2c68 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -2468,24 +2468,32 @@ static void lkpi_ic_parent(struct ieee80211com *ic) { struct lkpi_hw *lhw; +#ifdef HW_START_STOP struct ieee80211_hw *hw; int error; +#endif bool start_all; IMPROVE(); lhw = ic->ic_softc; +#ifdef HW_START_STOP hw = LHW_TO_HW(lhw); +#endif start_all = false; /* IEEE80211_UNLOCK(ic); */ LKPI_80211_LHW_LOCK(lhw); if (ic->ic_nrunning > 0) { +#ifdef HW_START_STOP error = lkpi_80211_mo_start(hw); if (error == 0) +#endif start_all = true; } else { +#ifdef HW_START_STOP lkpi_80211_mo_stop(hw); +#endif } LKPI_80211_LHW_UNLOCK(lhw); /* IEEE80211_LOCK(ic); */