From nobody Thu Oct 05 15:10:20 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S1Zk44VRhz4vjlw; Thu, 5 Oct 2023 15:10:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S1Zk43wvgz4XPB; Thu, 5 Oct 2023 15:10:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696518620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+pEy6vfrWOp85dRTWmHyMdDPEOkl4RIGZfgu80GlUlU=; b=LwfeFjxcdOkvyIP0El6NTuHogGPyN8so8+mvFCvyA/Oh0gOVbTiUpEL96aNaevIooY3PXs aTkc220yzMXyasXvqveZipK3KZnT9XyXDpttqgQuZuMHe1wVAkGhipZ21geixTh9ot5pWq HvZKOovzksUft24PuB+w+Lpwm6fWu102OpKL0+/0S3W7xJTGCpW+JQN5WGHJV8CklWeQBF Pd9kgrA/EVCJE1IMuX4P8a47DnD7YHv15yfVHQzlWUXwAFH+kEdKdF6ome4urR/8I8RwSI 30gDQSIKJ7IlfLzjDEbg2IH51Upc9wxtwom2eilMbMArx09j9fOrBin89UXg5w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696518620; a=rsa-sha256; cv=none; b=fnCDXEeJg9zWgaH8s/pQRmRz8HS+wmzDp9fGhzpvPUdk14E8xbR4SBfBMcYiV45AIpUsTw /j0Te5UfE4t3snzNbv05RGowoDrGOihK5LKnnFh3l8trQD9PYqALCgM2+etnFpmWfpvtUX XAvqAImfy8Xex5ew7bH6AMMhqKEVpUSQzDJk+7X03ltbl1NTXnBLl/h1BZo/PSH8GPRGIo M1JEHb2XYh9a+6nzra/zHG925o6MWrD7G1ZLLzOj80SLl/MwHw6EH+xc442S1XSDQoULGj KvoeRvEzrAWlTmujtEYn9nv5wvEd6GqeKxS03Pzmq05sGwpfeSqJQzvSdQra5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696518620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+pEy6vfrWOp85dRTWmHyMdDPEOkl4RIGZfgu80GlUlU=; b=JAN4jZ5bDgjnNFGamvrCUwIvhD2WUiKe/QBxmpr5YQlh/PV9v40s1yIXgfDC37BIWaKi1w gjoEO0eH6nZCcTNteaWd4Yj+Uv8ufmxRWdz9PFfIKjEY+SWqOuPgrmvpr+ihJP2qyc7VO8 /lxhrIWsFwgvT1sYU+UvqnNYa+j2WsKcaQTs0qiCABnAQMy1FblW6QVkabl8i2nBoCrN0p sI0N1DnARB54hmzZDjBo3HrN/ZztiJH/Oe+bxhEOR9amtpI1PFR98A2MmVcZGzKtvwfOKs BO4vIYIR5NmhAibnT6vSIzzNDC18p2hZcqGleJ3OGSbRy3XkIeBEo7+x98nb6g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S1Zk43277z1PcX; Thu, 5 Oct 2023 15:10:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 395FAKWr071476; Thu, 5 Oct 2023 15:10:20 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 395FAKiJ071473; Thu, 5 Oct 2023 15:10:20 GMT (envelope-from git) Date: Thu, 5 Oct 2023 15:10:20 GMT Message-Id: <202310051510.395FAKiJ071473@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 5e78399dda05 - releng/14.0 - makefs/zfs: Remove a nonsensical comment List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: 5e78399dda052dfa8c62b3e8b678d29196ca7a0c Auto-Submitted: auto-generated The branch releng/14.0 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=5e78399dda052dfa8c62b3e8b678d29196ca7a0c commit 5e78399dda052dfa8c62b3e8b678d29196ca7a0c Author: Mark Johnston AuthorDate: 2023-09-27 22:21:37 +0000 Commit: Mark Johnston CommitDate: 2023-10-05 14:01:26 +0000 makefs/zfs: Remove a nonsensical comment When populating files, makefs needs to copy their contents into userspace in order to compute a checksum, so copy_file_range(2) is out of the question. Though, it could possibly be used when building other types of filesystems. Approved by: re (gjb) MFC after: 1 week Sponsored by: The FreeBSD Foundation (cherry picked from commit 60c95af88f6a63fb7c2c86c6ff9c18743f6bbf0d) (cherry picked from commit 0074d0551ded1652155a23c6a8d04043c8ede1fd) --- usr.sbin/makefs/zfs/fs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/usr.sbin/makefs/zfs/fs.c b/usr.sbin/makefs/zfs/fs.c index a4968d5f91e8..0d85ea8eb9d8 100644 --- a/usr.sbin/makefs/zfs/fs.c +++ b/usr.sbin/makefs/zfs/fs.c @@ -551,8 +551,6 @@ fs_populate_file(fsnode *cur, struct fs_populate_arg *arg) /* * Fill up our buffer, handling partial reads. - * - * It might be profitable to use copy_file_range(2) here. */ sofar = 0; target = MIN(size - foff, (off_t)bufsz);