git: 96655d8a7db4 - stable/14 - LinuxKPI: 802.11: fix counting the number of supbands

From: Bjoern A. Zeeb <bz_at_FreeBSD.org>
Date: Wed, 04 Oct 2023 15:23:47 UTC
The branch stable/14 has been updated by bz:

URL: https://cgit.FreeBSD.org/src/commit/?id=96655d8a7db48f0944aebf07ffdcaa8a23aaa35a

commit 96655d8a7db48f0944aebf07ffdcaa8a23aaa35a
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: 2023-09-14 17:57:53 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: 2023-10-04 15:19:18 +0000

    LinuxKPI: 802.11: fix counting the number of supbands
    
    While the main purpose was to assign an(y) early chandef with the
    loop, later additions made use of it to also count supbands as well
    as to initialise max_rates.
    Due to the main goal we can exit the loop early and not properly
    count and initialise supbands and max_rates.
    Move the terminating condition into the loop and make it a continue
    rather than ending the loop.
    
    Fixes:          d9945d7821b9b ("improve hw_scan")
    Sponsored by:   The FreeBSD Foundation
    
    (cherry picked from commit f454a4a10dc027474a85269cb4a3f50bbbf90528)
---
 sys/compat/linuxkpi/common/src/linux_80211.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c
index 4b9cc598740b..cb919bfd3f5b 100644
--- a/sys/compat/linuxkpi/common/src/linux_80211.c
+++ b/sys/compat/linuxkpi/common/src/linux_80211.c
@@ -3760,8 +3760,7 @@ linuxkpi_ieee80211_ifattach(struct ieee80211_hw *hw)
 	 * in any band so we can scale [(ext) sup rates] IE(s) accordingly.
 	 */
 	lhw->supbands = lhw->max_rates = 0;
-	for (band = 0; band < NUM_NL80211_BANDS &&
-	    hw->conf.chandef.chan == NULL; band++) {
+	for (band = 0; band < NUM_NL80211_BANDS; band++) {
 		struct ieee80211_supported_band *supband;
 		struct linuxkpi_ieee80211_channel *channels;
 
@@ -3772,6 +3771,10 @@ linuxkpi_ieee80211_ifattach(struct ieee80211_hw *hw)
 		lhw->supbands++;
 		lhw->max_rates = max(lhw->max_rates, supband->n_bitrates);
 
+		/* If we have a channel, we need to keep counting supbands. */
+		if (hw->conf.chandef.chan != NULL)
+			continue;
+
 		channels = supband->channels;
 		for (i = 0; i < supband->n_channels; i++) {