From nobody Wed Oct 04 12:08:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S0tl75mTCz4vpBf; Wed, 4 Oct 2023 12:08:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S0tl75GjWz3HxG; Wed, 4 Oct 2023 12:08:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696421331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yd0D7zwQxz9L6Q+UfBVk0T1SzMMJqkKZX/rvOPNLQM0=; b=CgM+WJQRo2pdDvKpeEsY2tYWegJfSpoUELc0GbtmleTF4whkQG1b8DgV6qAYmJR3SqTN8+ XU305FEBxQh3SRKtjO2FklxH8TtHzu5lSJkJptVBb9+Wxkoxl4LjHIZvi2ityUcmVuT/Pv 6Cg4B7gTPDh7J4vykFywQYUm0x3/uitPwGuQq6kBDmq3hszAYLtVeMWPSVwYPhnxaCZWb2 jx050oHd7gt2kyHh+CjtecP28Rxohh4HdoowXqDhfn4ogab8umJhn6l3d2ksE4XrJe4u3c DqAkTEwF9r6uYTIYU9PsKgk5NuVwt7dJrB5Q1tJhaJex9Fpb5fBtmvSAdzttgQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696421331; a=rsa-sha256; cv=none; b=h22KgH0DvvFW8TVfu2YfG5tIuRg2/0XYapB0orlcs9pgALrhkCXDMNCO1k4OZqN1qoKWtz fIpo4/FFaLsZmenj+4Y5OBYn62E9GccMOoRaSXHntpsw+npxUJUi+d0g1LaR+Wr+LvFjl5 s2UWH0tUoW1ee4b+sJqhlUwzNrlUNPHWrsr4qe9hA/kYouNqnnz/5NHCcaWinfpgXtRQrM D0nbBErss0GUI9TSxzhzYJ2C+9+1AYOz1IPtxiclE9w5Xe7mABDptWvN6ZL2AWZO/Afdt8 4EI3Sac1BdAzjeJjAnA7CrQk8xJYUnMcbkNe9oP1YQEUbWCyajVP9qVGwyIPAA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696421331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yd0D7zwQxz9L6Q+UfBVk0T1SzMMJqkKZX/rvOPNLQM0=; b=mNdGknqixOrysJ+aBMDnoX7DTqEyFHvczP9AymAWnK2kFqv1ztcW9IUeDMIp70M10/ROWW 7WduAlWIm/aVlOSlqUbxoKI7tBZrmAzOCuAQs2G6pEmym6t5EpvA7sxYjilUv4vLQSKYk0 TPejFqzN4btcbhILvAPDLJoeQ04fKbcSNJixpT2pNPFkNT0O+oaqCKcDYzQu0ih5Ynqkaj 8k2C16ewvFXqHpWcTPKXrf/zQyfIKLdH9AFpAQIsvAs6vS+pwhlDYHvVseClS8f6HrpskF 0Qp+hpTvfe80UMPGOhflwbWk8BdFeUBKVbgXyEU5eNw/I/sr7dea3p8aHG4reg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S0tl74MR9zc3W; Wed, 4 Oct 2023 12:08:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 394C8pZX053236; Wed, 4 Oct 2023 12:08:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 394C8pnv053233; Wed, 4 Oct 2023 12:08:51 GMT (envelope-from git) Date: Wed, 4 Oct 2023 12:08:51 GMT Message-Id: <202310041208.394C8pnv053233@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mateusz Guzik Subject: git: 2167265cb801 - stable/13 - vfs: fix stale comment about freevnodes management List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 2167265cb801f1eeea3a1dd768fa1d9779d10a6e Auto-Submitted: auto-generated The branch stable/13 has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=2167265cb801f1eeea3a1dd768fa1d9779d10a6e commit 2167265cb801f1eeea3a1dd768fa1d9779d10a6e Author: Mateusz Guzik AuthorDate: 2023-09-14 17:28:32 +0000 Commit: Mateusz Guzik CommitDate: 2023-10-04 12:04:15 +0000 vfs: fix stale comment about freevnodes management (cherry picked from commit 9dc0c983b0931f359c2ff10d47ad835ef74e929a) --- sys/kern/vfs_subr.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index f58c8920dc4f..41fd5052968c 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -1459,12 +1459,12 @@ static struct proc *vnlruproc; static int vnlruproc_sig; /* - * The main freevnodes counter is only updated when threads requeue their vnode - * batches. CPUs are conditionally walked to compute a more accurate total. + * The main freevnodes counter is only updated when a counter local to CPU + * diverges from 0 by more than VNLRU_FREEVNODES_SLOP. CPUs are conditionally + * walked to compute a more accurate total. * - * Limit how much of a slop are we willing to tolerate. Note: the actual value - * at any given moment can still exceed slop, but it should not be by significant - * margin in practice. + * Note: the actual value at any given moment can still exceed slop, but it + * should not be by significant margin in practice. */ #define VNLRU_FREEVNODES_SLOP 126