From nobody Tue Oct 03 03:25:33 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S039q0snHz4vd4s for ; Tue, 3 Oct 2023 03:25:35 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from mail.tarsnap.com (mail.tarsnap.com [54.86.246.204]) by mx1.freebsd.org (Postfix) with SMTP id 4S039p329Qz4SGF for ; Tue, 3 Oct 2023 03:25:34 +0000 (UTC) (envelope-from cperciva@freebsd.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 54.86.246.204 is neither permitted nor denied by domain of cperciva@freebsd.org) smtp.mailfrom=cperciva@freebsd.org; dmarc=none Received: (qmail 94566 invoked from network); 3 Oct 2023 03:25:33 -0000 Received: from unknown (HELO dell7390.daemonology.net) (127.0.0.1) by mail.tarsnap.com with SMTP; 3 Oct 2023 03:25:33 -0000 Received: (qmail 74902 invoked from network); 3 Oct 2023 03:25:33 -0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 3 Oct 2023 03:25:33 -0000 Message-ID: <226ab4a0-f6c8-d5c1-e564-bde9cb4cd797@freebsd.org> Date: Mon, 2 Oct 2023 20:25:33 -0700 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: git: 7494fb6b7d80 - main - EC2: Flavour existing AMIs as "base" Content-Language: en-US To: Alexey Dokuchaev Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202309282218.38SMIqGH056845@gitrepo.freebsd.org> From: Colin Percival In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: / X-Spamd-Result: default: False [0.50 / 15.00]; VIOLATED_DIRECT_SPF(3.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[54.86.246.204:from]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:14618, ipnet:54.86.0.0/16, country:US]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[cperciva]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Queue-Id: 4S039p329Qz4SGF On 9/28/23 22:52, Alexey Dokuchaev wrote: > On Thu, Sep 28, 2023 at 10:18:52PM +0000, Colin Percival wrote: >> commit 7494fb6b7d809257d4eb9eff06ce226143f27add >> >> EC2: Flavour existing AMIs as "base" > > I think it should be "flavor" since FreeBSD prefers American spelling. I understand that's a policy for FreeBSD documentation, but I'm not aware of any such policy for the FreeBSD src tree. And indeed there are thousands of behaviours, colours, and flavours in the tree, including "colours offered by the original IBM PC Color Graphics Adapter". >> @@ -31,6 +31,7 @@ BASIC-CI_DESC= Image for CI >> EC2_FORMAT= raw >> EC2_FSLIST= ufs zfs >> EC2_DESC= Amazon EC2 image >> +EC2_FLAVOURS= BASE > > Since other nearby values (format, filesystems) are lowercase, perhaps > it makes sense to say EC2_FLAVORS=base and :tu it when needed in the > code to keep declarations consistent and tidy. We already had "VIRTUALBOX" and "VMWARE" flavours of Vagrant (and these are all flavours of upper-cased EC2/GCE/OCI/VAGRANT/etc) so I figured that I would follow the example of being, err, consistently inconsistent. I agree that having everything in lower case would make sense though. -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid