From nobody Mon Oct 02 08:29:24 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RzYyr2nh3z4vmdC; Mon, 2 Oct 2023 08:29:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RzYyr2B96z4KQ7; Mon, 2 Oct 2023 08:29:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696235364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GqrGSG6GCIxIXJryrZUscJYVAusYRNoFLP/rq6xRQf4=; b=TnDVWwubGxkH77Jl+mPTgXzhKu/rFqjR4pdYu2zNRK8u7LCM+fWvzn9ikw65PqZ2wlCS8b YGiAU3fraEz/tYzRwkzhrdg1f4l4KzJNgYt+30POvkgWRjn4HLj/s1og+YEMBK9q8JM2vk RmaFibS72wAu6rQv8o6zauCSgk25nSUcZDik/Xs+INorgb6wWoNjQEz4GubFuCZch+BMaN Rx3bWl2joVn6XDUDIiTJmvSyCn7i8uk8zDVdH2DcBGbTkh3NEI1l/iYab+fAWChME3Hh24 yiGSSuQoz+IZsABDMPX5AdvVslDqWUmUOcJpKZcB4wfiJ0/nQzPoaDGQ5QuCNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696235364; a=rsa-sha256; cv=none; b=WIM5dk7OXJ1c+wAVyOS3yh8+kp/EgFi9sZ0gsbToBKZ+Sq/97kal7eciHKZocpWmhoRtjX 2W0WcBG9eBK/s5tXbR5VAL28aX7CrB3lmHaw04OXJKVHTjD2phMAc7JxctvqKiyjz4URZY BUtlmKTE53zzunyq+5Ik187AbiHDfdvQl3JxHhpPQWfYFICDbLbsl6U+Xl+0OM+dg9uHiS DaBkcubrZTLYBztzT02oRXsBQXG7rWFUgS1rI2WvdoqdKPUu04tM2JEjkIEg2Z9Sdp8GR1 pqQ4uoJVM4KZlPdViAJW4awq0k5h8ZBk8NB6LYXdZgEGJoN1EvYOYwLREntsOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696235364; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GqrGSG6GCIxIXJryrZUscJYVAusYRNoFLP/rq6xRQf4=; b=Gm8eWJp7Jce+1QaYKBKJg+5bk5M8pozm/2lCzXX1Pmnv3HdF3xCDSGU/3Rzwbx5x6MIypR 7BtnntjmWu0Rm8mSG6ZorCQznpkmUQ3C5feu3LoQ1IaMUGVUwfBl7n0tr6gqS4FFK0FXLn XZFNnY+U7F35RpmBJ0478Yz9MhIn8MJTtiVLpJ8MAUomSEMr1VyfiJPM23bbxnfJNlay6M orFLSQeWhnHllBGj07oQf3beorF6Qk56dlT0Cd938MyXGe3V776CbtWDxXmg8vS3EfCU/2 R3XkSpTQe3dWbN8OCzoeV/x1bGYUCKyLLe8OM1FQaxc4s3QSYuR/3Lh9ygPBCg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RzYyr1GFLz14pM; Mon, 2 Oct 2023 08:29:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3928TOFf086444; Mon, 2 Oct 2023 08:29:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3928TOdS086441; Mon, 2 Oct 2023 08:29:24 GMT (envelope-from git) Date: Mon, 2 Oct 2023 08:29:24 GMT Message-Id: <202310020829.3928TOdS086441@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: ef3edef9ec8b - stable/13 - ip_mroute: Fix sysctl knobs List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: ef3edef9ec8b7d19e5f66c385340604ab29ccc78 Auto-Submitted: auto-generated The branch stable/13 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=ef3edef9ec8b7d19e5f66c385340604ab29ccc78 commit ef3edef9ec8b7d19e5f66c385340604ab29ccc78 Author: Zhenlei Huang AuthorDate: 2023-09-27 16:23:22 +0000 Commit: Zhenlei Huang CommitDate: 2023-10-02 08:28:23 +0000 ip_mroute: Fix sysctl knobs The loader tunable `net.inet.ip.mfchashsize` does not have corresponding sysctl MIB entry. Just add it. While here, the sysctl variable `net.inet.pim.squelch_wholepkt` is actually a loader tunable. Add sysctl flag CTLFLAG_TUN to it so that `sysctl -T` will report it correctly. Reviewed by: kp Fixes: 443fc3176dee Introduce a number of changes to the MROUTING code MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D41997 (cherry picked from commit f549e22901b3a391c76659bee55802b1214112fd) (cherry picked from commit b0f026435a150933ecb6f2d1359fd1b4898657f1) --- sys/netinet/ip_mroute.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/sys/netinet/ip_mroute.c b/sys/netinet/ip_mroute.c index d8c5c74231ec..ca510610e4e7 100644 --- a/sys/netinet/ip_mroute.c +++ b/sys/netinet/ip_mroute.c @@ -161,7 +161,9 @@ VNET_DEFINE_STATIC(u_long, mfchash); ((g).s_addr >> 20) ^ ((g).s_addr >> 10) ^ (g).s_addr) & V_mfchash) #define MFCHASHSIZE 256 -static u_long mfchashsize; /* Hash size */ +static u_long mfchashsize = MFCHASHSIZE; /* Hash size */ +SYSCTL_ULONG(_net_inet_ip, OID_AUTO, mfchashsize, CTLFLAG_RDTUN, + &mfchashsize, 0, "IPv4 Multicast Forwarding Table hash size"); VNET_DEFINE_STATIC(u_char *, nexpire); /* 0..mfchashsize-1 */ #define V_nexpire VNET(nexpire) VNET_DEFINE_STATIC(LIST_HEAD(mfchashhdr, mfc)*, mfchashtbl); @@ -234,7 +236,7 @@ SYSCTL_VNET_PCPUSTAT(_net_inet_pim, PIMCTL_STATS, stats, struct pimstat, pimstat, "PIM Statistics (struct pimstat, netinet/pim_var.h)"); static u_long pim_squelch_wholepkt = 0; -SYSCTL_ULONG(_net_inet_pim, OID_AUTO, squelch_wholepkt, CTLFLAG_RW, +SYSCTL_ULONG(_net_inet_pim, OID_AUTO, squelch_wholepkt, CTLFLAG_RWTUN, &pim_squelch_wholepkt, 0, "Disable IGMP_WHOLEPKT notifications if rendezvous point is unspecified"); @@ -2876,18 +2878,12 @@ ip_mroute_modevent(module_t mod, int type, void *unused) MFC_LOCK_INIT(); VIF_LOCK_INIT(); - mfchashsize = MFCHASHSIZE; - if (TUNABLE_ULONG_FETCH("net.inet.ip.mfchashsize", &mfchashsize) && - !powerof2(mfchashsize)) { + if (!powerof2(mfchashsize)) { printf("WARNING: %s not a power of 2; using default\n", "net.inet.ip.mfchashsize"); mfchashsize = MFCHASHSIZE; } - pim_squelch_wholepkt = 0; - TUNABLE_ULONG_FETCH("net.inet.pim.squelch_wholepkt", - &pim_squelch_wholepkt); - pim_encap_cookie = ip_encap_attach(&ipv4_encap_cfg, NULL, M_WAITOK); ip_mcast_src = X_ip_mcast_src;