From nobody Thu Nov 30 00:38:11 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sgcjv6mpcz52V6N; Thu, 30 Nov 2023 00:38:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sgcjv4vVYz3MQY; Thu, 30 Nov 2023 00:38:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701304691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YduJLGJwan/hn58yz1/ERoc2EEHu89aOUHQ5lR+Z8q8=; b=jq/2Wm4zfbB2h5ZqgmbmFyuTDRAQygIIlnUtLDplgyA9IcVPmcvNzrAsEIX9ezew/CUO8d Ka3gLNVbomp7tqZuMVl3iK6d8ylnONxoutkkH215xuIwWoZnSVG7MGN3ihP49LUU7FJndG UQjRFo/uOyq+IGDpv7JB8DzRxDptdUueeUEjGl2wnzT0Jpgr1RaSAWfiZDy3uOMQbnmU+Q 4gnAox+9uGdJJ3AoZdBy4CfK3nHUAgHMHb/+mKDZng4twNbN4X4/gDE6h/EBzvfz7CX1Dx y0hxiO37QbrabxEn/YBD7/6QNPKYTX8zcAVU3ns8RjP9FiYmOyNh2CHz/Y4FtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701304691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=YduJLGJwan/hn58yz1/ERoc2EEHu89aOUHQ5lR+Z8q8=; b=RtOmyNPqsu/ZAeLPIielHnVvkIPxX4NTy8UY05RpIvA02/8amR5mLWPigGkskeMRLcv2Ad RnUuFnE3ItCVA5cWzZL1gkkI6JAc9mMuWpRQlR+RdTV7fmLRj22mtdKF7f9H/ejTnDEDxf z6OWZD21ymG0U7726uRDYDwnBNGNPIz+XkIw11WXjenxnEPNFZfUluJkzYEHh3kSc7Go9g BRylG34io8f5QOay0+5sv0V1q0qdPZpxMVKww7r6Yqo1shsgNMdooT7plcW/2t5e7AH9go /LMxpVjIwo/EBTKKQ/gXZxLyzcS9Pw14rZBj8QxnnoPvGSq8TX2OBUcQYrS9Nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701304691; a=rsa-sha256; cv=none; b=sdRouyP+xniw+dgnpPQmGqT9pbSNbRBRhFqQaFaTkfRczDjrmeVt/lIG6YeIv1pUZnW8M8 u0BodKgOVQBt1PU64yGlarm6/901Bu5IWmzgk51GN6cuN9bIUcNmXoRWhF6GDb0BvWSYwI pz1DeYdKcSYHfZmCeYfQXcQ+96wSdPqd2SfdyCJoyHkBSr/g80CAGY/JIQYfDjYBEtEwc1 zswlm3VLIm8ckLTsBxUMdt/4ptvvZ7ThwALjD8PiTefjkvnh4kS9ILuj6VQDtBopKXln79 MtOaMEm40ReM00JJzWvoGDfWfIUVSgmXplwtarvcFrHbfYK/v2n2zpwCOZKZlA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Sgcjv2VzYzCkl; Thu, 30 Nov 2023 00:38:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3AU0cB7H051746; Thu, 30 Nov 2023 00:38:11 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3AU0cBHG051743; Thu, 30 Nov 2023 00:38:11 GMT (envelope-from git) Date: Thu, 30 Nov 2023 00:38:11 GMT Message-Id: <202311300038.3AU0cBHG051743@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: b50d8a160880 - stable/14 - net80211: make ieee80211_alloc_node() private List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: b50d8a1608805dce7e1fa213c87c84a8d772d877 Auto-Submitted: auto-generated The branch stable/14 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=b50d8a1608805dce7e1fa213c87c84a8d772d877 commit b50d8a1608805dce7e1fa213c87c84a8d772d877 Author: Bjoern A. Zeeb AuthorDate: 2023-10-02 13:57:45 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-11-30 00:36:56 +0000 net80211: make ieee80211_alloc_node() private Looking through the allocation/free and reference cycle of nodes we have a few (publicly) (almost) unused macros and functions. Start making them private and reducing the amount of entry paths to the same/similar functionality. First is to make ieee80211_alloc_node() static as it is nowhere used in the tree outside this file. Sponsored by: The FreeBSD Foundation (cherry picked from commit db195a523f9bbeb111b621d2c2c7a46d8b921631) --- sys/net80211/ieee80211_node.c | 5 ++++- sys/net80211/ieee80211_node.h | 3 --- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/net80211/ieee80211_node.c b/sys/net80211/ieee80211_node.c index 39b411059cf1..b7cdc5090c96 100644 --- a/sys/net80211/ieee80211_node.c +++ b/sys/net80211/ieee80211_node.c @@ -82,6 +82,9 @@ CTASSERT((IEEE80211_NODE_HASHSIZE & (IEEE80211_NODE_HASHSIZE-1)) == 0); static int ieee80211_sta_join1(struct ieee80211_node *); +static struct ieee80211_node *ieee80211_alloc_node( + struct ieee80211_node_table *, struct ieee80211vap *, + const uint8_t macaddr[IEEE80211_ADDR_LEN]); static struct ieee80211_node *node_alloc(struct ieee80211vap *, const uint8_t [IEEE80211_ADDR_LEN]); static int node_init(struct ieee80211_node *); @@ -1396,7 +1399,7 @@ ieee80211_del_node_nt(struct ieee80211_node_table *nt, ni->ni_table = NULL; } -struct ieee80211_node * +static struct ieee80211_node * ieee80211_alloc_node(struct ieee80211_node_table *nt, struct ieee80211vap *vap, const uint8_t macaddr[IEEE80211_ADDR_LEN]) { diff --git a/sys/net80211/ieee80211_node.h b/sys/net80211/ieee80211_node.h index 7c9ff70bcb71..826ecccb1238 100644 --- a/sys/net80211/ieee80211_node.h +++ b/sys/net80211/ieee80211_node.h @@ -395,9 +395,6 @@ struct ieee80211_node_table { int nt_inact_init; /* initial node inact setting */ }; -struct ieee80211_node *ieee80211_alloc_node(struct ieee80211_node_table *, - struct ieee80211vap *, - const uint8_t macaddr[IEEE80211_ADDR_LEN]); struct ieee80211_node *ieee80211_tmp_node(struct ieee80211vap *, const uint8_t macaddr[IEEE80211_ADDR_LEN]); struct ieee80211_node *ieee80211_dup_bss(struct ieee80211vap *,