From nobody Wed Nov 29 16:38:51 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SgQ4q37cpz52x8R; Wed, 29 Nov 2023 16:38:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SgQ4q2P4Hz3Kr1; Wed, 29 Nov 2023 16:38:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701275931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Jd4TBSdH/ttzcB1+YPspNJFOCQ3a2LNQah14OkGPmHs=; b=VY69vMbnZBRqQsGh3aG+m/7gbzqvC388C69n/bNbwTPrnXM685ebSZg2DihlyFAVHlpfEy kMEVX8Qp5ZDDjvGbzrsSGYOxI8A74IdLFUxMBY2+bFU0Vy2JySgTDCpIyUAIWWN9/cDzM+ yEiBfG/NtQzK3rBwYcx/5oWLY2tXh6kvy5rB0yHDeUbEubkdUJRZjzS4JHfplNM1MU9w1p YDwRtAf8/vMAGQZgzsbcsCrSDXa3RxgkTPzGRJ8Aw4+ruKm1GiM4aXObik80yUlwN0uimV GoUxJO970+lMT0Pzku9k5dr03bO7NzXOj7eTx4IjQb36b0cUjLMQV6StoEc+5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701275931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Jd4TBSdH/ttzcB1+YPspNJFOCQ3a2LNQah14OkGPmHs=; b=uwhoPK+4+JzBxA7NMBtliRD02SiOdouG8jHUm8rXn6USxd5IYnyVCUlwyT88CgoyJyUv4c GCCE1Ia47UtE9X6neftUCAn4/xZiver9G+EbQWPuij6BGLbrqCdur1ehx6Q0VRBx+oNAvx wC65Ix0Uu3TnrszX+pNToTuto1tZuggUvlvcDJ20OQ9KMrlExvoKBPFAHR0niSDvgQDL90 Q300khuLjCO+UdFxhi1j+S9qmw9E14bvdpYr6iu9cD3K1TPv+enJvpjzlDGHp2kWbm2CIJ +niImXKia9/Ys05c58+aGHu9wUIeTuATyOD7dkIAfX36xVjbjKUuXhzjfD6hEQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701275931; a=rsa-sha256; cv=none; b=kYpB2AiwlVp6bkPt4DFvfABJ038AgC+5LZE6wzHYWLG6B4LpoGnhoW29BbzKxzsKT6GCC5 KGHWRARAIMJyE2A4zooPzLm9aF0z/V0NjAXx6cKeqqGzTnVBe8kMyj8e03Jal6c0fEP4YG bsb/5v1cO3dTBMen8/pWZLpSnISAREb/Vnl+N3n8ZSr5F5F6dGI35AJojxbFjRbfPeLEsz FV0LMUXzERGoACf5epevoNoNNwELv1s8lTCd4cYrVP/0ft1ZId5+MqPV4vj2KvzPS/+edE VRAqjmhR7+NHym5gekbexKwdTy15J0WlM6hUlsILQUBwR6PVaHNk4msWh8Ja9A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SgQ4q1FZwz1C4D; Wed, 29 Nov 2023 16:38:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3ATGcp8p046949; Wed, 29 Nov 2023 16:38:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3ATGcprP046946; Wed, 29 Nov 2023 16:38:51 GMT (envelope-from git) Date: Wed, 29 Nov 2023 16:38:51 GMT Message-Id: <202311291638.3ATGcprP046946@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 8a7ba52ba201 - stable/13 - LinuxKPI: 802.11: error on state transition failure List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 8a7ba52ba201d9cc62a501feb8da6eb7f1710274 Auto-Submitted: auto-generated The branch stable/13 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=8a7ba52ba201d9cc62a501feb8da6eb7f1710274 commit 8a7ba52ba201d9cc62a501feb8da6eb7f1710274 Author: Bjoern A. Zeeb AuthorDate: 2023-10-25 22:29:35 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-11-29 16:36:11 +0000 LinuxKPI: 802.11: error on state transition failure The state transition failures we were seeing in the early days are solved. If we now experience one stop processing before passing over to net80211 (sta_newstate()) and before updating iv_state on the vap. Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D42423 (cherry picked from commit 45c27ad5241f5491234afd0b47d13b8005fdb4de) --- sys/compat/linuxkpi/common/src/linux_80211.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index da88a0e7c150..3f0058d639e1 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -2137,12 +2137,11 @@ lkpi_iv_newstate(struct ieee80211vap *vap, enum ieee80211_state nstate, int arg) } if (error != 0) { - /* XXX-BZ currently expected so ignore. */ ic_printf(vap->iv_ic, "%s: error %d during state transition " "%d (%s) -> %d (%s)\n", __func__, error, ostate, ieee80211_state_name[ostate], nstate, ieee80211_state_name[nstate]); - /* return (error); */ + return (error); } #ifdef LINUXKPI_DEBUG_80211