From nobody Wed Nov 29 16:38:49 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SgQ4p3bXDz52wyH; Wed, 29 Nov 2023 16:38:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SgQ4p0xCxz3KqP; Wed, 29 Nov 2023 16:38:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701275930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uLizK+ErfDioiE2ix+CIIKh0Fwi6cq4L+1j119Rb1CM=; b=PZgh0eVZqNj7pLldEBIcbFFAY/wdQgPANzYP6HTxraMxJ2zjBsbY0aYHzCrUXgmDDZD/6j 1OXafYwzorzhzK3Ko/B37fcx27NRr93wSgXO2hQf/al6Va6oNKStCsnQMKOfmeNy5elFvh 6f0s41gAe6bNpYpAOqwgyq6tQIXnZK6o49OD8vRx8bgRR5t7EOYzI8QPyRTS4eZtPm0qTB Bghgo7fYPEYAAAd3WGrG/ZsCR8GI78QvokCl9lsJQFp0Hu12evaKhSEGcURXbPHJR7bJQf jcf/wwOOqu7vORJsEblWPP2qoi1ZSk1OJzgW79a5/xc2dd83hDEftOM3sjolaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701275930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uLizK+ErfDioiE2ix+CIIKh0Fwi6cq4L+1j119Rb1CM=; b=QCWBC6EsC8V8m4WEIYokgzSTcG0uxzVezS0PNwqnfXwS7y2wvgVqgiAm31U1VQ1c5aFRoV 0cjv/ym82CusFDejsDLZnYFMIeI3DPpKOTQwC5fsstY1wiV7062r9mMBvhnJXd/6+jyq+c bDW6tz50agJjUD6n8IK1lbZ/tfflJ+XCtE+ekRvmjYsgwqsxwPTPFmWhQ2hKKntxqBXjVK B/sQGSuEH+gCC9iKskvQV9PQvy85IG/3erXBrl2ppDOXlv0pRdM2ChqKu8Aj7zGHScdsGJ ofxwFPRDTKmCcZ4geD85FzkQatO2k5sjdJCI4XkY/EeAFHiGFOlIUV08PDvmwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701275930; a=rsa-sha256; cv=none; b=wD2oCVaRumyJfu0HiK0XRWQT7cfDOdofUdyvQc/DQkZcyaDaOiTh7KNCInF2bcupBNINcE U7W3CQaaFrNEM+4sUTUxPRN2Q2ft1umOkLCvjjRV0II3O+xbzxK6VZkzYclDs8OPRsUFts Agi+Fef9cT+lbFX2cwAj7I3AUn+HWlRtDWzZZAQ4YeZgqaqiw0HOm04uemIod5ZloB/skW gE/38oHmJbMJ5xligDP7IFBWfDnRHaBMxat4dKQrY9BT/otBhicI4318cBm96CrXlNE85u NOLADRnyNKtibObootdyhsFYlaSXa00aELVKIW+a5I0oPHVn58R4baYhUmUupA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SgQ4p01Stz1Cb4; Wed, 29 Nov 2023 16:38:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3ATGcnTe046890; Wed, 29 Nov 2023 16:38:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3ATGcnoQ046887; Wed, 29 Nov 2023 16:38:49 GMT (envelope-from git) Date: Wed, 29 Nov 2023 16:38:49 GMT Message-Id: <202311291638.3ATGcnoQ046887@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 3cd4af3825b5 - stable/13 - iwlwifi: re-enable "Invalid TXQ id" logging List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 3cd4af3825b564a6bf249b0f8d2e5dd1368ca49a Auto-Submitted: auto-generated The branch stable/13 has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=3cd4af3825b564a6bf249b0f8d2e5dd1368ca49a commit 3cd4af3825b564a6bf249b0f8d2e5dd1368ca49a Author: Bjoern A. Zeeb AuthorDate: 2023-10-09 19:47:39 +0000 Commit: Bjoern A. Zeeb CommitDate: 2023-11-29 16:36:11 +0000 iwlwifi: re-enable "Invalid TXQ id" logging Various reports recently hit the "Invalid TXQ id" in iwlwifi again. Unconditionally enable logging and add a note to report to a specific PR in the log message for now. Along with 018d93ece16b this will hopefully help us to understand what is going on. Sponsored by: The FreeBSD Foundation PR: 274382 (cherry picked from commit ad134f8ab768e3b1d2db203f1cc963bdf0eea857) --- sys/contrib/dev/iwlwifi/mvm/tx.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sys/contrib/dev/iwlwifi/mvm/tx.c b/sys/contrib/dev/iwlwifi/mvm/tx.c index 2407d0ee832e..da33c1a5cc46 100644 --- a/sys/contrib/dev/iwlwifi/mvm/tx.c +++ b/sys/contrib/dev/iwlwifi/mvm/tx.c @@ -1199,9 +1199,10 @@ static int iwl_mvm_tx_mpdu(struct iwl_mvm *mvm, struct sk_buff *skb, if (WARN_ONCE(txq_id == IWL_MVM_INVALID_QUEUE, "Invalid TXQ id")) { #if defined(__FreeBSD__) - IWL_DEBUG_TX(mvm, "fc %#06x tid %u txq_id %u mvm %p " - "skb %p { len %u } info %p sta %p\n", fc, - tid, txq_id, mvm, skb, skb->len, info, sta); + printf("%s:%d: fc %#06x tid %u txq_id %u mvm %p " + "skb %p { len %u } info %p sta %p (if you see this please " + "report to PR 274382)\n", __func__, __LINE__, + fc, tid, txq_id, mvm, skb, skb->len, info, sta); #endif iwl_trans_free_tx_cmd(mvm->trans, dev_cmd); spin_unlock(&mvmsta->lock);