From nobody Mon Nov 27 17:50:14 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SfCm732d7z52BjX; Mon, 27 Nov 2023 17:50:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SfCm670fQz4GgJ; Mon, 27 Nov 2023 17:50:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701107415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EqfXvT7kSEnmJ/CjEEaxo2YIvFSxg5fjTAk7cgYIirQ=; b=om6kPsULrV7x6kNZZw1bAXEGzvG7PdQxVlde6qBO9PG/v/iAB7gwSqDGWLXCDBSgr3r7ZI WUYm5JgO3692ZVhjlce5fy9Bva4JAk8yTmYbzHY4xHXcBOucSZKIhHWIGHzOrb1lUYd5B7 H6ftGX/9Xab+RC2K8lRGaBVGPQDEAO5iFwBJMPN8ofb2UfKse8UbluSee+zu2065MmOGCx UGLeDdrjVz+p+Vwu+MJWVY7MFlVKTzBKDGOny7vUnS4W3qrH63RniKWvUm3QkSGcLcooFJ H3Epi/sCKtkdCCQMNr3n11wl4k+0EeqwRJSkcXb6m+e5NHvRMjoUkZsM3XrIDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701107415; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EqfXvT7kSEnmJ/CjEEaxo2YIvFSxg5fjTAk7cgYIirQ=; b=yvq+xo+1muMvlUSi6soluXpZUm99mMp3OdcC5wHqG0W5ycbTsl2roR75twc+7XrQpPSXrC wqiXg6usZ3XoDxYE/YnfLBLniO2mul1wdcqBMtPQeV0PjG+evnafTFOisiqFErhuLJHUKl 9g2VdxzwYLOddKf5BUUdI9LYHCOOgB/7f2Pqzl2aMYU6z0V6Ii7ExqhJ1f3+RGgON8ZGIm 1VoLBs01CeL3ewHWejiYxCglb/cI2o0p26z45iyYrGWxUO2r76GFd7tJFLQjsa97XNL5Nw eVANuNu3sbN1zgdyeUNNpZK9LjBP+wFfl3umkqbKy6e5tKi5Si7J0EyXVF74nA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701107415; a=rsa-sha256; cv=none; b=aoRUZZHoGJ031rfeX7CdtaG+F/cA/PP3CCSdX7IcxpK/h8plA3CUb4U9XCQw2DKthGHVZh dvwZ/B+yQcmOsf+2tEW1J4t3OlFD2gfCfAzJ7qx2hU7C+MseiUWYdCWPOP2HcshmQ4Wy4G GPE91XTC8+NBBTFaEQZ1bb35LlBb7Pnf8j7VdFrpzFmKShnPC5gNQ/BRzJhj3nyGicfOA0 OHRXgBV+dwgSRb5+jsKDq94bYn13NEqdC/1SWO5BVKDtj/chWyMj6tQuLeQXkM/KVIPhrz TZVFKxAkCx8K5vy++2d4tVfumu703UUSqeYCb6GSEwqP4sKAg3kyEZnbViY3gA== Received: from [IPV6:2601:648:8384:fd00:bc78:e4e1:3e17:3e10] (unknown [IPv6:2601:648:8384:fd00:bc78:e4e1:3e17:3e10]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SfCm63253zxGc; Mon, 27 Nov 2023 17:50:14 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <8d51e8f9-37a0-4f28-bf05-2a58514fddb0@FreeBSD.org> Date: Mon, 27 Nov 2023 09:50:14 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: b88ca6ee167d - main - cdefs: Remove CC_SUPPORTS macros, they are unused Content-Language: en-US To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202311270525.3AR5PHQ2067285@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202311270525.3AR5PHQ2067285@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/26/23 9:25 PM, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=b88ca6ee167d079c965dfe123bbe296d3a945c0a > > commit b88ca6ee167d079c965dfe123bbe296d3a945c0a > Author: Warner Losh > AuthorDate: 2023-11-20 22:40:55 +0000 > Commit: Warner Losh > CommitDate: 2023-11-27 05:24:02 +0000 > > cdefs: Remove CC_SUPPORTS macros, they are unused > > Remove __CC_SUPPORTS_INLINE, __CC_SUPPORTS___INLINE__, > __CC_SUPPORTS___FUNC__, __CC_SUPPORTS_WARNING, > __CC_SUPPORTS_VARADIC_XXX, __CC_SUPPORTS_DYNAMIC_ARRAY_INIT: they are > unused. Also remove them from the generated cryptodevh.py script. > > Retain, for the moment, __CC_SUPPORTS___INLINE, since it's used in this > file. > > PR: 275221 (exp-run) > Sponsored by: Netflix > --- > sys/sys/cdefs.h | 10 ---------- > tests/sys/opencrypto/cryptodevh.py | 7 ------- > 2 files changed, 17 deletions(-) > > diff --git a/sys/sys/cdefs.h b/sys/sys/cdefs.h > index 5782735187c5..7f3efc9300c9 100644 > --- a/sys/sys/cdefs.h > +++ b/sys/sys/cdefs.h > @@ -79,17 +79,7 @@ > */ > #define __compiler_membar() __asm __volatile(" " : : : "memory") > > -/* XXX: if __GNUC__ >= 2: not tested everywhere originally, where replaced */ > -#define __CC_SUPPORTS_INLINE 1 > #define __CC_SUPPORTS___INLINE 1 > -#define __CC_SUPPORTS___INLINE__ 1 > - > -#define __CC_SUPPORTS___FUNC__ 1 > -#define __CC_SUPPORTS_WARNING 1 > - > -#define __CC_SUPPORTS_VARADIC_XXX 1 /* see varargs.h */ > - > -#define __CC_SUPPORTS_DYNAMIC_ARRAY_INIT 1 > > #endif /* __GNUC__ */ > > diff --git a/tests/sys/opencrypto/cryptodevh.py b/tests/sys/opencrypto/cryptodevh.py > index d6982c26f1cf..9607bcd4d115 100644 > --- a/tests/sys/opencrypto/cryptodevh.py > +++ b/tests/sys/opencrypto/cryptodevh.py > @@ -23,13 +23,6 @@ def __has_include(x): return 0 > > def __has_builtin(x): return 0 > > -__CC_SUPPORTS_INLINE = 1 > -__CC_SUPPORTS___INLINE = 1 > -__CC_SUPPORTS___INLINE__ = 1 > -__CC_SUPPORTS___FUNC__ = 1 > -__CC_SUPPORTS_WARNING = 1 > -__CC_SUPPORTS_VARADIC_XXX = 1 > -__CC_SUPPORTS_DYNAMIC_ARRAY_INIT = 1 > def __P(protos): return protos > > def __STRING(x): return #x It doesn't really matter, but you accidentally removed __CC_SUPPORTS___INLINE from the python version but not cdefs.h. I wonder how hard it would be to just regenerate cryptodevh.py rather than updating it manually as I'm sure it is missing some other updates. -- John Baldwin