Re: git: 3fd60a6b73ac - main - awk: Merge upstream 2nd Edition Awk Book

On Wed, Nov 15, 2023 at 9:52 AM Jessica Clarke <jrtc27@freebsd.org> wrote:

> On 14 Nov 2023, at 04:51, Warner Losh <imp@FreeBSD.org> wrote:
> >
> > The branch main has been updated by imp:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=3fd60a6b73ac01a72df89751f173970fae4cae73
> >
> > commit 3fd60a6b73ac01a72df89751f173970fae4cae73
> > Merge: 194df014feeb 2e406c584fe4
> > Author:     Warner Losh <imp@FreeBSD.org>
> > AuthorDate: 2023-11-02 16:32:01 +0000
> > Commit:     Warner Losh <imp@FreeBSD.org>
> > CommitDate: 2023-11-14 04:49:34 +0000
> >
> >    awk: Merge upstream 2nd Edition Awk Book
> >
> >    Merge in the November 2nd, 2023 version of one true awk.
> >
> >    This brings in Unicode support, CSV support and a number of bug fixes.
> >
> >    Sponsored by:           Netflix
> >    Reviewed by:            delphij
> >    Differential Revision:  https://reviews.freebsd.org/D42447
>
> This seems to have broken the GitHub CI for cross-building; contrast:
>
> https://github.com/freebsd/freebsd-src/actions/runs/6859373313
>
> with:
>
> https://github.com/freebsd/freebsd-src/actions/runs/6859316228
>
> Has this broken makeobjops.awk somehow? If so it should be reproducible
> on FreeBSD with BOOTSTRAP_ALL_TOOLS=1, or by rebuilding on an updated
> system. Cross-building will just show it first because we always
> bootstrap awk there, like many other tools.
>

It worked when it was the system awk for me...  But that might not be the
most
helpful observation. Why didn't it work for you/github's ci runs?

makeobjops.awk doesn't have any of the issues that I know are minor changes
in awk. I'll add it to the list of things to look into, though.

I also broke the Jenkins CI run, but not 'make check' for reasons I don't
understand.

Warner