From nobody Tue Nov 14 22:17:03 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SVLJ73xNTz511B5; Tue, 14 Nov 2023 22:17:11 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from glebi.us (glebi.us [162.251.186.162]) by mx1.freebsd.org (Postfix) with ESMTP id 4SVLJ71WY3z3WLm; Tue, 14 Nov 2023 22:17:11 +0000 (UTC) (envelope-from glebius@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: by glebi.us (Postfix, from userid 1000) id ED80555594; Tue, 14 Nov 2023 14:17:03 -0800 (PST) Date: Tue, 14 Nov 2023 14:17:03 -0800 From: Gleb Smirnoff To: "George V. Neville-Neil" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: b2e41172bdc0 - main - A skeleton kernel module suitable for creating new such modules. Message-ID: References: <202311142111.3AELBWJn067834@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202311142111.3AELBWJn067834@gitrepo.freebsd.org> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-Rspamd-Queue-Id: 4SVLJ71WY3z3WLm On Tue, Nov 14, 2023 at 09:11:32PM +0000, George V. Neville-Neil wrote: G> The branch main has been updated by gnn: G> G> URL: https://cgit.FreeBSD.org/src/commit/?id=b2e41172bdc00f177f7de4d4f4963cc4d99a3178 G> G> commit b2e41172bdc00f177f7de4d4f4963cc4d99a3178 G> Author: George V. Neville-Neil G> AuthorDate: 2023-10-05 20:05:31 +0000 G> Commit: George V. Neville-Neil G> CommitDate: 2023-11-14 21:08:13 +0000 G> G> A skeleton kernel module suitable for creating new such modules. G> --- G> share/examples/modules/Makefile | 6 +++ G> share/examples/modules/skel.c | 87 +++++++++++++++++++++++++++++++++++++++++ G> 2 files changed, 93 insertions(+) Are you aware there exists share/examples/kld that already has several kernel module examples? I'm not sure if a very minimal kernel module adds more value to examples, but pretty sure that it belongs to the existing directory instead of a new one. The existing directory is also connected to the build, which makes examples installed. -- Gleb Smirnoff