From nobody Tue May 23 22:03:40 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QQpHT5NrVz4T6P6; Tue, 23 May 2023 22:03:49 +0000 (UTC) (envelope-from steffen@sdaoden.eu) Received: from sdaoden.eu (sdaoden.eu [217.144.132.164]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QQpHT3GSWz44CJ; Tue, 23 May 2023 22:03:49 +0000 (UTC) (envelope-from steffen@sdaoden.eu) Authentication-Results: mx1.freebsd.org; none Date: Wed, 24 May 2023 00:03:40 +0200 Author: Steffen Nurpmeso From: Steffen Nurpmeso To: Li-Wen Hsu Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 7e49aa86a282 - main - ifconfig(8): Teach ifconfig to attach and run itself in a jail Message-ID: <20230523220340._2XnU%steffen@sdaoden.eu> In-Reply-To: <202305232056.34NKuLHU059109@gitrepo.freebsd.org> References: <202305232056.34NKuLHU059109@gitrepo.freebsd.org> Mail-Followup-To: Li-Wen Hsu , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org User-Agent: s-nail v14.9.24-470-g00466668ef OpenPGP: id=EE19E1C1F2F7054F8D3954D8308964B51883A0DD; url=https://ftp.sdaoden.eu/steffen.asc; preference=signencrypt BlahBlahBlah: Any stupid boy can crush a beetle. But all the professors in the world can make no bugs. X-Rspamd-Queue-Id: 4QQpHT3GSWz44CJ X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15987, ipnet:217.144.128.0/20, country:DE] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Hello. Hm, from only looking at the mailed diff, and without real knowledge of getopt(3) (i "always" used my own thing) ... Li-Wen Hsu wrote in <202305232056.34NKuLHU059109@gitrepo.freebsd.org>: ... |URL: https://cgit.FreeBSD.org/src/commit/?id=7e49aa86a2824e76e9d9becf61d\ |b12066bc0d79d | |commit 7e49aa86a2824e76e9d9becf61db12066bc0d79d |Author: Yan Ka Chiu |AuthorDate: 2023-05-23 20:39:22 +0000 |Commit: Li-Wen Hsu |CommitDate: 2023-05-23 20:39:22 +0000 | | ifconfig(8): Teach ifconfig to attach and run itself in a jail ... [cool thing, by the way!] ... |- strlcpy(options, "G:adf:klmnuv", sizeof(options)); |+ strlcpy(options, "G:adf:j:klmnuv", sizeof(options)); ... |+ case 'j': |+#ifdef JAIL |+ if (optarg == NULL) |+ usage(); ... i think for "j:" getopt(3) guarantees 'j' has an argument? |+ args->jail_name = optarg; ... Ciao! --steffen | |Der Kragenbaer, The moon bear, |der holt sich munter he cheerfully and one by one |einen nach dem anderen runter wa.ks himself off |(By Robert Gernhardt) |~~ |..and in spring, hear David Leonard sing.. | |The black bear, The black bear, |blithely holds his own holds himself at leisure |beating it, up and down tossing over his ups and downs with pleasure |~~ |Farewell, dear collar bear