Re: git: 805d759338a2 - main - mlx4: Move DEFINE_MUTEX() outside function body.

On 21 May 2023, at 23:51, Hans Petter Selasky <hselasky@freebsd.org> wrote:
> 
> On 5/22/23 00:32, Jessica Clarke wrote:
>> Once again I will remind you that the FreeBSD tree is not somewhere for you to play around with experiments. Changes should be properly justified.
> 
> Hi Jess,
> 
> This is FreeBSD-current / main and my change is perfectly fine as such. Sorry.

Just because it’s not stable/* or releng/* doesn’t mean you can’t do whatever you want.

> It is not my problem why GIT has to use cryptographic hashes, so that commit messages cannot be changed without forced pushing.

I don’t even want to start up that debate again.

> The justification for this change should be clear from our e-mail exchange.

Your attempt at one is. A justification that I wholeheartedly disagree with, and that you yourself have undermined by stating multiple ways in which you would make it unnecessary.

For the fifth time: revert this patch. Today. Not at some point in the future of your choice when you feel like it.

Jess