Re: git: d198b8774d2c - main - fwget: Introduce new utility
- In reply to: Emmanuel Vadot : "git: d198b8774d2c - main - fwget: Introduce new utility"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 09 May 2023 13:56:38 UTC
On Mon, 1 May 2023, Emmanuel Vadot wrote:
> The branch main has been updated by manu:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=d198b8774d2cfb6f140893e1c6236af9e97d1497
>
> commit d198b8774d2cfb6f140893e1c6236af9e97d1497
> Author: Emmanuel Vadot <manu@FreeBSD.org>
> AuthorDate: 2023-04-26 05:46:20 +0000
> Commit: Emmanuel Vadot <manu@FreeBSD.org>
> CommitDate: 2023-05-01 06:32:59 +0000
>
> fwget: Introduce new utility
>
> This script's goal is to check the system for peripherals that needs
> firmware and install the needed packages for them.
> For now it only support pci subsystem and only video classes for AMD
> and Intel GPUs.
>
> Reviewed by: bapt
> Sponsored by: Beckhoff Automation GmbH & Co. KG
> Differential Revision: https://reviews.freebsd.org/D39825
...
> diff --git a/usr.sbin/fwget/pci/pci_video_intel b/usr.sbin/fwget/pci/pci_video_intel
> new file mode 100644
> index 000000000000..9a20abcdb17a
> --- /dev/null
> +++ b/usr.sbin/fwget/pci/pci_video_intel
...
> +pci_video_intel()
> +{
> + case "$1" in
Based on
% pkg search gpu-firmware-intel
gpu-firmware-intel-kmod-alderlake-20230210_1 Firmware modules for alderlake Intel GPUs
gpu-firmware-intel-kmod-broxton-20230210_1 Firmware modules for broxton Intel GPUs
gpu-firmware-intel-kmod-cannonlake-20230210_1 Firmware modules for cannonlake Intel GPUs
gpu-firmware-intel-kmod-dg1-20230210_1 Firmware modules for dg1 Intel GPUs
gpu-firmware-intel-kmod-elkhartlake-20230210_1 Firmware modules for elkhartlake Intel GPUs
gpu-firmware-intel-kmod-geminilake-20230210_1 Firmware modules for geminilake Intel GPUs
gpu-firmware-intel-kmod-icelake-20230210_1 Firmware modules for icelake Intel GPUs
gpu-firmware-intel-kmod-kabylake-20230210_1 Firmware modules for kabylake Intel GPUs
gpu-firmware-intel-kmod-rocketlake-20230210_1 Firmware modules for rocketlake Intel GPUs
gpu-firmware-intel-kmod-skylake-20230210_1 Firmware modules for skylake Intel GPUs
gpu-firmware-intel-kmod-tigerlake-20230210_1 Firmware modules for tigerlake Intel GPUs
I think a few of them are missing the "-kmod" miiddle bit:
diff --git a/usr.sbin/fwget/pci/pci_video_intel b/usr.sbin/fwget/pci/pci_video_intel
index 9a20abcdb17a..3d37a430c3d2 100644
--- a/usr.sbin/fwget/pci/pci_video_intel
+++ b/usr.sbin/fwget/pci/pci_video_intel
@@ -45,31 +45,31 @@ pci_video_intel()
;;
# Cannonlake
0x5a*)
- echo "gpu-firmware-intel-cannonlake"
+ echo "gpu-firmware-intel-kmod-cannonlake"
;;
# Icelake
0x8a*)
- echo "gpu-firmware-intel-icelake"
+ echo "gpu-firmware-intel-kmod-icelake"
;;
# Elkhartlake/Jasperlake
0x45*|0x4e*)
- echo "gpu-firmware-intel-elkhartlake"
+ echo "gpu-firmware-intel-kmod-elkhartlake"
;;
# Tigerlake
0x9a*)
- echo "gpu-firmware-intel-tigerlake"
+ echo "gpu-firmware-intel-kmod-tigerlake"
;;
# Rocketlake (Uses tigerlake GuC/HuC firmware)
0x4c*)
- echo "gpu-firmware-intel-rocketlake gpu-firmware-intel-tigerlake"
+ echo "gpu-firmware-intel-kmod-rocketlake gpu-firmware-intel-kmod-tigerlake"
;;
# DG1
0x49*)
- echo "gpu-firmware-intel-dg1"
+ echo "gpu-firmware-intel-kmod-dg1"
;;
# Alderlake (Uses tigerlake GuC/HuC firmware)
0x46*)
- echo "gpu-firmware-intel-alderlake gpu-firmware-intel-tigerlake"
+ echo "gpu-firmware-intel-kmod-alderlake gpu-firmware-intel-kmod-tigerlake"
;;
*)
log "No package found for device $1"
--
Bjoern A. Zeeb r15:7