From nobody Mon May 01 14:58:10 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q95tk6Vjdz48dZk; Mon, 1 May 2023 14:58:22 +0000 (UTC) (envelope-from melifaro@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q95tk6198z3l61; Mon, 1 May 2023 14:58:22 +0000 (UTC) (envelope-from melifaro@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682953102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PTRtQNzpkr5FVEddJcLRIWVbwQ1pufCHCEe3U2NipIk=; b=U4K50Nq/zepkRiiVDCCOsCg8OL77G79mMoHxN1owa008Lc6Fl36OsbAFWqSYzwFSQePVMq Kn/VkotdU5BntYmAMf4DYoRvNvEe3dGuiXTcqKOkKVUUVWOxQorn96vQPwnlBafCz2ofge QvJS8lwJxbdUb6ygO8aEhw4MdxjJTySwsIQBLDYC6UvaKg0m46jEi0uzBng1bRih6Im6+s F7U8sddS62Q9Nnh5xGH7kyNiLnfzZKrguxs5YkmqtVR5k30LbrEZh1xrHzuOgyjEU2jjz2 fzB3AtWfDpueE+ahvsLzXyEmZh7YLWXuWzBawdt4lCXrrgw4yt5SCy1+ZcXMzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682953102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PTRtQNzpkr5FVEddJcLRIWVbwQ1pufCHCEe3U2NipIk=; b=LPY3uL8fkK9NqrCMikrZIoxELI8DFz9OQW/CYDow2zBK4WFrYJtUNCqHTh8sc1j+5hscpw gupPYAa41pVg0D9S/KreQLT88mj9QMAli+R5Q2jJw3tsPRyUFGttT5IiVc/ZceWVOuI5fs Fmo3RdjLffhocr8fuAIxZmP+7f5w6SCQDrb9ONMDUIzVxZV2kyiyQuyVtfO9g4tqMEwl4q cqR0IHyw5+/HT33eHEN6OOOwumcz/Lv95imHciLzUCBi2l4rtt+RFkTFDTkBL9ltlDAVED SCL6h+XMNwa7PT3SnnUQm28m2LaNRMMgmwiL7aedxyR5W6slEZtDT8EIY5Cj/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682953102; a=rsa-sha256; cv=none; b=NTJeF6/9uIfv5ZHkpZkVMUgaA3DRBHSe/lXZ+Sqky+0gDsmy83UXqMNvK2ji/tvWbKxGt8 cFyaMHaMsyXVSZchUp1F0UmcHuxNz4Wh9dOnj8rqQ+l5B1/acSaoNXWATAJEi0cRaA0ScX 52o/3DHAjWOxGQVj4KePgbCv49RLPcCZm1MO5ampXrCC7Lp6P9jg832O8Sb59fu4RRO6y0 I39iBMd2DaqGoBV14qrAMe6Et4ahTNvk+qqPc8zSXKhSH9WXBY5Gaq5yeYUONbKoKO/hzP OeAAxV1wIffqL11lGAU4WH+WAAe4pZzBwMvh8PBpjTbkOI5YjLSQIYhy+W35UA== Received: from smtpclient.apple (unknown [IPv6:2a02:8084:d6bb:510:3cee:d979:6270:71a5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: melifaro/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q95tk1NHDzkh8; Mon, 1 May 2023 14:58:22 +0000 (UTC) (envelope-from melifaro@freebsd.org) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: git: 6a09a7f1e9a5 - main - netlink: always zero provided header buffers. From: Alexander Chernikov In-Reply-To: <58128e85-82e3-e529-2d65-1145e6c84c09@FreeBSD.org> Date: Mon, 1 May 2023 15:58:10 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <7CBFB961-B052-4F95-BE04-8865D9B49034@FreeBSD.org> References: <202305011409.341E9wop057673@gitrepo.freebsd.org> <58128e85-82e3-e529-2d65-1145e6c84c09@FreeBSD.org> To: Renato Botelho X-Mailer: Apple Mail (2.3731.400.51.1.1) X-ThisMailContainsUnwantedMimeParts: N > On 1 May 2023, at 15:30, Renato Botelho wrote: >=20 > On 01/05/23 11:09, Alexander V. Chernikov wrote: >> The branch main has been updated by melifaro: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D6a09a7f1e9a52fb25158ca60216c6b81= 7f8c0b71 >> commit 6a09a7f1e9a52fb25158ca60216c6b817f8c0b71 >> Author: Alexander V. Chernikov >> AuthorDate: 2023-05-01 14:07:33 +0000 >> Commit: Alexander V. Chernikov >> CommitDate: 2023-05-01 14:09:47 +0000 >> netlink: always zero provided header buffers. >> Reported by: KMSAN >> MFC after: 3 days >> --- >> sys/netlink/netlink_message_writer.h | 1 + >> sys/netlink/route/neigh.c | 3 --- >> 2 files changed, 1 insertion(+), 3 deletions(-) >> diff --git a/sys/netlink/netlink_message_writer.h = b/sys/netlink/netlink_message_writer.h >> index 57fc1bf342ea..92e43834efc7 100644 >> --- a/sys/netlink/netlink_message_writer.h >> +++ b/sys/netlink/netlink_message_writer.h >> @@ -225,6 +225,7 @@ nlmsg_reserve_data_raw(struct nl_writer *nw, = size_t sz) >> void *data_ptr =3D &nw->data[nw->offset]; >> nw->offset +=3D sz; >> + bzero(data_ptr, sz); >=20 > At first look, this line seems to be indented wrong. But looking at = cgit web interface it seems that other lines are wrong and this is = correct. Ups. Somehow I messed with spaces. Thanks for pointing this out! Should = be fixed by 88406e631e93. /Alexander > --=20 > Renato Botelho >=20