From nobody Thu Mar 30 13:20:07 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PnPD76T2pz41ljV; Thu, 30 Mar 2023 13:20:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PnPD760Dvz3jrT; Thu, 30 Mar 2023 13:20:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680182407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TlssGNtwM4m12dmxSL6N7UhsdY/TRxHS6ERdpa1X3lE=; b=tcbMGr+Ft6FNSIkM+kZOap6nZUn2e51mc1W37UoIXen2KiKdBKevL9/UcgaKd/tjar9g+5 PcN/ZHNZfKDTTpLQ0TYrVl02c6nNvoNaUzC90ySoKD/ihpf1qt3QXWO5tNvmsRAJg2XaHx FA6bwsxXarHc4IW/fl1+DMZbhTb8NtWOu0753TRwUyctPFyjcaKK84yO9KdyucG4z5nw/n pHFPBsTveGI2YZEE7yQuQk71mTxLvQ7BrDGpeWsTPPPki85t+m1BUogyFc9XHJvl74tXCq Lin+cqgAHWNQ6Tm0veYWj6Wq8QGN20SfoJ9KJXDhj5bMECziVjGe/KyGiLVqdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680182407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TlssGNtwM4m12dmxSL6N7UhsdY/TRxHS6ERdpa1X3lE=; b=dZQEZOQt/i33j5FVxffHsVzYUQGdOSl9lB6gl1vge5DoGZRUI6To8oWbZwn6jgqBTSf/MI qlajeGtdTE4ZEfdG+z02N9G07qniqP+MX6MIl7UU05aU29ap1urtwZA3sL8locMR45CZRU 7lca/XwG6jBtJgsWcJ7pQDqd0Ba6C/kug7cRevpJwA1xlgMvpaSTsmgXflevEiIz+WKUnl +V/toR5GRqTjVkS/XaNN3BKdZI0prjFSCRA7SUxAgb51LmrDpS49RngW/HNIfWyDRYXu+f iphv5g4QxHIhrMjLXHswNE3ML2bsW7WvQNFWcM5NJxFZkFH0wt/fmgNJCJQuPA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680182407; a=rsa-sha256; cv=none; b=mfRrq1Wn/c24gqpgkiZGt6g8w+geytOmzSPiovUWzGg6dN+IaYTaPgoAiyckztgW3qMFU/ eiDdJoUIP+uGdnwz0EmLFa7kdPubC+jkOJf0SwdKhgb1dicKXBsKtkzZncDwhiIIK03lfq ZtYPcgVGG40VLJtgzubk8JcTxTXhzMZx47bGhoBvx9SBl8gq4QLVArqHkzWEax65cYUSKM 5/UxV52H8WCILK1g/Ynl+NrcYBc9Jp7hkjjvK5PtrPpWZ6D3dkyyVSR473Iq5Adn6A8hXs 41e6werfL292aexA1YnxxT9yzDIpOGjw9Qm1AcMfr1Kkdb9lNeendJjim/pa/g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PnPD753L3zDd1; Thu, 30 Mar 2023 13:20:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 32UDK77H051575; Thu, 30 Mar 2023 13:20:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 32UDK72b051572; Thu, 30 Mar 2023 13:20:07 GMT (envelope-from git) Date: Thu, 30 Mar 2023 13:20:07 GMT Message-Id: <202303301320.32UDK72b051572@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: cc4adc4c4e47 - main - makefs: remove vestigial '?' cases from top-level getopt(3) loop List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: cc4adc4c4e473d47b687d2ac2757157abd728c81 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=cc4adc4c4e473d47b687d2ac2757157abd728c81 commit cc4adc4c4e473d47b687d2ac2757157abd728c81 Author: Ed Maste AuthorDate: 2023-03-30 01:33:39 +0000 Commit: Ed Maste CommitDate: 2023-03-30 13:20:00 +0000 makefs: remove vestigial '?' cases from top-level getopt(3) loop getopt(3) returns '?' when it encounters a flag not present in the in the optstring or if a flag is missing its option argument. We can handle this case with the "default" failure case with no loss of legibility. Obtained from: OpenBSD makefs.c 1.22 --- usr.sbin/makefs/makefs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/usr.sbin/makefs/makefs.c b/usr.sbin/makefs/makefs.c index 2b97c7643e1a..e775b72fd4bb 100644 --- a/usr.sbin/makefs/makefs.c +++ b/usr.sbin/makefs/makefs.c @@ -273,7 +273,6 @@ main(int argc, char *argv[]) fsoptions.sparse = 1; break; - case '?': default: usage(fstype, &fsoptions); /* NOTREACHED */