Re: git: 61194e9852e6 - main - Add kqueue1() syscall

From: Jessica Clarke <jrtc27_at_freebsd.org>
Date: Tue, 28 Mar 2023 00:07:41 UTC
On 28 Mar 2023, at 00:45, Alan Somers <asomers@freebsd.org> wrote:
> 
> On Mon, Mar 27, 2023 at 4:39 PM Konstantin Belousov <kib@freebsd.org> wrote:
>> 
>> The branch main has been updated by kib:
>> 
>> URL: https://cgit.FreeBSD.org/src/commit/?id=61194e9852e641d1533cd04a5679d6042ff975d3
>> 
>> commit 61194e9852e641d1533cd04a5679d6042ff975d3
>> Author:     Konstantin Belousov <kib@FreeBSD.org>
>> AuthorDate: 2023-03-25 23:39:02 +0000
>> Commit:     Konstantin Belousov <kib@FreeBSD.org>
>> CommitDate: 2023-03-27 23:39:26 +0000
>> 
>>    Add kqueue1() syscall
>> 
>>    It takes the flags argument.  Immediate use is to provide the KQUEUE_CLOEXEC
>>    flag for kqueue(2).
>> 
>>    Reviewed by:    emaste, jhb
>>    Sponsored by:   The FreeBSD Foundation
>>    MFC after:      1 week
>>    Differential revision:  https://reviews.freebsd.org/D39271
> 
> We already have abort2(2), dup2(2), pipe2(2), and thr_kill2(2) that
> are similar to other syscalls but with a flags argument.
> Additionally, Linux has a renameat(2).  But I'm not aware of any
> syscalls named xxx1.  Should we call this new one kqueue2 to follow
> the existing convention?

This was discussed on the linked review.

Jess