From nobody Mon Mar 27 21:09:33 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PllnM1JcGz424Rg; Mon, 27 Mar 2023 21:09:43 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Received: from heemeyer.club (heemeyer.club [195.93.173.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PllnL52LBz3j7K; Mon, 27 Mar 2023 21:09:42 +0000 (UTC) (envelope-from dchagin@heemeyer.club) Authentication-Results: mx1.freebsd.org; none Received: from heemeyer.club (localhost [127.0.0.1]) by heemeyer.club (8.17.1/8.16.1) with ESMTP id 32RL9XDi044155; Tue, 28 Mar 2023 00:09:33 +0300 (MSK) (envelope-from dchagin@heemeyer.club) Received: (from dchagin@localhost) by heemeyer.club (8.17.1/8.16.1/Submit) id 32RL9XGa044154; Tue, 28 Mar 2023 00:09:33 +0300 (MSK) (envelope-from dchagin) Date: Tue, 28 Mar 2023 00:09:33 +0300 From: Dmitry Chagin To: "Alexander V. Chernikov" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: b894193501a7 - main - netlink: fix linux module build w/ netlink. Message-ID: References: <202303271821.32RILYvC048054@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303271821.32RILYvC048054@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4PllnL52LBz3j7K X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:61400, ipnet:195.93.173.0/24, country:RU] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Mon, Mar 27, 2023 at 06:21:34PM +0000, Alexander V. Chernikov wrote: > The branch main has been updated by melifaro: > > URL: https://cgit.FreeBSD.org/src/commit/?id=b894193501a7cb6ce5eed3cf86be5dd773cbbb2d > > commit b894193501a7cb6ce5eed3cf86be5dd773cbbb2d > Author: Alexander V. Chernikov > AuthorDate: 2023-03-27 18:20:38 +0000 > Commit: Alexander V. Chernikov > CommitDate: 2023-03-27 18:21:26 +0000 > > netlink: fix linux module build w/ netlink. > > Reported by: Marek Zarychta > MFC after: 2 weeks > --- > sys/compat/linux/linux_netlink.c | 1 + > sys/modules/linux/Makefile | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/sys/compat/linux/linux_netlink.c b/sys/compat/linux/linux_netlink.c > index 9edfbfc2c031..0e8188d4cdf6 100644 > --- a/sys/compat/linux/linux_netlink.c > +++ b/sys/compat/linux/linux_netlink.c > @@ -30,6 +30,7 @@ __FBSDID("$FreeBSD$"); > > #include "opt_inet.h" > #include "opt_inet6.h" > +#include "opt_netlink.h" > > #include > #include > diff --git a/sys/modules/linux/Makefile b/sys/modules/linux/Makefile > index be2c60a42847..43d7f2c240b8 100644 > --- a/sys/modules/linux/Makefile > +++ b/sys/modules/linux/Makefile > @@ -36,6 +36,7 @@ SRCS= linux${SFX}_dummy_machdep.c \ > linux_vdso.c \ > opt_inet6.h \ > opt_ktrace.h \ > + opt_netlink.h \ > opt_posix.h \ > bus_if.h \ > device_if.h \ Hi, I think this is wrong, and should be near SRCS+= linux_netlink.c and also unconditionally included in the linux_common module