From nobody Thu Mar 23 07:53:27 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PhyJT13K7z411MW for ; Thu, 23 Mar 2023 07:53:29 +0000 (UTC) (envelope-from 010001870d7559be-cfc37253-5a84-4631-b441-9041fcdc1794-000000@amazonses.com) Received: from a8-56.smtp-out.amazonses.com (a8-56.smtp-out.amazonses.com [54.240.8.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4PhyJS1YSrz3r3X for ; Thu, 23 Mar 2023 07:53:28 +0000 (UTC) (envelope-from 010001870d7559be-cfc37253-5a84-4631-b441-9041fcdc1794-000000@amazonses.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=tarsnap.com header.s=ae7m2yrxjw65l2cqdpjxuucyrvy564tn header.b=VUqGR5mf; dkim=pass header.d=amazonses.com header.s=224i4yxa5dv7c2xz3womw6peuasteono header.b=PrrqudBV; spf=pass (mx1.freebsd.org: domain of 010001870d7559be-cfc37253-5a84-4631-b441-9041fcdc1794-000000@amazonses.com designates 54.240.8.56 as permitted sender) smtp.mailfrom=010001870d7559be-cfc37253-5a84-4631-b441-9041fcdc1794-000000@amazonses.com; dmarc=pass (policy=none) header.from=tarsnap.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ae7m2yrxjw65l2cqdpjxuucyrvy564tn; d=tarsnap.com; t=1679558007; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=EONDGMFm0pjOqYQjepe/PTCFAsynLS0SK+pVvxAfiyQ=; b=VUqGR5mfDho7n5ELeO6vX6uKWd5T/TEvYrXZMyYQyK+bVGk6h5It9C/SFQ+d9chi x0k54QB/4uP125k5zJ0m3GEt5GVRh+7ZqesHvXLKqOy1l6/OM7X3SfwQ9VflyVYpiZf cZft6xi7CSM1dLmIbAzmLzvLDm22wHZKfKnd1D90= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1679558007; h=Message-ID:Date:MIME-Version:Subject:To:References:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=EONDGMFm0pjOqYQjepe/PTCFAsynLS0SK+pVvxAfiyQ=; b=PrrqudBVUL0y78W/qfEWoLGjG8vaXPaMWREU9EggS1wsgdp+ysbXVr7D1QdZrDqf AG6sU2NE+Q8uGUGqc1Bx/IKI+JG93vF1ImZkhEgbpHZBxIiwJsNVWorIV87/6s1KLBp zMjS6GJdt5nWzU58uTk0bOXh3WyGj/Rr2PxdHr8k= Message-ID: <010001870d7559be-cfc37253-5a84-4631-b441-9041fcdc1794-000000@email.amazonses.com> Date: Thu, 23 Mar 2023 07:53:27 +0000 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: git: ed52baf51bd1 - main - _endian.h: Include sys/ctypes.h for visibility macros To: Warner Losh , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202303220226.32M2QLoe029463@gitrepo.freebsd.org> Content-Language: en-US From: Colin Percival In-Reply-To: <202303220226.32M2QLoe029463@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-SES-Outgoing: 2023.03.23-54.240.8.56 X-Spamd-Result: default: False [-1.19 / 15.00]; FORGED_MUA_THUNDERBIRD_MSGID_UNKNOWN(2.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.986]; DMARC_POLICY_ALLOW(-0.50)[tarsnap.com,none]; FORGED_SENDER(0.30)[cperciva@tarsnap.com,010001870d7559be-cfc37253-5a84-4631-b441-9041fcdc1794-000000@amazonses.com]; R_DKIM_ALLOW(-0.20)[tarsnap.com:s=ae7m2yrxjw65l2cqdpjxuucyrvy564tn,amazonses.com:s=224i4yxa5dv7c2xz3womw6peuasteono]; R_SPF_ALLOW(-0.20)[+ip4:54.240.0.0/18:c]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_ZERO(0.00)[0]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[54.240.8.56:from]; ASN(0.00)[asn:14618, ipnet:54.240.8.0/21, country:US]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[cperciva@tarsnap.com,010001870d7559be-cfc37253-5a84-4631-b441-9041fcdc1794-000000@amazonses.com]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[54.240.8.56:from]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[tarsnap.com:+,amazonses.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[amazonses.com:dkim] X-Rspamd-Queue-Id: 4PhyJS1YSrz3r3X X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N On 3/21/23 19:26, Warner Losh wrote: > [...] > This had the side effect of sometimes (in the traditional BSD > compliation environment) > #if BYTE_ORDER == LITTLE_ENDIAN > and > #if BYTE_ORDER == BIG_ENDIAN > both being true because none of these were defined. This fixes > that. It also fixes including it after but not before. Would it be worth adding #if LITTLE_ENDIAN == BIG_ENDIAN #error Endian defines are broken! #endif just to ensure that any future issues show up quickly? -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid