From nobody Sat Mar 18 03:46:36 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pdn3z3fd6z40FRr for ; Sat, 18 Mar 2023 03:46:39 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pdn3z0hzHz4SdF for ; Sat, 18 Mar 2023 03:46:39 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f54.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso6161932wmb.0 for ; Fri, 17 Mar 2023 20:46:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679111197; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f9/x3Q/rqxkYos+bpxgSfkfYz6BgHO1A55F4lR2EPMo=; b=KmS/5WpkZ5RaeSo8XSLUsnTIh3v2cztiSI9YyB8WAPoO6mK8LCm+5MVQ6/UDjwmBob U6efXxOruZvKdbktGcA5GcYwb4WMY5b2A1Es9zkEqg1oz9hfaHoZwTNqG8J9kMmuUKKt OM5j1srsFz71YDxz6wE7x2kYVOnlU2IWBPFbkW1AI3A9KrPUfLkXEWRmJ6LHEuwNFcEM wSRgjTEtYE8Y+l2M1IX8IkggEOPUtS6/hs1gruDC3E97cOj6AIIQUaHH60xWzN4fXfgk WMn4WcEmc0KEKi1sFl8i64O3D5qODj9ePn25YjPy0opM/JpYEy+vg2VZZMMyd9ooBUgx t4Rw== X-Gm-Message-State: AO0yUKXz+n6rOQ9M2z6A0tt152UNyu8bJtj5BcwKVyNaXB3Y0zXhG3+P JYHW00vTCMXEMtk+Zqf0mSAUrPm0r2732B/LMscYAw== X-Google-Smtp-Source: AK7set/wbmt/a70fvnhJu2m7LxGZSgrs66ASnjl4BXLKrDkU7Ganqht7uH6u1v27CcBrXi79Yy2r1Q== X-Received: by 2002:a05:600c:4587:b0:3df:e468:17dc with SMTP id r7-20020a05600c458700b003dfe46817dcmr25541033wmo.40.1679111197521; Fri, 17 Mar 2023 20:46:37 -0700 (PDT) Received: from smtpclient.apple (global-5-144.n-2.net.cam.ac.uk. [131.111.5.144]) by smtp.gmail.com with ESMTPSA id r13-20020a05600c2c4d00b003ed2a3eab71sm3573041wmg.31.2023.03.17.20.46.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Mar 2023 20:46:37 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: c5c9d980c4b0 - main - libc/csu: rename ignore_init.c to libc_start1.c From: Jessica Clarke In-Reply-To: <8d3503f3-fd05-5f1c-7470-48cef3c9bd2d@freebsd.org> Date: Sat, 18 Mar 2023 03:46:36 +0000 Cc: Konstantin Belousov , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <137554A7-8067-4E77-96A8-A0B4BF813184@freebsd.org> References: <202303112320.32BNKoJe039514@gitrepo.freebsd.org> <8d3503f3-fd05-5f1c-7470-48cef3c9bd2d@freebsd.org> To: Charlie Li X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4Pdn3z0hzHz4SdF X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 18 Mar 2023, at 03:44, Charlie Li wrote: >=20 > Konstantin Belousov wrote: >> libc/csu: rename ignore_init.c to libc_start1.c >> The current name was a historical curiosity that started = when init array >> support was added, and then the file appeared a convenient place = for the >> addition of the MI common code to csu. It is now referenced by = name in >> single place and the rename is easy, so do it. >> Sponsored by: The FreeBSD Foundation >> MFC after: 3 weeks >> --- >> lib/libc/csu/Makefile.inc | 2 +- >> lib/libc/csu/{ignore_init.c =3D> libc_start1.c} | 0 >> 2 files changed, 1 insertion(+), 1 deletion(-) > Seems like an ABI break. Anything compiled after this but ran on an = earlier-by-revision-but-same __FreeBSD_version complains with 'Undefined = symbol "__libc_start1@FBSD_1.7"' It=E2=80=99s not a break, just new ABI. Same as adding a new function, = just everything automatically uses it. It=E2=80=99s true that __FreeBSD_version needs bumping if it hasn=E2=80=99= t already been though. Jess