From nobody Fri Mar 17 10:29:31 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PdL3H4cB1z3yBWw; Fri, 17 Mar 2023 10:29:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PdL3H3gfFz3GyF; Fri, 17 Mar 2023 10:29:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679048971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3cccghnQ6dK8VYnimsou+sTOzjs6LRa/eRTBwCnfc8A=; b=V0sEeK22Pdd2HCU/cSD+GcQ3YPFT01o9C4UeMFMaq0YiBmjcnO5XQzb/6VUUr/KI5jleIA MVZQBeuu+2xzT6TNLIV5rOfJHx/sHfn/Up0fTIw0HQz1naUzS0oQBiQBF5e6vJ4LzHDK5I so4Zi8tn8kLTa8a5sf86Q8IQuYGLancaASRL4cvWZUmEW3TE2VkCiW4LRN/I22Mw4HUpkQ kFbDUj2GKkV3eQES58wgF5xTJn4Q/xN7ePOF38l7yqnPDOSN1+1iJFrpBbFHy93Um/Vpsw w20qeVPedhB7mj1gv1DJgnBYHAabfRxRrgirX1bOMYMqJ3ZZbNmcsQxLugSU9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679048971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3cccghnQ6dK8VYnimsou+sTOzjs6LRa/eRTBwCnfc8A=; b=mSIgzvFAYT4SANrjz/6GDRFy1d90zJIXCw1xB0JiAlZw4q4VzHIXxMoqWKWGtl30H2YkeN brj+RJIoIIFnG+tiYPtU7MO0/Bs/G5OdJYUiv1boFvKkTS95AUTIfZbHrA2tvjoqF9bqxC /Cfl6p/PE6bQLRyp9Mwbd5jzVXXVdYa/x4TeLKtHSGa9WfQwii00Lol3mYKwC6JyZFLwoQ pGhzZPJl0uYRkp2PQJ6Moi89o3WgDB79nPxC5F/BVp167QDaql4s0n1q0ewcy7U4SgnRNL eEsXVxJtV6ka0b+mTGHbhhKMAfhzZhmZGTpMu5v9Wd8BqGCa+BCc3Tbzy6hhnw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679048971; a=rsa-sha256; cv=none; b=xr08zPOqr6jGsV57vGqVyKz6s3qL+jrzh1xoKMkeNlleiZVWIZ2H7vOytQ+NAPNqgRgUUy +npa3H0MiN1nIWtou+mtSEJkvxwibKm+pK2ysbd8xiW3uwkBxvkOSuMJs8vnM6Hr8y640q tpllaorBH9E061EhVBCHJqDlRTN5Iohp/emle6uwyW43f6Q4vfJXy6e8Pev/om5FpLpuYS wnR/hxhC7nDHI0HA85JQvfZeapp49rUy11umdZzJeDvOgRFyepiQZxDnTJS+42WfLm2p4G fO4mX8fJUirjWnHwoMUCLhJppuW+VSrTHuVDbVhfIPUMJ11qBdPVX0QKfaXs3Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PdL3H2dG2zMjx; Fri, 17 Mar 2023 10:29:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 32HATVOb067484; Fri, 17 Mar 2023 10:29:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 32HATV48067483; Fri, 17 Mar 2023 10:29:31 GMT (envelope-from git) Date: Fri, 17 Mar 2023 10:29:31 GMT Message-Id: <202303171029.32HATV48067483@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: =?utf-8?Q?Corvin=20K=C3=B6hne?= Subject: git: c8b5f347317d - stable/13 - bhyve: don't flush readonly device at blockif_pause List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: corvink X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: c8b5f347317d1d0dca53acf2f40682314ad0b64e Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by corvink: URL: https://cgit.FreeBSD.org/src/commit/?id=c8b5f347317d1d0dca53acf2f40682314ad0b64e commit c8b5f347317d1d0dca53acf2f40682314ad0b64e Author: Vitaliy Gusev AuthorDate: 2023-03-06 11:35:17 +0000 Commit: Corvin Köhne CommitDate: 2023-03-17 10:26:34 +0000 bhyve: don't flush readonly device at blockif_pause Reviewed by: corvink, markj MFC after: 1 week Sponsored by: vStack Differential Revision: https://reviews.freebsd.org/D38855 (cherry picked from commit 5c0a03125988b89610f61a1bb2137b0e29d7cf31) --- usr.sbin/bhyve/block_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/usr.sbin/bhyve/block_if.c b/usr.sbin/bhyve/block_if.c index f2e60f865f78..edf191491de1 100644 --- a/usr.sbin/bhyve/block_if.c +++ b/usr.sbin/bhyve/block_if.c @@ -993,7 +993,7 @@ blockif_pause(struct blockif_ctxt *bc) pthread_cond_wait(&bc->bc_work_done_cond, &bc->bc_mtx); pthread_mutex_unlock(&bc->bc_mtx); - if (blockif_flush_bc(bc)) + if (!bc->bc_rdonly && blockif_flush_bc(bc)) fprintf(stderr, "%s: [WARN] failed to flush backing file.\r\n", __func__); }