From nobody Wed Mar 15 03:45:07 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pbx9f36tLz3xwBg for ; Wed, 15 Mar 2023 03:45:10 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pbx9f1PvXz3JnP for ; Wed, 15 Mar 2023 03:45:10 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wr1-f51.google.com with SMTP id p4so9923340wre.11 for ; Tue, 14 Mar 2023 20:45:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678851908; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nob9k0Ubbu7TQ4Ba2ooQDoi4qYVkkV8AjgHpUSbe6e0=; b=LRJSJxbMXj5a0tAIZ669dAZovVsI8/ZytLVeQ/+Qso6NTIiOpS/bccO4RRbeHFDeJu PMHKgCic3XyvSu9l83Z58grCmP4LtDT76AKZxiS7V/oEeAUI2g+SskzI+B9ueoe3b49w 2fVDoH0yxnxbc5JXSlj1AlGItq7II9vMa10djhQflH57YDf8aZkzRLvKkgF036lm3EMr RizzBTJAtUt2V0fnssBku7+Zb2fl2A3Mrb88WSg0vWXAUsG3pumAvX7k1Oy52AGfG92x Z4/YIpnNMzEo49vexjZgp6qSW13td0h0vZL7A8w1keVnyu4xf5Zj+5Nc7wFVrM4QHylt 3m4Q== X-Gm-Message-State: AO0yUKXmBkTj2Uk/hM//RziXwoPZZFPp0/eXUiU/K3t7iPOtbh6OWzpO YtUISrg4bvZqj2C55cZuCdxV5A== X-Google-Smtp-Source: AK7set/oM5Wjy91yLURogGhLtuU3QX77uJun+VM+u4ixbvAjuH2GKc05HrR6c1mgeCFiZto4O5P0RQ== X-Received: by 2002:a5d:4524:0:b0:2ce:a652:2399 with SMTP id j4-20020a5d4524000000b002cea6522399mr750014wra.14.1678851908474; Tue, 14 Mar 2023 20:45:08 -0700 (PDT) Received: from smtpclient.apple (global-5-144.n-2.net.cam.ac.uk. [131.111.5.144]) by smtp.gmail.com with ESMTPSA id t18-20020a5d42d2000000b002ceb7a11eb9sm3472070wrr.42.2023.03.14.20.45.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2023 20:45:07 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: 44357c18ccb9 - main - ppp: Remove trailing semicolon From: Jessica Clarke In-Reply-To: <202303150239.32F2dj2H060188@gitrepo.freebsd.org> Date: Wed, 15 Mar 2023 03:45:07 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <27233978-E3A2-46BD-A2A9-BA1854833129@freebsd.org> References: <202303150239.32F2dj2H060188@gitrepo.freebsd.org> To: Warner Losh X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Rspamd-Queue-Id: 4Pbx9f1PvXz3JnP X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 15 Mar 2023, at 02:39, Warner Losh wrote: >=20 > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D44357c18ccb9df24a925d43ccc467f65= b9ed6bc6 >=20 > commit 44357c18ccb9df24a925d43ccc467f65b9ed6bc6 > Author: Elyes Haouas > AuthorDate: 2023-03-15 02:09:16 +0000 > Commit: Warner Losh > CommitDate: 2023-03-15 02:39:34 +0000 >=20 > ppp: Remove trailing semicolon >=20 > Signed-off-by: Elyes Haouas > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/654 > --- > usr.sbin/ppp/ncp.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/usr.sbin/ppp/ncp.h b/usr.sbin/ppp/ncp.h > index 70b00a422310..806c943a891e 100644 > --- a/usr.sbin/ppp/ncp.h > +++ b/usr.sbin/ppp/ncp.h > @@ -96,8 +96,8 @@ extern void ncp2initial(struct ncp *); > ncp_ClearUrgentPorts(&(ncp)->cfg.urgent.tcp) > #define ncp_ClearUrgentUdpPorts(ncp) \ > ncp_ClearUrgentPorts(&(ncp)->cfg.urgent.udp) > -#define ncp_ClearUrgentTOS(ncp) (ncp)->cfg.urgent.tos =3D 0; > -#define ncp_SetUrgentTOS(ncp) (ncp)->cfg.urgent.tos =3D 1; > +#define ncp_ClearUrgentTOS(ncp) (ncp)->cfg.urgent.tos =3D 0 > +#define ncp_SetUrgentTOS(ncp) (ncp)->cfg.urgent.tos =3D 1 do { ... } while (0)? Jess >=20 > #ifndef NOINET6 > #define isncp(proto) ((proto) =3D=3D PROTO_IPCP || (proto) =3D=3D = PROTO_IPV6CP)