From nobody Tue Mar 14 04:22:30 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PbL3L2LJ4z3xfmx; Tue, 14 Mar 2023 04:22:38 +0000 (UTC) (envelope-from weh@microsoft.com) Received: from HK2P15301CU002.outbound.protection.outlook.com (mail-eastasiaazlp170100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:c400::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PbL3K4nQJz46dx; Tue, 14 Mar 2023 04:22:37 +0000 (UTC) (envelope-from weh@microsoft.com) Authentication-Results: mx1.freebsd.org; none ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bf6iPqpTET2Ojlti2lR01vkUHa+BDTT30FHmS0koRab1VelXfXs+cTyQBpdr/jBrtAJxVtXX8EWAyl71rzyqnCteFl/yeEXfZp7w+HasIJajbQW5gBSSU1ejO0Gd77pksKkG4ljkXtLI6qE3kIXsZl6gme/xGjxfoargI3dE7suAqBwsPiFlM1viyYljPk7UMqWxQ77kdTOQSki35q1JBfm7pgeMxdwmzymcYu7mTMTdD0PGQfxz69s4EsJUFTaANcLsulMC6ri2wIK4bIZE99USwNimIchIY6kx5fq9PLnn7OSJorFmr7SjxYBgB9EFScaScOX/IVNRHPX2227MsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lYDrUOZzjuj39Qw/xQYLI07HkGfqV0wBu6m4OKwmOlc=; b=IOJKDI8TMXjoIKACGwRJJVoBFVupIGUTi0m3LjbdkXDYFdFAXrfJPghzYRtNtDLL9QN8dwRa4QqaxLduz9FLJ3L5bm0pwytKGHUzgS6ZfpGANcVt6Eht1B7sVLlkYYZ656D2rDtf2DrF9hPHSs5Kw/m46U2evXgebHB6HgyltQGvRci9b80XN6w5+d5ivoOp9dgNKByTjC/hldppHNWzekCnTs4ZNfmlOjjUsaG/nvG1MyRlRhTXeAxeH9tqeyfZ0wQb/0n38dH9dggvEfG727fS1Si0/Hh4RC0Hl2DyVAFMxMobHaLRxfLws0ds99Yl2MS3WSjf/tOSFixoPyH1nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYDrUOZzjuj39Qw/xQYLI07HkGfqV0wBu6m4OKwmOlc=; b=dgFP7TpuFB0hIB89i72Fk3g3Jh11k9xyhPj6pdV3XSi7u2od5tCfaOh22WVzwK6N0/f/NAUoBg3ipHnB3YOFluV4WcivtWttgEwqkAHxvfO4ztwPUNxAtrGVVg+VfkB+KbdmB7RTWfHyLe7OJxtWD2BRLDe2UHnrNmQKtHRPmfk= Received: from SI2P153MB0441.APCP153.PROD.OUTLOOK.COM (2603:1096:4:fc::7) by PSAP153MB0391.APCP153.PROD.OUTLOOK.COM (2603:1096:301:2a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.5; Tue, 14 Mar 2023 04:22:31 +0000 Received: from SI2P153MB0441.APCP153.PROD.OUTLOOK.COM ([fe80::a485:7ae4:263d:c862]) by SI2P153MB0441.APCP153.PROD.OUTLOOK.COM ([fe80::a485:7ae4:263d:c862%6]) with mapi id 15.20.6222.005; Tue, 14 Mar 2023 04:22:31 +0000 From: Wei Hu To: Jessica Clarke , Wei Hu CC: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: RE: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and Mellanox driver modules into build Thread-Topic: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and Mellanox driver modules into build Thread-Index: AQHZVVf8e0xpclVc8EGc2s8MLWSZgK75p3KAgAACAACAAAF/kA== Date: Tue, 14 Mar 2023 04:22:30 +0000 Message-ID: References: <202303130300.32D30Q0K068420@gitrepo.freebsd.org> <4F72E2FD-6E84-40F1-981D-A18C8DE22FDD@freebsd.org> In-Reply-To: <4F72E2FD-6E84-40F1-981D-A18C8DE22FDD@freebsd.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=d18e3401-e597-43c3-92ed-a033a1e15a5d;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2023-03-14T04:09:47Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SI2P153MB0441:EE_|PSAP153MB0391:EE_ x-ms-office365-filtering-correlation-id: ad72703a-370f-46cb-8324-08db2443ba54 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ShkLwzmjGWP47pa+vjpjZKLQE9G8oHpjzTvrS+L414yPP3pWeUKeO4SKTafMW8RHEHHJ4fuA8bROvYVjvf/uWXIzvu7kbkaCJFK6Usue/slVt/cIB2mtavqWOLG0j9kve5YymWDe5ZXj2ha7Zq6RQ4EHdsaurFqje6VNjsv/ILm6C0gm1Jt6ogFPHJP7AE4/yFf3Grt9MyTuKkasnLl1+eQeCxZ3KaGuaxCnvEI0KVovkaGI2/7/mqRKgP4hdzmZbnYIXSkEd2T5YU/CAgVQDArzl5ycHzpQ2pVY9Uyb6hP0o5zS4s8SX/gJA+jj4zCKKnAq93BKrPhsfUPzOcXRT7w3s8c4JqNvMPEFUoTeZdj8foam86TQ+Eyi/ZBvooTe2H0bUhya6KYr2mRais8LiinyH+2DJZP/sF251XFBzEOoqc/MAicSahUPiCHelA3pITITuZAwFFPWACEq75e9o44u01sbVOZiSJHjA89zKayUBKL08fSzC6iQrUvcNjNBXPUlz4f8nXV78rtppj6RVtcy51EyGVgfc3kBp9KxZNhR/r0K+prtGv4caD8DHGgNIdhnJni/D2gWD/0iSgBdWUK0BkW/g643pivmqaRAqzd4uxYG5n7Loj0ES+mL848v59JU62r/m9M68lK6McUlJGdsSN+OVLnP+f4/gP91xGsOxB4NfIYbHzjzMsY7U9IcKW1UedZPWlv+t+aTLWq8BTABiBxHOLa9V8riX8iNCgq0hjsehbdrE79fymy7JM1c x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2P153MB0441.APCP153.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(376002)(396003)(39860400002)(136003)(346002)(451199018)(82960400001)(186003)(2906002)(38070700005)(38100700002)(8990500004)(122000001)(9686003)(6506007)(82950400001)(26005)(53546011)(5660300002)(8936002)(52536014)(41300700001)(33656002)(966005)(86362001)(450100002)(66556008)(66946007)(55016003)(64756008)(66476007)(66446008)(4326008)(8676002)(76116006)(71200400001)(478600001)(316002)(110136005)(7696005)(54906003)(83380400001)(10290500003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jXwyA5fDDThdN0SXFCQ2Jc72MADX1/foCh+7Im9/tE190VP8W6MdVw1zkIcr?= =?us-ascii?Q?xcB/G8SgsTnkI7/+FfJPo8EX/W2V2RLUUx90wiDtbxzFf576nSu2BzUu+blb?= =?us-ascii?Q?GRpKCUxyjY4aiPvmlth4I7hqJvJa2pXHZpEdWNUiINmdjo9ziCxECk55z9up?= =?us-ascii?Q?eQWWqfNO0GWih42VI/9rXRzop54OGzA75plX1HzcN2hPt8OyLQjjJcVTjGcj?= =?us-ascii?Q?7S2SxqLbkl6Ubv6nKFzd+nJviTbHnzmKG2QBbu0wYXvvBWBUhF466ExHRyh+?= =?us-ascii?Q?XuiL3BrKJKBGmZus40LQ2CgVu5dIc4uEhFVoqTmrNIKM7hG9DVqWmOLK3hRV?= =?us-ascii?Q?zGq+fLnL4myBYFDv92Ub8M/qKY5XGuCeYCG6YhADUhMWR4jcIUDsQ65n3e4i?= =?us-ascii?Q?5g7eMUmQA8j/WprgMmjgc0HCZXF6XEfozm66xKCTUdgOCK+qZL6bc1nMrMSC?= =?us-ascii?Q?A9FeF9GXFNcAAuy8x7MrDFnm+18xLSnL5Tq/ZAaHNvpm7GQYDJB2Akhjcv7W?= =?us-ascii?Q?1kX1IHZZapJL1k3XC506lUBByEetZqk3QBisF/kwkYFTbqi97fnrUN/SavRK?= =?us-ascii?Q?p3260p5n44fyFJylpjeiJRgwWvoMqLKWUo6EWDM/EIi8AmEkmUF5jV8a9bg+?= =?us-ascii?Q?ywVblqJTb7uBGjquVfxIaEvdKO0dqKIibjwsT5bx6oTqQhmWRuM1t3pb5CJZ?= =?us-ascii?Q?BdtOmh4SsNEwPunNrFib7bthtQkxiE7wSl/DKOJQ5eVG16Oc8aBWetmMk+Xa?= =?us-ascii?Q?AXIMJryrYs4wX2EtlOBBmbVNab6XrJ9Y4Q/N7+8WSdiautpMpf7StHdvRvvQ?= =?us-ascii?Q?4o21mcWXLIZTtdH5vbAODLo0c/wAfAQdvkIHT7E67fD+WOb2aDq8KaQxdnbL?= =?us-ascii?Q?Gb2YBErzCdAhXxgw1NN92LMKR8+Hv2MqnqwlfVZQMlrA0OgN7PDas9cz9CYa?= =?us-ascii?Q?d07Ogla9Ik+Y2LWIwb55DdNuq6+a9yY/5ENPJChYvpn1HR6KGjeQQg+CKjbO?= =?us-ascii?Q?tGLysFEKCoWE9mBA9RnmpfjUzAQpMVPCZ4TJJLPFUOyFmjUZyyl3HtYVqezG?= =?us-ascii?Q?xHTPTCW6CkWTktcKGc/1/S71uLWe4NqvyhRr4MOoEQyAMwVLyF5zBgfaibOF?= =?us-ascii?Q?s74FBRAZKYbPPdPfM0gT0QM2jKSDdi8GRKoftGbEylBua2KxdqB5W1sgvMVl?= =?us-ascii?Q?5JLtPWZ1QR00mQZlCrbAgsMeCgl/MdBveYzUh4tQ9e7LaKGJdrc2v9URct1c?= =?us-ascii?Q?KIZOCluFGn5+oG6W8fbKkc/ApX9RNUygM4mbQK0n3EOIWtBEx44X8I7Ph4Nd?= =?us-ascii?Q?dozHLw+RjfeVt9bBcLJTsaQ6kN4RnCD8Ka1YPzy5Lv0IrSat1opGYSr/aTIY?= =?us-ascii?Q?ZEOQGx75x5MxhB3dSz+uH5J+6GdTFSneqUXX48/yOsMK66pAUWPcluaVI70o?= =?us-ascii?Q?5dgp+2AeQ876aKuL/stcku3FjudvDzubVfOy3AGLyCCKK+mI5VeO9LF81S0D?= =?us-ascii?Q?xWihL5L/6YD7CPabJ498q40lEtEWPGS15Rd3QUaonYkBuTloLHlNHlMVZURD?= =?us-ascii?Q?IzV+x2he/ihc1rkrnjhNJiU2jvTh+QseK0lzIltV?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SI2P153MB0441.APCP153.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: ad72703a-370f-46cb-8324-08db2443ba54 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2023 04:22:30.9998 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v1oK9HLyt6PLppevMu0St6+ALOJP9SA3zyXTvPJDlG+T1CfuGw9i1AvelHLgSu2ufwO9DteTBX1pCe+jM491Hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAP153MB0391 X-Rspamd-Queue-Id: 4PbL3K4nQJz46dx X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:8075, ipnet:2a01:111:f000::/36, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N > -----Original Message----- > From: Jessica Clarke > Sent: Tuesday, March 14, 2023 12:04 PM > To: Wei Hu > Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org; dev- > commits-src-main@freebsd.org > Subject: Re: git: 15e7fa83ef3c - main - arm64: Hyper-V: Add vPCI and > Mellanox driver modules into build >=20 > On 14 Mar 2023, at 03:57, Jessica Clarke wrote: > > > > On 13 Mar 2023, at 03:00, Wei Hu wrote: > >> > >> The branch main has been updated by whu: > >> > >> URL: > >> > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fcgi > >> > t.freebsd.org%2Fsrc%2Fcommit%2F%3Fid%3D15e7fa83ef3cd909e1d1b3b2ca > da8d > >> > 9073f2e22e&data=3D05%7C01%7Cweh%40microsoft.com%7Ce49561fcb0054db > 78cfc0 > >> > 8db244136f1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6381436 > 34775 > >> > 142011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2 > luMzIiLC > >> > JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DNe98uGxwYg > CfWaRPct > >> 8KCG%2FBEcwSf0HmjmcuW7Rx0FU%3D&reserved=3D0 > >> > >> commit 15e7fa83ef3cd909e1d1b3b2cada8d9073f2e22e > >> Author: Wei Hu > >> AuthorDate: 2023-03-13 02:55:04 +0000 > >> Commit: Wei Hu > >> CommitDate: 2023-03-13 02:55:04 +0000 > >> > >> arm64: Hyper-V: Add vPCI and Mellanox driver modules into build > > > > What does Mellanox have to do with Hyper-V? I doubt it's being emulated= . >=20 > I guess because Azure Accelerated Networking has Mellanox hardware. In > which case it doesn't belong in std.hyperv, it belongs in std.azure, as > std.hyperv is for things needed for Hyper-V, not platforms that happen to > use Hyper-V. Hyper-V supports SRIOV devices. For now Mellanox NICs is the only NIC type = supported. Mellanox drivers were not included in the ARM64 build. We have tested it on= Hyper-V=20 during the ARM64 for Hyper-V enablement effort, with Hyper-V VPCI driver. = We have not tested it on the other ARM64 platforms. It should work not only in Azur= e, but also in on-prem ARM64 Hyper-V hosts.=20 It's better to move Mellanox drivers to more general build location once th= ey are tested on more ARM64 platforms. Wei >=20 > Jess >=20 > >> These changes in conf and std.hyperv files got missed in previous co= mmit. > >> Reviewed by: whu > >> Tested by: whu > >> Obtained from: Souradeep Chakrabarti > >> Sponsored by: Microsoft > >> Differential Revision: > >> > https://nam06.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Frev > >> > iews.freebsd.org%2FD38529&data=3D05%7C01%7Cweh%40microsoft.com%7C > e49561 > >> > fcb0054db78cfc08db244136f1%7C72f988bf86f141af91ab2d7cd011db47%7C1% > 7C0 > >> %7C638143634775142011%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w > LjAwMDAiLCJ > >> > QIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdat > a=3DYu% > >> 2BY%2FyEVCjC6dj8UKY6pYeVy%2BAsgxar5DBC9XQlexYo%3D&reserved=3D0 > >> --- > >> sys/arm64/conf/std.hyperv | 12 +++++++++++- > >> sys/conf/files.arm64 | 1 + > >> 2 files changed, 12 insertions(+), 1 deletion(-) > >> > >> diff --git a/sys/arm64/conf/std.hyperv b/sys/arm64/conf/std.hyperv > >> index f87082f15c96..b742c75da131 100644 > >> --- a/sys/arm64/conf/std.hyperv > >> +++ b/sys/arm64/conf/std.hyperv > >> @@ -3,4 +3,14 @@ > >> # > >> > >> #hyper-v support > >> -device hyperv > >> +device hyperv > >> + > >> +options COMPAT_LINUXKPI > >> +device xz > >> + > >> +device mlx5 > >> +device mlxfw > >> +device mlx5en > >> +options RATELIMIT > >> +options KERN_TLS > >> +device firmware > >> diff --git a/sys/conf/files.arm64 b/sys/conf/files.arm64 index > >> 684cb8cb23ba..22dd267b2b42 100644 > >> --- a/sys/conf/files.arm64 > >> +++ b/sys/conf/files.arm64 > >> @@ -253,6 +253,7 @@ dev/hyperv/utilities/hv_kvp.c > optional hyperv acpi > >> dev/hyperv/netvsc/hn_nvs.c optional hyperv acpi > >> dev/hyperv/netvsc/hn_rndis.c optional hyperv acpi > >> dev/hyperv/netvsc/if_hn.c optional hyperv acpi > >> +dev/hyperv/pcib/vmbus_pcib.c optional hyperv pci > acpi > >> > >> dev/ice/if_ice_iflib.c optional ice pci \ > >> compile-with "${NORMAL_C} -I$S/dev/ice" > >