From nobody Thu Mar 09 17:00:13 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PXb615dPJz3x869; Thu, 9 Mar 2023 17:00:25 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PXb615C6Mz4BxF; Thu, 9 Mar 2023 17:00:25 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678381225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkcYw3Jp0PfeSvfVKie1n4UmNs21aqjd33gZqfAqnmU=; b=VA1ha3zY9vNZJyp7yH+LdIlco4WckZXlY3Gt8BrDN0CJ7yhuSHJ6VdtgZke95oZAqJue6H WrDy0NUEpaH32qtS5zFeRRlCkQi1f6XKPxtNPrXHhfAWUY2k30Efejjr+anXYpxW3oE+Za C4HJpSzX7ubnWEr4DJSuCddPb7LbTRJ7Q/oOB67UXUjNUiaT8HaIMa8vPawwTwMQgBOyfy AhVQLzzC5shgoWt+hoQHRL02zDKg7BHy+w+S9o4p0QtUo1iSHEMUUZh6nO0kuXJDmDFbaB 3btErRaFaXPigJSArT51hemUMk3RETDKVk+dL+vAZaW9mOk/H8aO7U8TYirTeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678381225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkcYw3Jp0PfeSvfVKie1n4UmNs21aqjd33gZqfAqnmU=; b=Oy/HAdiTQKxOzWZbZdD0u4Cn0//GVQovRjcnif/6evdvIZSmLrZVq+WtxI4IO3PuEPBWpl Z17lBJ++VuMueKwU0StejUYNEJ2jsF8/21ywcaXgeaSTLYHHpxxnPV7jYhlvDv7J6AySOd Ncwvu3Vf+u/k86TkMFeBl1bZKdLFJE3eWPZKnPZqMfOl0yH5k33eeZGems/sLZmPcq8VXG BMAdjfOOfUCe3Hpw1TZXfYtw0Up8ycZfAVvRJGulYTduqnSUHEJYHJI7rultbhz2Iydk+X 0h1zKwJgacL1JjRrX3KE9eRap5/Z2ZwLqWlkB9R565dbqseQIwzKaIhhO7AHcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678381225; a=rsa-sha256; cv=none; b=NpaF9V/wY74rybh0ocHGKCOR6XLBY9cTOuWxmuPb8QG8xHMj/iF5b6Vqow2UmaPB8W4MZ+ 8X7pwD7MKuelHRBzFUyxkT+kVgh7U8gaY+KIx2IU2GXBg+RKPpygN26/C64OijgFrcEODn ETyqLOq3boDOeNQceLwocPnr/13iKi70FWOh8iuiHWY2hmGjrTflYxLmMIdHek25DIXx78 p5UVvcoilJzsHmcOENnx7uxeprxEx9rdzMznEnq61nMJAGrkTGuuBPAFkL9oXHojE9EHCJ /pBTDMi/fHlGki3b68L1KdyZYVdMYiR9o2PrZ81KyEgYmoN6Un8Vt+euCMjgNQ== Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PXb61477lzYTq; Thu, 9 Mar 2023 17:00:25 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f171.google.com with SMTP id bl39so985388qkb.10; Thu, 09 Mar 2023 09:00:25 -0800 (PST) X-Gm-Message-State: AO0yUKVZ4tKjtQmdmfcqqxDa21AEfyB8J74Y3WTHJJDyXwIUVMaOcd+L BtaKsW8Af8nq54qMxa18qOQLpIanzDXn0bGsXY8= X-Google-Smtp-Source: AK7set9Yxrw8DugP6Gq0zuo/8AbRyRrEdHQGRFE51tMP0TwFXsHhcqVVFz1Hcmhib6j5P/HXPhcmwkRAlPeDu4euPMY= X-Received: by 2002:a37:5cf:0:b0:71f:b8e9:3631 with SMTP id 198-20020a3705cf000000b0071fb8e93631mr6388463qkf.13.1678381224885; Thu, 09 Mar 2023 09:00:24 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202303091643.329GhNWr046904@gitrepo.freebsd.org> In-Reply-To: <202303091643.329GhNWr046904@gitrepo.freebsd.org> From: Kyle Evans Date: Thu, 9 Mar 2023 11:00:13 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: b2654064c2d1 - main - pkg(7): use libmd for sha256 instead of openssl To: Baptiste Daroussin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N On Thu, Mar 9, 2023 at 10:43=E2=80=AFAM Baptiste Daroussin wrote: > > The branch main has been updated by bapt: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3Db2654064c2d11a1ee36667b3ff= 8b0f4d2536af74 > > commit b2654064c2d11a1ee36667b3ff8b0f4d2536af74 > Author: Baptiste Daroussin > AuthorDate: 2023-03-09 16:38:30 +0000 > Commit: Baptiste Daroussin > CommitDate: 2023-03-09 16:43:01 +0000 > > pkg(7): use libmd for sha256 instead of openssl > > OpenSSL 3.0 has deprecated the sha256 api, let's use libmd which has = the > same API instead. > > In order to avoid the collision in definitions (sha256.h cannot be > included in the same file as a file where openssl headers has been > included) let's move the sha256 related code in its own file > > PR: 270023 > Reported by: ngie > --- If we're going to link against libmd anyways, any reason to keep these implementations vs using the provided SHA256_Data and SHA256_Fd? Thanks, Kyle Evans