From nobody Mon Mar 06 21:22:42 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PVs4244rGz3wPrk; Mon, 6 Mar 2023 21:22:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PVs423P4fz3DBv; Mon, 6 Mar 2023 21:22:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678137762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OFPP/g1Z9BnnltOtBxS3A1QaYI+rz9s2Vl3IyXTZuEA=; b=hPpxJO4sIVbGJcsIwE1ZiS2ZRFFUBrrqoJ7Sx793pjpYt6bc1Nd0mdNvcvjvVd5mSaS5w6 F2rvgjap9Ai8PFuwintG0RzzQo5gF9GdvVbCQGIP3oAV5Dea4Ha0RzqoETeekDY4Lk38hH MvK6lX0dVBW87p+1OWC0/QTxZG8JKZ5+SHhbfm4HaCpjAWiFW9YqxoFMlo9bQ5JoeSWYgY C0Z+l+lKhR6hkoGKE0Rok6TdoqQvrwWzWnRZylmTmAdyXTIOs8tJNLmFDrunQB1+adQ9yG OSRpddy1I9F3oZI7cjp6GhV4iaG2ZN/bD8+5DXfyyC2Ad8v+lnKp5+I1U1GYLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678137762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OFPP/g1Z9BnnltOtBxS3A1QaYI+rz9s2Vl3IyXTZuEA=; b=vPuM4yvRYDUkh0nGTAgVkGCudj7UNwlnDrzV5p8P7dXjE9I0d73ijMbjLtzSB/Us7hS/Z7 4LeIZChFag9VYq5JzU+Ijfy3LPSzoRP4VgpYHlRsEMmF0VMlhvDMepT5f+on79UWBbv8Wm kxyG3H4QTpBV9UHO5XdIYcB4OGafkC3OozQcVDC+nWYyXm/EJz9ubBkL+SHNMWZtWKDSV1 zOGJohj/vQzp9qUmkhPDt4ER/XOagoRJtJBtrm674UxJIh2CibInCnGJMbIqJdO1nk7TUI LwuEkdjRqMyHmnfAAExa5NFXruk4kuTHlQiF76x/mCPRCPLMvhJFOQfFIMKKMA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678137762; a=rsa-sha256; cv=none; b=r1/pifJL+mx02dZ0WDXkLfBtoa4KPlTuKaNIvMbR/nLfpJ5Hjjn0vweN+nKzrhg7qB/1ku P+1kJJhw4O0fOf6O8ogTiUpvAAd0xOlnu/xDEBw9Q8LDjhwOD0LY3t7ixdTlR529OTc+W1 FPfpNdVHeemn5SHaR+u83/nMHG/MaJ7tHkAtdvEswvwxNkKuDjS8rEtjjkbpSnj/XDjzTB 4Lbyq3dDlN5SjkNVhLJ+x2F6S3IH2WtbdP7ArrKrxgGqOCCGhMZYVv89SOjFg3m6YovIja EvRYoQemOjrtkXF2GnCGFVQkMnXzY3Hq4OLRF8AsxUnnEtZQSbfzoLmY4oRjhw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PVs422MytzHnt; Mon, 6 Mar 2023 21:22:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 326LMgsk000336; Mon, 6 Mar 2023 21:22:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 326LMgOO000335; Mon, 6 Mar 2023 21:22:42 GMT (envelope-from git) Date: Mon, 6 Mar 2023 21:22:42 GMT Message-Id: <202303062122.326LMgOO000335@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Brooks Davis Subject: git: a338a96efa45 - stable/12 - NgATM: deprecate List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: a338a96efa459df9ed5afe78947425003b8ef2e6 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=a338a96efa459df9ed5afe78947425003b8ef2e6 commit a338a96efa459df9ed5afe78947425003b8ef2e6 Author: Brooks Davis AuthorDate: 2023-03-03 16:20:18 +0000 Commit: Brooks Davis CommitDate: 2023-03-06 18:57:30 +0000 NgATM: deprecate Support for ATM NICs was removed prior to FreeBSD 12. At the time it was unclear if this code was still useful without it. Now the time has come to finish removing support. Add DREPRECATION NOTICEs to the manpages and gone_in(14, ...) warnings in the constructors (or module init for ngatmbase). MFC after: 3 days Relnotes: yes Reviewed by: manu, emaste Differential Revision: https://reviews.freebsd.org/D38877 (cherry picked from commit 211c302f10d76fc12e50c87039cfc06aa9e659c1) --- share/man/man4/ng_ccatm.4 | 7 ++++++- share/man/man4/ng_sscfu.4 | 7 ++++++- share/man/man4/ng_sscop.4 | 7 ++++++- share/man/man4/ng_uni.4 | 7 ++++++- share/man/man4/ngatmbase.4 | 7 ++++++- sys/netgraph/atm/ccatm/ng_ccatm.c | 2 ++ sys/netgraph/atm/ngatmbase.c | 2 ++ sys/netgraph/atm/sscfu/ng_sscfu.c | 2 ++ sys/netgraph/atm/sscop/ng_sscop.c | 2 ++ sys/netgraph/atm/uni/ng_uni.c | 2 ++ 10 files changed, 40 insertions(+), 5 deletions(-) diff --git a/share/man/man4/ng_ccatm.4 b/share/man/man4/ng_ccatm.4 index 3d6778fa25d5..02a5a5f011b5 100644 --- a/share/man/man4/ng_ccatm.4 +++ b/share/man/man4/ng_ccatm.4 @@ -31,7 +31,7 @@ .\" .\" $FreeBSD$ .\" -.Dd March 10, 2005 +.Dd March 3, 2023 .Dt NG_CCATM 4 .Os .Sh NAME @@ -47,6 +47,11 @@ .In netgraph.h .In netgraph/ng_uni.h .In netgraph/ng_ccatm.h +.Sh DEPRECATION NOTICE +.Nm +is deprecated and may not be available in +.Fx 14.0 +and later. .Sh DESCRIPTION The .Nm diff --git a/share/man/man4/ng_sscfu.4 b/share/man/man4/ng_sscfu.4 index 2c444dacd589..6011deaeb2b3 100644 --- a/share/man/man4/ng_sscfu.4 +++ b/share/man/man4/ng_sscfu.4 @@ -30,7 +30,7 @@ .\" .\" ng_sscfu(4) man page .\" -.Dd October 24, 2003 +.Dd March 3, 2023 .Dt NG_SSCFU 4 .Os .Sh NAME @@ -40,6 +40,11 @@ .In netnatm/saal/sscopdef.h .In netnatm/saal/sscfudef.h .In netgraph/atm/ng_sscfu.h +.Sh DEPRECATION NOTICE +.Nm +is deprecated and may not be available in +.Fx 14.0 +and later. .Sh DESCRIPTION The .Nm sscfu diff --git a/share/man/man4/ng_sscop.4 b/share/man/man4/ng_sscop.4 index c98a43462581..451edcc4aebf 100644 --- a/share/man/man4/ng_sscop.4 +++ b/share/man/man4/ng_sscop.4 @@ -30,7 +30,7 @@ .\" .\" ng_sscop(4) man page .\" -.Dd October 24, 2003 +.Dd March 3, 2023 .Dt NG_SSCOP 4 .Os .Sh NAME @@ -39,6 +39,11 @@ .Sh SYNOPSIS .In netnatm/saal/sscopdef.h .In netgraph/atm/ng_sscop.h +.Sh DEPRECATION NOTICE +.Nm +is deprecated and may not be available in +.Fx 14.0 +and later. .Sh DESCRIPTION The .Nm sscop diff --git a/share/man/man4/ng_uni.4 b/share/man/man4/ng_uni.4 index da7028b0e015..993119d23c70 100644 --- a/share/man/man4/ng_uni.4 +++ b/share/man/man4/ng_uni.4 @@ -28,7 +28,7 @@ .\" .\" $FreeBSD$ .\" -.Dd October 6, 2003 +.Dd March 3, 2023 .Dt NG_UNI 4 .Os .Sh NAME @@ -38,6 +38,11 @@ .In netnatm/msg/unistruct.h .In netnatm/sig/unidef.h .In netgraph/atm/ng_uni.h +.Sh DEPRECATION NOTICE +.Nm +is deprecated and may not be available in +.Fx 14.0 +and later. .Sh DESCRIPTION The .Nm uni diff --git a/share/man/man4/ngatmbase.4 b/share/man/man4/ngatmbase.4 index 0227b44347bd..6cdc3eb532fc 100644 --- a/share/man/man4/ngatmbase.4 +++ b/share/man/man4/ngatmbase.4 @@ -30,9 +30,14 @@ .\" .\" ngatmbase(4) man page .\" -.Dd August 24, 2004 +.Dd March 3, 2023 .Dt NGATMBASE 4 .Os +.Sh DEPRECATION NOTICE +.Nm +is deprecated and may not be available in +.Fx 14.0 +and later. .Sh NAME .Nm ngatmbase .Nd netgraph ATM utility module diff --git a/sys/netgraph/atm/ccatm/ng_ccatm.c b/sys/netgraph/atm/ccatm/ng_ccatm.c index cc3f7519289f..c52d392034c5 100644 --- a/sys/netgraph/atm/ccatm/ng_ccatm.c +++ b/sys/netgraph/atm/ccatm/ng_ccatm.c @@ -348,6 +348,8 @@ ng_ccatm_constructor(node_p node) { struct ccnode *priv; + gone_in(14, "ng_ccatm: netgraph ATM modules"); + priv = malloc(sizeof(*priv), M_NG_CCATM, M_WAITOK | M_ZERO); priv->node = node; diff --git a/sys/netgraph/atm/ngatmbase.c b/sys/netgraph/atm/ngatmbase.c index 058fbfa677e4..de46aaedd1a5 100644 --- a/sys/netgraph/atm/ngatmbase.c +++ b/sys/netgraph/atm/ngatmbase.c @@ -77,6 +77,8 @@ static struct mtx ngatm_unilist_mtx; static void uni_msg_init(void) { + gone_in(14, "ngatmbase: netgraph ATM modules"); + mtx_init(&ngatm_unilist_mtx, "netgraph UNI msg header lists", NULL, MTX_DEF); } diff --git a/sys/netgraph/atm/sscfu/ng_sscfu.c b/sys/netgraph/atm/sscfu/ng_sscfu.c index 9036e7740ab6..20e473801142 100644 --- a/sys/netgraph/atm/sscfu/ng_sscfu.c +++ b/sys/netgraph/atm/sscfu/ng_sscfu.c @@ -540,6 +540,8 @@ ng_sscfu_constructor(node_p node) { struct priv *priv; + gone_in(14, "ng_sscfu: netgraph ATM modules"); + priv = malloc(sizeof(*priv), M_NG_SSCFU, M_WAITOK | M_ZERO); if ((priv->sscf = sscfu_create(node, &sscfu_funcs)) == NULL) { diff --git a/sys/netgraph/atm/sscop/ng_sscop.c b/sys/netgraph/atm/sscop/ng_sscop.c index 67a3f07efd83..820e63113e02 100644 --- a/sys/netgraph/atm/sscop/ng_sscop.c +++ b/sys/netgraph/atm/sscop/ng_sscop.c @@ -246,6 +246,8 @@ ng_sscop_constructor(node_p node) { struct priv *p; + gone_in(14, "ng_sscop: netgraph ATM modules"); + p = malloc(sizeof(*p), M_NG_SSCOP, M_WAITOK | M_ZERO); if ((p->sscop = sscop_create(node, &sscop_funcs)) == NULL) { diff --git a/sys/netgraph/atm/uni/ng_uni.c b/sys/netgraph/atm/uni/ng_uni.c index d3adad5ac9e4..67d19d238859 100644 --- a/sys/netgraph/atm/uni/ng_uni.c +++ b/sys/netgraph/atm/uni/ng_uni.c @@ -225,6 +225,8 @@ ng_uni_constructor(node_p node) { struct priv *priv; + gone_in(14, "ng_uni: netgraph ATM modules"); + priv = malloc(sizeof(*priv), M_NG_UNI, M_WAITOK | M_ZERO); if ((priv->uni = uni_create(node, &uni_funcs)) == NULL) {