From nobody Mon Mar 06 13:05:30 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PVf2M0d2Tz3wspj; Mon, 6 Mar 2023 13:05:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PVf2M03MTz3Gvn; Mon, 6 Mar 2023 13:05:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678107931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1wnnDP/Q2yLd8b2mUj8YJYvAI/dNXYAmtBWyLNsIPdQ=; b=QaCr8+9Tql4N/XnFiIuZmUxl6Jpcb8p2i5mb4Jz6kQ+buatuFXzHDGy/ZOftWmQlXG7Ejb TvvThBGoNnzvmAbJinh336eBVOSWZia+0ucVOrFgNZOqpp/epM2/ke3Adm7GRdQQBP5S4X RAEUye6pppx1GcxWghpXnlRMC0TEtQ5ECz5dSzxnyW/Vqu1Fzi1DaRP/aX5uOVdbiuAAVS NM20Y+ePyqhfEeV41E03fwG0EIYlUr/AvMotpaV1XatPRzLPQCtohjszMrliSezziwjE8P SF1zC0hf50mcr4AG/FM98cc//+qV94UPJtUAgQ8fq53xAWs+Uqn2RYBcoAPuzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1678107931; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1wnnDP/Q2yLd8b2mUj8YJYvAI/dNXYAmtBWyLNsIPdQ=; b=dqVGTPkZx2rwwXSDyBDnTvW39yWYMWfdtWsjFjFB3BLZK3zPq1zjWmFrqggq/dYB1V0Jxx QjZz1+GTRGjzBPGYxvfhLj0gQysu5zBDE83glH0BLGFoPRrwpDPKo/Rc8fOl09rk5Tk/Ym YUu0eQIC5aj9sxSIQue0zH+vyvsRugEAXC7KE+hcAy+cAIScPZl84Nnb0iTEv6Y23RtEiN gx7jBFBkaKCliC4PA0eqgJktDc8BkwZUsar6irslOMcTw1EZMxxP1Atmdkk9xlwoXFClM/ CquPYTfVCj8T0IiU/820CRd4q81RL9D0YH+PvHegDRdXEFrCdyCGsO1yiHZgAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1678107931; a=rsa-sha256; cv=none; b=Tbccs1aOWeq6IL0nMnOdQ5E7NsMSJvqlhcQrI/t+1iy390hWD0zPAYFPYjxoNElQjmuXfC dmQqqPbF8+DFD1dR5Oxn2OX7DU11o0rvEBh9fM9SeSXuqJKu7kWXVwEqoxE3TStadqHQzN 2asFuc7Y/GHJTrWZ6oegcH95/x9GD5IspU/ZdvzfhhSWOsvC8QB3HttlvQHGa2p7e++ZHI YEdPlzpTFWD5FVLbtn7g56+fft1TnuzfDkjvf8Tie45v6+kNuiKK46LeG9qfhh7XOgqVJ9 yk7hwp8K41GVhbKA96fXy13X0LFhDhTaAyLx9s3gK//uPGBp7bCe+DgiwBvIAw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PVf2L6FHXz12Mw; Mon, 6 Mar 2023 13:05:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 326D5UKQ079494; Mon, 6 Mar 2023 13:05:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 326D5UcL079493; Mon, 6 Mar 2023 13:05:30 GMT (envelope-from git) Date: Mon, 6 Mar 2023 13:05:30 GMT Message-Id: <202303061305.326D5UcL079493@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: =?utf-8?Q?Corvin=20K=C3=B6hne?= Subject: git: d213429e42d4 - main - bhyve: exit with EX_OSERR if init checkpoint or restore time failed List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: corvink X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d213429e42d48c7de56baf60befd5d953654d337 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by corvink: URL: https://cgit.FreeBSD.org/src/commit/?id=d213429e42d48c7de56baf60befd5d953654d337 commit d213429e42d48c7de56baf60befd5d953654d337 Author: Vitaliy Gusev AuthorDate: 2023-03-06 12:30:54 +0000 Commit: Corvin Köhne CommitDate: 2023-03-06 13:04:16 +0000 bhyve: exit with EX_OSERR if init checkpoint or restore time failed Reviewed by: corvink, markj MFC after: 1 week Sponsored by: vStack Differential Revision: https://reviews.freebsd.org/D38872 --- usr.sbin/bhyve/bhyverun.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/usr.sbin/bhyve/bhyverun.c b/usr.sbin/bhyve/bhyverun.c index 2c1fee23cc13..0c4aef70b2a9 100644 --- a/usr.sbin/bhyve/bhyverun.c +++ b/usr.sbin/bhyve/bhyverun.c @@ -1579,12 +1579,13 @@ main(int argc, char *argv[]) /* * checkpointing thread for communication with bhyvectl */ - if (init_checkpoint_thread(ctx) < 0) - printf("Failed to start checkpoint thread!\r\n"); + if (init_checkpoint_thread(ctx) != 0) + errx(EX_OSERR, "Failed to start checkpoint thread"); if (restore_file != NULL) { destroy_restore_state(&rstate); - vm_restore_time(ctx); + if (vm_restore_time(ctx) < 0) + err(EX_OSERR, "Unable to restore time"); for (int i = 0; i < guest_ncpus; i++) { if (i == BSP)