From nobody Thu Mar 02 04:28:07 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRylC33myz3vp1B; Thu, 2 Mar 2023 04:28:07 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRylC2B03z4GS1; Thu, 2 Mar 2023 04:28:07 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677731287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z8P82lc6xivGvWUvR7ILCWESk7bp0/SkD2vvViLorsg=; b=vLtak7eVsWKmp2U8MGY9iScKxBlxPPrgql1ON0/r2mGg5FR7bPKUTbKBvg/inLCkKFd3Mv RYB0JVgI6c9ch9XdB7g8yCARrrlPqWCj3klmPtJ3DW3yRlcespVzkRpRM1cXtDrTnG2NI/ oJbrOQg3ayztLbqM2aMwTDQKx+B2XXFYtP5D5/VLmPdUFm6VaEQYcu9RBW+EdhUAQ6d/ZB Saz3IKlthqhuGLusCdPV0HxJALY8kxXTi2RXDJjpisFLz+BoFPHjYzlCSPgSzLEt70pdwK Fj8poYdLgHkrh+nOjJISz3K+zWfdpdLVRGO94WmEBHeV9HBgtWFBxIIzA0tt8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677731287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Z8P82lc6xivGvWUvR7ILCWESk7bp0/SkD2vvViLorsg=; b=ihUkWkjKpSiS7vOCX0A8Hll3WKL/46YACYGte86UviLwSrrk+d/Md5W3O9AQk1sDFVYg3w WpIaPkKrWdsxybGDVgvYdE7F3tszpWWjXBxXgtMKwiEbCcyyzTvzO+xw++rJMDy/Wju0gu 56rEW4i0OEErLqPIVH8iwtIOCTdbk4EaNOiJKpkEiaWJlylarKrcSis67z/NP43NzAsTBo KLpTspQ7v8cl6kK1i9y+aA7VsXLxXFjaXXMWURXr6WcrlXR3e3ipj7N0G+jL8GXu81Y3h2 J0iNU4szxM1aTofC7u2pN/4qSXdRwjw8FUz5PPyiKr435q0sKcQdNylnzWT7YQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677731287; a=rsa-sha256; cv=none; b=apiYZcsgQLD7B/GulyhOMeAeyoapeFUv3l8ABszvGZLDgXh3xOIzZCeqOV8l4xiByLPcUG fiUe9efd8291qxMxSMOwUuAOYBjmAdda8Zi+VSLXkd8uK9IN6+nhEpRH3uUow7w3ys7FL9 YTUq0+8cW9H/XRyFQWVA2QQZVAGIJkigR1XETjigaf0GbkEDNuf+enov1KBT93hscC1vnf cfVB4A7hGu233uN55vV8Z9SdDyvdHrp48dSpSwfzG9qTFxlYytkWdmnMO6PZKezPZaBpWj +VSK1qRgY4Rwk9AWaMthvrDWxSeuRIPPJYoH5MY0xtRwz3qaaZzvBoSCYFsPYg== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 2A385C8F8; Thu, 2 Mar 2023 04:28:07 +0000 (UTC) Date: Thu, 2 Mar 2023 04:28:07 +0000 From: Alexey Dokuchaev To: Kyle Evans Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 6b4ef4b16a69 - main - daemon: use braces with 'if' consistently Message-ID: References: <202303020300.32230wHb032429@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202303020300.32230wHb032429@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Thu, Mar 02, 2023 at 03:00:58AM +0000, Kyle Evans wrote: > commit 6b4ef4b16a6930d91d0d99c4ceb75cd43a7526c1 > > daemon: use braces with 'if' consistently > [...] > ... > diff --git a/usr.sbin/daemon/daemon.c b/usr.sbin/daemon/daemon.c > index edcdf3141fcc..f9c1f73e193c 100644 > --- a/usr.sbin/daemon/daemon.c > +++ b/usr.sbin/daemon/daemon.c > @@ -173,14 +173,16 @@ main(int argc, char *argv[]) > break; > case 'l': > logfac = get_log_mapping(optarg, facilitynames); > - if (logfac == -1) > + if (logfac == -1) { > errx(5, "unrecognized syslog facility"); > + } Not only that I don't quite understand how does this commit really improve anything, but looks like it's badly formatted as well. ./danfe