From nobody Thu Mar 02 03:10:00 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PRx146KjFz3vkFQ; Thu, 2 Mar 2023 03:10:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PRx145nbGz4897; Thu, 2 Mar 2023 03:10:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677726600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rtYrzJJ4NNn7PO5RS0rGIRcf2gYUpcAFC71tpiVyHKE=; b=fQ5O+tvrBfMWmvDe5e1kMweNxEXoW44kFXvFsCiObEq/X89Cqy4AqJxBEFxECwMxsd6+jT GWGV3nG7GJ5Cw84WX9uotbGic6HqngMxfzRkzMOV1b96zyz/Y3LmQswkDViR3qOcOvci/a zARKdfHKeDkCKXqav/92MktnQfsS3S5bWGU39nraCW5TD2Qpx6i/ezs7I8xNV3V8n7Vj3o ZVitud1FsWYI/HoeCpd2cG6ffyDi6BELF/Z2pprD6aK2LmPZHy0yURhLTvT/XMGmSj03sj 2MDTC9qkHscuSqSfwB+x3usIN6A/KI8WCv0dblGeQ9MOKeRA2MyRieb8nxLL2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1677726600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rtYrzJJ4NNn7PO5RS0rGIRcf2gYUpcAFC71tpiVyHKE=; b=a5NH3XQOZbRGEvNGYHg3EA1F2JrivUlnMUpcuzXZ+NPXPr3N8H1M9OihwKqjrzIh+wbg3B qWODtRFDd5sEErQ6Cys76EUreulXh8awv/HTwUw5ZbWUD1rjlaFZwGCKRmPWryCOxTt3Hw yKVVlbIlwuSiksRQ5OqjFhiOb+dEZc39jAybFS7AnVHcOgFvIRFLd6CP2mfGPo2X4PJJA9 iNV4nS4Lo6PN79NGyrnRv9OKdSlnxxW+BMsluyXab4lWkHnkMeFWR1QGghODpc2R24JQaM nozBkdd/V4WscDnjV4n8y8X24RGzYfkDOt1Q9Run89vrbBz6AzUPqfRrioajEA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1677726600; a=rsa-sha256; cv=none; b=iwqOlDObLBtaO/shSQBPyjnDbRlRxeu+UtSPB6C6VUHSiSJzB3xu62NXBFOBZHzaa4Tfhu ZF9TR+QGnOBlNcRL+UbrKmboojhvQCIW438ghJODE69moOrb0+EHfGXa4bphVy7u1/lXjS J3jqvWr4rdRIs7IUvHRTvjsSe/a+IVq3Q+opTkK0hN1o33P/x2Q8mTAJee3G+5JRcjqK5o eFlvO74zDQGPcYoJQG+NKryEdvXzQMsJ3qA6GnOnqv3XzNk3cib6nOiO7fQNwOhMUjasEG tBiNv6Ib/Pj89djTxWIdSd/3Os2z8GhhMs5dzvBPkNldshhFXr4C8jCvVO2Jtw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PRx144r84z10j0; Thu, 2 Mar 2023 03:10:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 3223A0l3041225; Thu, 2 Mar 2023 03:10:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 3223A0Wm041199; Thu, 2 Mar 2023 03:10:00 GMT (envelope-from git) Date: Thu, 2 Mar 2023 03:10:00 GMT Message-Id: <202303020310.3223A0Wm041199@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 43fd77233cd4 - stable/13 - ssh: default VerifyHostKeyDNS to no, following upstream List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 43fd77233cd49061839cfdd936cfeba53e9855c3 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=43fd77233cd49061839cfdd936cfeba53e9855c3 commit 43fd77233cd49061839cfdd936cfeba53e9855c3 Author: Ed Maste AuthorDate: 2023-02-17 01:26:41 +0000 Commit: Ed Maste CommitDate: 2023-03-02 03:09:45 +0000 ssh: default VerifyHostKeyDNS to no, following upstream Revert to upstream's default. Using VerifyHostKeyDNS may depend on a trusted nameserver and network path. This reverts commit 83c6a5242c80160fff76fb85454938761645b0c4. Reported by: David Leadbeater, G-Research Reviewed by: gordon Relnotes: Yes Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D38648 (cherry picked from commit 41ff5ea22cb95deb9e7415510eb2f5f00b91537a) --- crypto/openssh/FREEBSD-upgrade | 1 - crypto/openssh/readconf.c | 6 ------ crypto/openssh/ssh_config | 1 - crypto/openssh/ssh_config.5 | 5 +---- 4 files changed, 1 insertion(+), 12 deletions(-) diff --git a/crypto/openssh/FREEBSD-upgrade b/crypto/openssh/FREEBSD-upgrade index c8603577a2a2..17161df93316 100644 --- a/crypto/openssh/FREEBSD-upgrade +++ b/crypto/openssh/FREEBSD-upgrade @@ -136,7 +136,6 @@ We've modified some configuration defaults in ssh: - CheckHostIP defaults to "no". - - VerifyHostKeyDNS defaults to "yes" if built with LDNS. - VersionAddendum defaults to "FreeBSD-YYYYMMDD". 3) Canonic host names diff --git a/crypto/openssh/readconf.c b/crypto/openssh/readconf.c index 3440d05e4e3b..52c9c47c6879 100644 --- a/crypto/openssh/readconf.c +++ b/crypto/openssh/readconf.c @@ -2611,14 +2611,8 @@ fill_default_options(Options * options) options->rekey_limit = 0; if (options->rekey_interval == -1) options->rekey_interval = 0; -#if HAVE_LDNS - if (options->verify_host_key_dns == -1) - /* automatically trust a verified SSHFP record */ - options->verify_host_key_dns = 1; -#else if (options->verify_host_key_dns == -1) options->verify_host_key_dns = 0; -#endif if (options->server_alive_interval == -1) options->server_alive_interval = 0; if (options->server_alive_count_max == -1) diff --git a/crypto/openssh/ssh_config b/crypto/openssh/ssh_config index 7c7ad542e4ef..2dee303a128e 100644 --- a/crypto/openssh/ssh_config +++ b/crypto/openssh/ssh_config @@ -44,5 +44,4 @@ # ProxyCommand ssh -q -W %h:%p gateway.example.com # RekeyLimit 1G 1h # UserKnownHostsFile ~/.ssh/known_hosts.d/%k -# VerifyHostKeyDNS yes # VersionAddendum FreeBSD-20220415 diff --git a/crypto/openssh/ssh_config.5 b/crypto/openssh/ssh_config.5 index b642c5a6b17a..d783ea6ff835 100644 --- a/crypto/openssh/ssh_config.5 +++ b/crypto/openssh/ssh_config.5 @@ -1994,10 +1994,7 @@ need to confirm new host keys according to the .Cm StrictHostKeyChecking option. The default is -.Cm yes -if compiled with LDNS and -.Cm no -otherwise. +.Cm no . .Pp See also .Sx VERIFYING HOST KEYS