From nobody Fri Jun 30 22:40:42 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qt9Kd5ZMQz4klcb; Fri, 30 Jun 2023 22:41:41 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0a-00273201.pphosted.com (mx0a-00273201.pphosted.com [208.84.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qt9Kc6S8zz4JKr; Fri, 30 Jun 2023 22:41:40 +0000 (UTC) (envelope-from sjg@juniper.net) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=juniper.net header.s=PPS1017 header.b=f4y9sxtJ; dkim=pass header.d=juniper.net header.s=selector1 header.b=VU+wlUyE; spf=pass (mx1.freebsd.org: domain of sjg@juniper.net designates 208.84.65.16 as permitted sender) smtp.mailfrom=sjg@juniper.net; dmarc=pass (policy=reject) header.from=juniper.net; arc=pass ("microsoft.com:s=arcselector9901:i=1") Received: from pps.filterd (m0108156.ppops.net [127.0.0.1]) by mx0a-00273201.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35UH7D7F015626; Fri, 30 Jun 2023 15:41:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=to : cc : subject : in-reply-to : references : from : mime-version : content-type : content-id : date : message-id; s=PPS1017; bh=DyaztIYunED/v8FbbQFzSEwhNHIU9+EngeBEu8oP7ew=; b=f4y9sxtJ0Rk6NUhBfvqwR/3FxvV0Sd/s6ddkevFL892y+44IzaDPbjPaYXQKYZe/N4ZF JziwzC92T+pkDy6qolNQyxg1y6Iv5J468GC+zIuSi2jFtSxJQPI+tKSgYtiJCCAxYOAC 6zZX6j440tCerVgCkU7qEr9GJaXduz7y7TcOyGbXvsh9xIk7a0AJrHYMhqBP9jrMJrzT vwdOKW8xz/M3AhDZqLNwyc4fMq1b3NdvII53pp03kOOIakCAF4qZyyeq0krSv6Q/4UTQ 4dp0BKGCsh/gv5cRwqZ5YYdaFIo4R47ryM1ZzW+H70wOr+/lDb3DXqfNfV8YYk5LVTcO Iw== Received: from bl0pr02cu006.outbound.protection.outlook.com (mail-eastusazlp17013034.outbound.protection.outlook.com [40.93.11.34]) by mx0a-00273201.pphosted.com (PPS) with ESMTPS id 3rhvj1se8p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 30 Jun 2023 15:41:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XO3vCos66EtsCpMW3lhUvt26ffys+Q2VRqyesB7ygqtu5Fs/FeGNTGjU+wE5BDFVkBAAGjxVSEirurxJ7E41W7+5F7/vv3X4IJYsUoaTmG9srjjvgEdyb5v/fvVf8D/OC7ZKFRDw+6WE5F0z/cl1ZatEkF02YlydYOBMpIDBPGR6FafwWk6RGhh37mUYQl1OrAys4Id03JuxDBmruREa/eI6T/CsDYpM7SWy41ceAkGG61xoi5quhZ4TxcIK4XMGyT1we3aavzX7vqdyo+uXnNLAxbLRZIp4TcKclF7uE9nbsiosHoWB8SSAFgpCWzLVOSL+lSfz3l3ePNey79ZEPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DyaztIYunED/v8FbbQFzSEwhNHIU9+EngeBEu8oP7ew=; b=hktbnU5Ib8WodDuyEKKMvHq5wIv3XuF35t7CsEsCioorZp3XtNLGAUoc2818Mh/NJQML1NMYAKhiuj14br5lqw4UkH409WFaVDLcC2jGKCh5xyd/roAk4I8xw8KacG0EcDzeTr22Q9TlcON1T4ZuGtqzq3lP0EP/+OniDSG9pUWItUUuN4EAT/e3pQ4lPkhMmGiYM2398921uOcNvwvUKECi81cR7eMj4OG5fdK5RmFPDHXjtvU9TqVon79oymn3ODGpmeMJfOspj4QRZ2Fq3UpfXsTQvglTaA7zVpyntu7CDbxOqOOGDi9RuxREqhIxIyNdhbzKHg1QNlPLyzet0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.14) smtp.rcpttodomain=gmail.com smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DyaztIYunED/v8FbbQFzSEwhNHIU9+EngeBEu8oP7ew=; b=VU+wlUyEvOsMyZV5Y3dn9Rf/UttY7LbJHeNJCR6DCb1zoPEOukRRGzeGjKquRcPyXL2PfDOTu7H/Qy23+rUCBV80t3Wz8607rTZ/t97rS6gBe3Yda2DlqjbPdL1PcjXVHnGcFp0unFHZqPFDeP5ZzinxvG1R5Yb7dUmmqM4XqVI= Received: from BYAPR03CA0019.namprd03.prod.outlook.com (2603:10b6:a02:a8::32) by CO1PR05MB7909.namprd05.prod.outlook.com (2603:10b6:303:db::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun 2023 22:41:11 +0000 Received: from DM6NAM12FT076.eop-nam12.prod.protection.outlook.com (2603:10b6:a02:a8:cafe::62) by BYAPR03CA0019.outlook.office365.com (2603:10b6:a02:a8::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Fri, 30 Jun 2023 22:41:11 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 66.129.239.14) smtp.mailfrom=juniper.net; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.14 as permitted sender) Received: from p-exchfe-eqx-01.jnpr.net (66.129.239.14) by DM6NAM12FT076.mail.protection.outlook.com (10.13.179.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.13 via Frontend Transport; Fri, 30 Jun 2023 22:41:11 +0000 Received: from p-exchbe-eqx-02.jnpr.net (10.104.9.15) by p-exchfe-eqx-01.jnpr.net (10.104.9.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21; Fri, 30 Jun 2023 17:41:10 -0500 Received: from p-mailhub01.juniper.net (10.104.20.6) by p-exchbe-eqx-02.jnpr.net (10.104.9.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.21 via Frontend Transport; Fri, 30 Jun 2023 17:41:10 -0500 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.255.201]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id 35UMf9eK006679; Fri, 30 Jun 2023 15:41:09 -0700 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id AC0FD8D819; Fri, 30 Jun 2023 15:40:42 -0700 (PDT) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id AA6938D7A0; Fri, 30 Jun 2023 15:40:42 -0700 (PDT) To: Rob Wing CC: Jessica Clarke , Mitchell Horne , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Subject: Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors In-Reply-To: References: <202306300652.35U6qpgP027126@gitrepo.freebsd.org> <667C347E-B7C7-405B-AFEC-F0A0FD0656F6@freebsd.org> <498f3ba2-dc7a-e7d3-626a-76ca68cee5b2@freebsd.org> <79845.1688159657@kaos.jnpr.net> Comments: In-reply-to: Rob Wing message dated "Fri, 30 Jun 2023 13:52:37 -0800." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 28.2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <41426.1688164842.1@kaos.jnpr.net> Date: Fri, 30 Jun 2023 15:40:42 -0700 Message-ID: <44286.1688164842@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM12FT076:EE_|CO1PR05MB7909:EE_ X-MS-Office365-Filtering-Correlation-Id: 35d2967e-d300-4a59-d330-08db79bb1a5b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ayQb7fauN0cPAZzMvRk7UIMQo6AhCy1eqjll65xRzNStpUotnb8uoZbfKU02QJ7eygBZXwF1TWgQwgDrtQLMpQQQTT2h64na4xC1Y2Udnj1zHetpw/2WdbJ8b7uVR4b6mBfxx5fvp7HUN/d+pRKOAPLeq428D3eK0T0CeQiTdOq8tt+yctlXBArkWz5J58Su+LGpELcC1KB/Q0sI+dAgVmqMS/PzYBuGFeeqe7/4LitsuTdIs9cwqtu17QCsRgRt0YOsL7YfHQYjZo/oYQOnttUurq79uoQBOfTAmJ7MiaO/f/Gek1qNAgoVR+QjPqAIT+6VbPNlUcuzTKRuqXoG4c3vDVgYkH6Vrv0/KS5Hu/0+Txm5DwzlXRUsUacvjmLswi4plTAGGY8uqyd/AFQJjy21sKZB9mMarAw2WkBTGfOI/muwcOZh2Ot9OeuKmtYfd90dE4gv9QYoTWqjY3vtokzGMn8Y7K2Bl4oBA8aUVcrjmYmx7Nk/3SH+Gx8JkcZv6PHQBPx4DgXpj2NNXJ0o8abGpMuN/MdaxDfIpLbarteJEs0YJJ/scUEf3EI3obJnoopfd8W2qgoFFJf5a25uH0+TxMFL3JcSO0BgBDrOjYZ6Gz6oFtBxcGqzyj+dM3SZ9dRAPeRzyw9MT8JLjweiWgdz5cVOfRFG3MZmQ9S1CbbpdN61s8IK9hP+ufMbO29LNrBkZMTnZttbwBc/g0HPFqzNn77Zx+3jvThtRQ3mUdYsU+ok6a0jlqws3AJOVfFR8PRqGRJtFpgEA3aCUt1xH+bkQf1LhSeCIaDytq3umCeUQ7QfdhObkW5/PIkBgiEH X-Forefront-Antispam-Report: CIP:66.129.239.14;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:p-exchfe-eqx-01.jnpr.net;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(136003)(376002)(39860400002)(346002)(396003)(451199021)(40470700004)(46966006)(36840700001)(107886003)(86362001)(54906003)(8936002)(8676002)(5660300002)(82310400005)(26005)(9686003)(7696005)(478600001)(6916009)(4326008)(70206006)(70586007)(41300700001)(316002)(6266002)(186003)(7126003)(2906002)(4744005)(40460700003)(47076005)(55016003)(336012)(36860700001)(40480700001)(82740400003)(356005)(81166007)(36900700001);DIR:OUT;SFP:1102; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 22:41:11.0190 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35d2967e-d300-4a59-d330-08db79bb1a5b X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4;Ip=[66.129.239.14];Helo=[p-exchfe-eqx-01.jnpr.net] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM12FT076.eop-nam12.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR05MB7909 X-Proofpoint-ORIG-GUID: uuALbe1RZFMFx9y2aiHu1W_ZsmeQEeWy X-Proofpoint-GUID: uuALbe1RZFMFx9y2aiHu1W_ZsmeQEeWy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-30_12,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1011 spamscore=0 mlxlogscore=688 adultscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306300198 X-Spamd-Result: default: False [-3.60 / 15.00]; SUSPICIOUS_RECIPS(1.50)[]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[juniper.net,reject]; R_DKIM_ALLOW(-0.20)[juniper.net:s=PPS1017,juniper.net:s=selector1]; R_SPF_ALLOW(-0.20)[+ip4:208.84.65.16]; RCVD_IN_DNSWL_LOW(-0.10)[208.84.65.16:from]; MIME_GOOD(-0.10)[text/plain]; FREEFALL_USER(0.00)[sjg]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; TAGGED_RCPT(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[40.93.11.34:received]; ASN(0.00)[asn:26211, ipnet:208.84.65.0/24, country:US]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[juniper.net:+]; TO_DN_SOME(0.00)[]; RCVD_COUNT_SEVEN(0.00)[11]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; TO_DN_EQ_ADDR_SOME(0.00)[] X-Rspamd-Queue-Id: 4Qt9Kc6S8zz4JKr X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Rob Wing wrote: > + if (!cn.status) { > buf = NULL; > + if (err == 0) /* keep compiler happy */ > + buf = NULL; > + } > return (buf); > } > > And considering the comment at contrib/bearssl/inc/bearssl_x509.h > is it intended for buf to be returned as-is (i.e., not set to NULL) > when the decoding status indicates an error condition? Good question, probably not, will fix. Thanks for spotting.