Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors

Reply: Rob Wing : "Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors"
In reply to: Jessica Clarke : "Re: git: 56f3f2d2491e - main - libsecureboot: avoid set but not used errors"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Simon J. Gerraty <sjg_at_juniper.net>
Date: Fri, 30 Jun 2023 21:14:17 UTC

Jessica Clarke <jrtc27@freebsd.org> wrote:
> A conditional assignment of the same value that has already been
> assigned unconditionally is unidiomatic code generally regarded as a
> code smell and should be avoided. In an ideal world that would give a

I agree.

I've been bitten by __unused recently when porting stuff to linux
so was looking to avoid that.