From nobody Thu Jun 29 08:20:43 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QsBGh2tj9z4knkj; Thu, 29 Jun 2023 08:20:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QsBGg5jtYz3w0y; Thu, 29 Jun 2023 08:20:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688026843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rMVeiHLnpYjWr1tAUg0EzvD1Wv0poQPEscQfj2hMT1o=; b=oREiaIgWoFOvYU90HCSpO9FNWO8oFWiQCSRGez0nn/hBoKiSc0u8tJUqZiiH9Tyt8gyx62 Ffhqdy0vuQjVl5iYzzWV0ieEYuSTrw9kZZ9UzBRsJhuj28zMptRekgP48iGaDWLGZgBTb2 frRO3UwJORO5YOwXHGuEvH7c213An1w9RLeblqjyg9S4RKkbd2zGZDTlC6fOKX/TA46/CZ 8GcHbq2A34qN86DJDmFhiGDIpR6YrMPDXWQLnFA41HYNP0FggAgNqcUse9+PmI0uqqrLjm UJNmNcn6L1Fx+McWJHzP4W3VkPkX2jCzTpL3QGkzxriU2dXT9P9TkoIL9nX6Dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688026843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rMVeiHLnpYjWr1tAUg0EzvD1Wv0poQPEscQfj2hMT1o=; b=sGqA0aVGAE/r+tR+SQ600SlRVJ4R/LWHEIqLa2/Ds+izJCjU9zFtOH/gPQvS6574EvJVM5 m4uyDu2c6Ujy4SFY0rQ55qFqXTP9NN3fNwmKVm5LGaEVQvmhS1WhEzHE7xWl4M4s/U+6Hg ++CV5cTs4UC6bC9B707NIFb6GNiypHr59KtN4XojrBURPCjAtMf0SUgCke30cyx/vmYc2B CM1w2R1S6fGA39j36QFIyytvUm2FrCNREdroFZHzOTGIkaaDeJyCyz6ABxJxEA3GHBDDQb fWcWRDFTKmYUJ47tDDy7TSusDBKOrU3gBgmfB5UxwHsMpvHTulXeCYu4RQt1LQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688026843; a=rsa-sha256; cv=none; b=vK0cQ4pdW7T50BTkRIJNczc+Km0amOK85/jJYxyveCCsBoTXE7PXAnotNyKTefNDJtsKyw 5gHODxoYg3qsFxDGGbr7XMeXnwh9g+DA2ttzny1O2mTaYuE3+0e3u60/zmeGRatXfuRohp NvnC1TxN7xV8pvWvq2if98FpA5knnSHvwUGk+20Z0NyGHrbD5YLuTntVAkohqk8ElYAcsv U7dzLlps33+3SoB+LNhrb1M4HC37aVVOrpT+LQk0ch2LISS7SZinDKVbQBgBn6xn3Ba8M4 rT0Ogm6c9f57QbVaLRDisgJu87Hn3ZJBXTn3I7nMdh3TAzJjTlEN9OZA0Hi7sg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QsBGg48v3z17sp; Thu, 29 Jun 2023 08:20:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 35T8KhcO084649; Thu, 29 Jun 2023 08:20:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 35T8Kh1Y084648; Thu, 29 Jun 2023 08:20:43 GMT (envelope-from git) Date: Thu, 29 Jun 2023 08:20:43 GMT Message-Id: <202306290820.35T8Kh1Y084648@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dmitry Chagin Subject: git: d56be4992dc7 - stable/13 - linux(4): Drop a weird comment from linux_set_syscall_retval on amd64 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dchagin X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: d56be4992dc753bc08c10223996501be46aceb64 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=d56be4992dc753bc08c10223996501be46aceb64 commit d56be4992dc753bc08c10223996501be46aceb64 Author: Dmitry Chagin AuthorDate: 2023-05-28 14:05:44 +0000 Commit: Dmitry Chagin CommitDate: 2023-06-29 08:16:01 +0000 linux(4): Drop a weird comment from linux_set_syscall_retval on amd64 I agree, it would be great to avoid PCB_FULL_IRET, however we should follow Linux system call ABI. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D40152 MFC after: 1 month (cherry picked from commit a99b890ecd26131e0c91e5693b55f5700c40a847) --- sys/amd64/linux/linux_sysvec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/amd64/linux/linux_sysvec.c b/sys/amd64/linux/linux_sysvec.c index 5e7bc96d0148..f43e7d3a02bc 100644 --- a/sys/amd64/linux/linux_sysvec.c +++ b/sys/amd64/linux/linux_sysvec.c @@ -191,9 +191,6 @@ linux_set_syscall_retval(struct thread *td, int error) * and %r11 values are not preserved across the syscall. * Require full context restore to get all registers except * those two restored at return to usermode. - * - * XXX: Would be great to be able to avoid PCB_FULL_IRET - * for the error == 0 case. */ set_pcb_flags(td->td_pcb, PCB_FULL_IRET); }