From nobody Wed Jun 28 15:20:15 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QrldC72pDz4jq2g; Wed, 28 Jun 2023 15:20:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QrldC6dhvz44Y4; Wed, 28 Jun 2023 15:20:15 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687965615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hYKR1LQTpoA574vJLNVjLu+e5yT08tT1mlONzB5m2kU=; b=Jy6/dB0NBCtjlmbLSdLnXu2vSm3vaDS88C90zcew3ldnH/krJPLFW91XyQpcAVFcyWYV/w MiS/xBIABUGKLtfPo6rEAHG05DONZESrT1Dc1qG259rHlj8FkWGCcc9Vy98fnJT2QrJ8Kk tSe6tVtaCBA0Em27OGAlg7eqHZCegcKPKIZGFAN6jq1210Ob4mj2pQpTBqnnZ9+sIWpnqQ HluDsTHQvpsyGYoMofZOKjsroCBXi5wI5Sy1zDRDvyiWZWDjvFGu07Y1FHMAimGpEJz7Jg MYveIZyT/F7rr6tOC44KYGOO9C4EEl8V2XA1wX2oA8jCEMuD1v3dVgJQNnoZqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687965615; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hYKR1LQTpoA574vJLNVjLu+e5yT08tT1mlONzB5m2kU=; b=KQGzFuge243EM6ILZYLSTwxxr0Dlpukv/fGdHcDW0ZhxVvW7VXoM79lb3Gj9jCL4Yo5wY0 18Q2fhLnDaO6bUOLiMLV/rgfGsktjtrRoVcddWncRKLhi4sFQdZhtJjQ1he1EfWciHFsDZ AAKwDec671zmliCL8Bc6w1aO1uAhwDLUUF9R0d9oRqKbdIwPCDa7J/kZtSc5apfzU0IZL2 AhYJSWUoQgC9JrbFsBsO9oaXwIPZW1a2aTcIqP0SR5Ap17+PmnlxgXhq2HMC4MUpYH9tR1 46FQqPqKXIdbP0hSORpj6ZLuMUoW+yrxIObKP1VCSEUNj7D3J8CyJtdX+/iUUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687965615; a=rsa-sha256; cv=none; b=YtbS/KHnCUGNx1uD4pZSzEJx/nnQF0md7SQH3zupWY9D1ABfeTQ0NJLpNGyBDNDC3I5rlZ h48+hYvie91M47HL9gtK/N73FcDYUXhb9tHq3u8SnQTa4iT403ZzmcuuftPvF9rHNbEhDh 3Z6bT0yt1IDrNz5OPtfHyf8xnPbDJufJc6V1RfVbHUCYooQG6thTDYT9KCz8EAf6SXBapd gvcC6kjTIPYceO7QNQ5TzIDfSfECun8aVrzQ8X2pqHIuK5Hj6CgwCrzUkhaRmBwRT1SoK2 mAjGtB66OuEszb4aOrDCnyeNKuhHPNElc1aY/FpvV5yQnHUjb4Fmhy7lHdqWSw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QrldC5cXczdqV; Wed, 28 Jun 2023 15:20:15 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 35SFKFxE017569; Wed, 28 Jun 2023 15:20:15 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 35SFKFbY017563; Wed, 28 Jun 2023 15:20:15 GMT (envelope-from git) Date: Wed, 28 Jun 2023 15:20:15 GMT Message-Id: <202306281520.35SFKFbY017563@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Randall Stewart Subject: git: 96eb0d90cd75 - main - tcp: With the right options in the kernel cc_cubic stays in slowstart always. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rrs X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 96eb0d90cd75c56517bef952a03240f82f525d2e Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rrs: URL: https://cgit.FreeBSD.org/src/commit/?id=96eb0d90cd75c56517bef952a03240f82f525d2e commit 96eb0d90cd75c56517bef952a03240f82f525d2e Author: Randall Stewart AuthorDate: 2023-06-28 15:18:47 +0000 Commit: Randall Stewart CommitDate: 2023-06-28 15:18:47 +0000 tcp: With the right options in the kernel cc_cubic stays in slowstart always. So this is a subtle bug I have found in cubic. If you compile a number of options into the kernel (accounting and tracking) then all of the kernel code "knows" the proper offset of t_rttupdatecnt however cubic does not see the options (and htcp too) and thus will look for the count in the wrong place seeing 0. Which then means it never builds an MIN RTT which then means it always hangs in slowstart. The solution is to put all options that effect tcpcb size into the opt_global.h so that the kernel has a consistent view of the tcpcb size. Reviewed by: tuexen, rscheff Sponsored by: Netflix Inc Differential Revision:https://reviews.freebsd.org/D40761 --- sys/conf/options | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/conf/options b/sys/conf/options index 7a34fa0f7333..6f1a488bf33f 100644 --- a/sys/conf/options +++ b/sys/conf/options @@ -229,7 +229,7 @@ SYSVSHM opt_sysvipc.h SW_WATCHDOG opt_watchdog.h TCPHPTS opt_inet.h TCP_REQUEST_TRK opt_global.h -TCP_ACCOUNTING opt_inet.h +TCP_ACCOUNTING opt_global.h # # TCP SaD Detection is an experimental Sack attack Detection (SaD) # algorithm that uses "normal" behaviour with SACK's to detect