From nobody Mon Jun 19 11:07:36 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ql6Rr5ZqRz4fTtX; Mon, 19 Jun 2023 11:07:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ql6Rr2dsPz3h7R; Mon, 19 Jun 2023 11:07:36 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687172856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yxvYVOge8/mgs4ttgVNJW1WjCFbCWCnMlGG0go4Gpvg=; b=lPrCHMUPudK5narflsATbjrOyQPXhILC7wiDjmlH2u+ivcI0Lf8lpC7VNoQ9LZtO2QlHYv utac++NpH5hkOLt6j+RsIC+bt5S0nOQ3SpNnZrJ3/oD7ktwuCckqC7Eq9ZEe8IKsHYf8bZ gM99oAXp9VH+cc7M+OorNAVuTbhnkio9jKZVGf30YKk58eeJ3uUZCYiHEyEYWiCSqEWfwA qC6GN0+AF7RpW/qCC8k5hGjXuIStgDw9gsH5Z2lBoKse5ht/OaxbVJXFOtqaANwofppXdE 1gFsBL638oxrTD2mMjtGDBuqRCgT1miipShh/6TtWxa5lZ28fJqaTRQfkLXf7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687172856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yxvYVOge8/mgs4ttgVNJW1WjCFbCWCnMlGG0go4Gpvg=; b=EoIL4o6iAIrACxaCvGfEL0n5BLmdDPHj6m32iBjlpsMAt2Mf2V9K1RhPNnog9ra7tcaoC3 3AI1APnAJZQqkjo+BVe3hLGiCQwf9DFBL93z2zG4c3qkrYvQxmfFpWhaZ5/MuQm/A/6r+Q D3uo3+btd8CuofZYW9Nkee6BCLmjcLkmLY2SDiwJpFjN+hJ13TWGlB1D+1YAYZ1YyacKqC MagY4CmTtyfkvdlM7XV0sf774GkC0Rklm9wWcTVMbkdwn/8eBPuKZMUipRGvlx3aAf5S45 77hlozCLL4xYGKxlDppYUqSReNPim6XFEb0ovRhaJTcIFk5PQ3Soo/0OIjRAWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687172856; a=rsa-sha256; cv=none; b=hIg37qjCdNoKznv79Op+Qf8krCLKP2/3if3ohHauaZEugMU8FTz/T2QHW2nrkRxv0RQ227 QCJipBGr9zDQDJlT62QdY+UeBeEv1wZ9gVlg0y+lhgHBgXilorHeoDwTKgLrm8PZtN+3NE taIwZuzlF8AkNpLsfGEdk/2R/PsC/Kx+XLWLgreuhS8MTvmu18ST+G3lnPsZt4WH6TjLtD DJaCOzzZhRY/MsPfnXv3+vDynEEuwPFkk8nrdxjbRKOly6VzGq5kQBrddDVNgpWvZS4Trd LhOmWtuH/D/o/eD8wHTijsVY2PjBaXDXW+40n+BhGmoJnDwnYeNLOixkl6TYzA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Ql6Rr1l1nzFZM; Mon, 19 Jun 2023 11:07:36 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 35JB7aie037999; Mon, 19 Jun 2023 11:07:36 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 35JB7aWU037998; Mon, 19 Jun 2023 11:07:36 GMT (envelope-from git) Date: Mon, 19 Jun 2023 11:07:36 GMT Message-Id: <202306191107.35JB7aWU037998@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Benedict Reuschling Subject: git: 7ad4d94d5bf2 - main - Fix some shell issues by adding quotes and replace backticks with $() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bcr X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7ad4d94d5bf275f745907d8bf4614219f5ce4d34 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by bcr: URL: https://cgit.FreeBSD.org/src/commit/?id=7ad4d94d5bf275f745907d8bf4614219f5ce4d34 commit 7ad4d94d5bf275f745907d8bf4614219f5ce4d34 Author: Benedict Reuschling AuthorDate: 2023-06-19 11:03:06 +0000 Commit: Benedict Reuschling CommitDate: 2023-06-19 11:03:06 +0000 Fix some shell issues by adding quotes and replace backticks with $() This patch fixes the following issues reported by shellcheck: - Quote default assignments (SC2223) - Use $() instead of backticks (SC2006) - Double quote $@ (SC2068) - Double quote variables in if-statements and other places (SC2086) While here, fix a whitespace at one end of line instance in the license text. Approved by: manu Differential Revision: https://reviews.freebsd.org/D40604 --- usr.sbin/fwget/fwget.sh | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/usr.sbin/fwget/fwget.sh b/usr.sbin/fwget/fwget.sh index 2d5ad8adffd8..61acaee86687 100644 --- a/usr.sbin/fwget/fwget.sh +++ b/usr.sbin/fwget/fwget.sh @@ -7,7 +7,7 @@ # Copyright 2023 Bjoern A. Zeeb # # Redistribution and use in source and binary forms, with or without -# modification, are permitted providing that the following conditions +# modification, are permitted providing that the following conditions # are met: # 1. Redistributions of source code must retain the above copyright # notice, this list of conditions and the following disclaimer. @@ -27,12 +27,12 @@ # IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE # POSSIBILITY OF SUCH DAMAGE. -: ${LIBEXEC_PATH:="/usr/libexec/fwget"} +: "${LIBEXEC_PATH:='/usr/libexec/fwget'}" usage() { cat <